| Message ID | 4C866458.50401@users.sourceforge.net |
|---|---|
| State | New |
| Headers | show |
On 09/07/2010 06:12 PM, JonY wrote: > Looks like most of the changes are in, the only parts needed changing was: > > Index: config/dfp.m4 > =================================================================== > --- config/dfp.m4 (revision 163959) > +++ config/dfp.m4 (working copy) > @@ -20,7 +20,9 @@ > ], > [ > case $1 in > - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*) > + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux* | \ > + i?86*-*-mingw* | x86_64*-*-mingw* |\ > + i?86*-*-cygwin* ) > enable_decimal_float=yes > ;; > *) > This looks fine, thanks. Dave/Kai? Paolo
2010/9/7 Paolo Bonzini <bonzini@gnu.org>: > On 09/07/2010 06:12 PM, JonY wrote: >> >> Looks like most of the changes are in, the only parts needed changing was: >> >> Index: config/dfp.m4 >> =================================================================== >> --- config/dfp.m4 (revision 163959) >> +++ config/dfp.m4 (working copy) >> @@ -20,7 +20,9 @@ >> ], >> [ >> case $1 in >> - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >> s390*-*-linux*) >> + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >> s390*-*-linux* | \ >> + i?86*-*-mingw* | x86_64*-*-mingw* |\ >> + i?86*-*-cygwin* ) >> enable_decimal_float=yes >> ;; >> *) >> > > This looks fine, thanks. Dave/Kai? > > Paolo > Yes, this is ok by me. Paolo, will you commit it, or should I do? Thanks, Kai
On 09/07/2010 07:25 PM, Kai Tietz wrote: > 2010/9/7 Paolo Bonzini<bonzini@gnu.org>: >> On 09/07/2010 06:12 PM, JonY wrote: >>> >>> Looks like most of the changes are in, the only parts needed changing was: >>> >>> Index: config/dfp.m4 >>> =================================================================== >>> --- config/dfp.m4 (revision 163959) >>> +++ config/dfp.m4 (working copy) >>> @@ -20,7 +20,9 @@ >>> ], >>> [ >>> case $1 in >>> - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>> s390*-*-linux*) >>> + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>> s390*-*-linux* | \ >>> + i?86*-*-mingw* | x86_64*-*-mingw* |\ >>> + i?86*-*-cygwin* ) >>> enable_decimal_float=yes >>> ;; >>> *) >>> >> >> This looks fine, thanks. Dave/Kai? >> >> Paolo >> > > Yes, this is ok by me. Paolo, will you commit it, or should I do? Please do it for both gcc and src. Paolo
On 07/09/2010 18:25, Kai Tietz wrote: > 2010/9/7 Paolo Bonzini <bonzini@gnu>: >> On 09/07/2010 06:12 PM, JonY wrote: >>> Looks like most of the changes are in, the only parts needed changing was: >>> >>> Index: config/dfp.m4 >>> =================================================================== >>> --- config/dfp.m4 (revision 163959) >>> +++ config/dfp.m4 (working copy) >>> @@ -20,7 +20,9 @@ >>> ], >>> [ >>> case $1 in >>> - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>> s390*-*-linux*) >>> + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>> s390*-*-linux* | \ >>> + i?86*-*-mingw* | x86_64*-*-mingw* |\ >>> + i?86*-*-cygwin* ) >>> enable_decimal_float=yes >>> ;; >>> *) >>> >> This looks fine, thanks. Dave/Kai? >> >> Paolo >> > > Yes, this is ok by me. Me too, in principle. The final piece of the puzzle AFAICT is that we still need to enable libbid in libgcc by adding the t-dfprules make frag. I'm testing the attached patch on Cygwin; I've attached an untested (but hopefully correct) equivalent for MinGW. I can't apply this for Cygwin yet because it needs fenv.h support to build, but MinGW should be OK (someone had still better test it though, I'm not set up for testing on MinGW right now). (I've got a patch to contribute fenv support to Cygwin that's about 90% done, and I'll apply the Cygwin patch once that's been sent upstream and incorporated.) Until this is done, there will still be regressions in the testsuite owing to link failures, but that's not a reason not to start enabling DFP by default; the compiler side of it all works even if the libc side isn't complete at the Cygwin end. cheers, DaveK
2010/9/9 Dave Korn <dave.korn.cygwin@gmail.com>: > On 07/09/2010 18:25, Kai Tietz wrote: >> 2010/9/7 Paolo Bonzini <bonzini@gnu>: >>> On 09/07/2010 06:12 PM, JonY wrote: >>>> Looks like most of the changes are in, the only parts needed changing was: >>>> >>>> Index: config/dfp.m4 >>>> =================================================================== >>>> --- config/dfp.m4 (revision 163959) >>>> +++ config/dfp.m4 (working copy) >>>> @@ -20,7 +20,9 @@ >>>> ], >>>> [ >>>> case $1 in >>>> - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>>> s390*-*-linux*) >>>> + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | >>>> s390*-*-linux* | \ >>>> + i?86*-*-mingw* | x86_64*-*-mingw* |\ >>>> + i?86*-*-cygwin* ) >>>> enable_decimal_float=yes >>>> ;; >>>> *) >>>> >>> This looks fine, thanks. Dave/Kai? >>> >>> Paolo >>> >> >> Yes, this is ok by me. > > Me too, in principle. The final piece of the puzzle AFAICT is that we still > need to enable libbid in libgcc by adding the t-dfprules make frag. I'm > testing the attached patch on Cygwin; I've attached an untested (but hopefully > correct) equivalent for MinGW. > > I can't apply this for Cygwin yet because it needs fenv.h support to build, > but MinGW should be OK (someone had still better test it though, I'm not set > up for testing on MinGW right now). > > (I've got a patch to contribute fenv support to Cygwin that's about 90% > done, and I'll apply the Cygwin patch once that's been sent upstream and > incorporated.) > > Until this is done, there will still be regressions in the testsuite owing > to link failures, but that's not a reason not to start enabling DFP by > default; the compiler side of it all works even if the libc side isn't > complete at the Cygwin end. > > cheers, > DaveK > > Yeah, I found the same issue about the original patch. I was just bootstrapping mingw's 32-bit and 64-bit version (for the latter I found some fallout by the .cfi enabling for windows targets together with HWINT=64-bit). When my tests are through, I am fine with this additional configuration patch. If you prefer I can remove i?86*-*-cygwin* for dfp.m4, so you won't have failures here. Cheers, Kai
On 09/09/2010 21:20, Kai Tietz wrote: > When my tests are through, I am fine with this additional > configuration patch. If you prefer I can remove i?86*-*-cygwin* for > dfp.m4, so you won't have failures here. Nah, as long as I don't add the libgcc configuration before Cygwin supports fenv.h, the build won't break; people just won't be able to fully use the dfp support yet. But since the compiler side will work, and they could always in theory supply their own libbid routines to link against, I think it's OK to have it enabled. The support will be in Cygwin before 4.6.0 gets released. cheers, DaveK
2010/9/9 Dave Korn <dave.korn.cygwin@gmail.com>: > On 09/09/2010 21:20, Kai Tietz wrote: > >> When my tests are through, I am fine with this additional >> configuration patch. If you prefer I can remove i?86*-*-cygwin* for >> dfp.m4, so you won't have failures here. > > Nah, as long as I don't add the libgcc configuration before Cygwin supports > fenv.h, the build won't break; people just won't be able to fully use the dfp > support yet. But since the compiler side will work, and they could always in > theory supply their own libbid routines to link against, I think it's OK to > have it enabled. The support will be in Cygwin before 4.6.0 gets released. > > cheers, > DaveK > > So committed after bootstrap test for x86_64-w64-mingw32 and i686-w64-mingw32. ChangeLog config 2010-09-10 Jonathan Yong <jon_y@users.sourceforge.net> * dfp.m4: Enable decimal float for i?86 cygwin and mingw, and for x86_64 mingw. ChangeLog libgcc 2010-09-10 Kai Tietz <kai.tietz@onevision.com> * configure: Regenerated. ChangeLog libdecnumber 2010-09-10 Kai Tietz <kai.tietz@onevision.com> * configure: Regenerated. ChangeLog gcc 2010-09-10 Kai Tietz <kai.tietz@onevision.com> * configure: Regenerated. * config.gcc: Add for x86_64 and i?86 mingw t-dfprule. At revision 164167. Regards, Kai PS: Yes, fenv.h isn't an issue for mingw as we provide it already.
Index: config/dfp.m4 =================================================================== --- config/dfp.m4 (revision 163959) +++ config/dfp.m4 (working copy) @@ -20,7 +20,9 @@ ], [ case $1 in - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*) + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux* | \ + i?86*-*-mingw* | x86_64*-*-mingw* |\ + i?86*-*-cygwin* ) enable_decimal_float=yes ;; *)