| Message ID | 1480931523-5769-1-git-send-email-jasowang@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/3] Net patches
Type: series
Message-id: 1480931523-5769-1-git-send-email-jasowang@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
18cd9a6 fsl_etsec: Fix various small problems in hexdump code
947509b fsl_etsec: Pad short payloads with zeros
e2362ab net: mcf: check receive buffer size register value
=== OUTPUT BEGIN ===
Checking PATCH 1/3: net: mcf: check receive buffer size register value...
Checking PATCH 2/3: fsl_etsec: Pad short payloads with zeros...
ERROR: braces {} are necessary for all arms of this statement
#33: FILE: hw/net/fsl_etsec/rings.c:481:
+ if (etsec->rx_buffer_len < 60)
[...]
total: 1 errors, 0 warnings, 13 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: fsl_etsec: Fix various small problems in hexdump code...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On Mon, Dec 05, 2016 at 05:52:00PM +0800, Jason Wang wrote: > The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: > > Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into staging (2016-12-01 13:39:29 +0000) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 18766d28848f2a4c309e78c6706b872f2cb32786: > > fsl_etsec: Fix various small problems in hexdump code (2016-12-05 17:45:14 +0800) > > ---------------------------------------------------------------- Please resend with the coding style violation fixed. See the patchew email for details.
On 2016年12月05日 22:35, Stefan Hajnoczi wrote: > On Mon, Dec 05, 2016 at 05:52:00PM +0800, Jason Wang wrote: >> The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: >> >> Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into staging (2016-12-01 13:39:29 +0000) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to 18766d28848f2a4c309e78c6706b872f2cb32786: >> >> fsl_etsec: Fix various small problems in hexdump code (2016-12-05 17:45:14 +0800) >> >> ---------------------------------------------------------------- > Please resend with the coding style violation fixed. See the patchew > email for details. V2 posted. Thanks
The following changes since commit bd8ef5060dd2124a54578241da9a572faf7658dd: Merge remote-tracking branch 'dgibson/tags/ppc-for-2.8-20161201' into staging (2016-12-01 13:39:29 +0000) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to 18766d28848f2a4c309e78c6706b872f2cb32786: fsl_etsec: Fix various small problems in hexdump code (2016-12-05 17:45:14 +0800) ---------------------------------------------------------------- ---------------------------------------------------------------- Andrey Smirnov (2): fsl_etsec: Pad short payloads with zeros fsl_etsec: Fix various small problems in hexdump code Prasad J Pandit (1): net: mcf: check receive buffer size register value hw/net/fsl_etsec/etsec.c | 4 ++-- hw/net/fsl_etsec/rings.c | 7 +++++++ hw/net/mcf_fec.c | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-)