diff mbox

bind: don't lookup zlib.h in host headers

Message ID e3ea410def37657791e392d7b96910ed79041b8e.1476865452.git.baruch@tkos.co.il
State Accepted
Commit 8ec6dae302e31af3869be5ad0af79e8d18416ff7
Headers show

Commit Message

Baruch Siach Oct. 19, 2016, 8:24 a.m. UTC
configure.in looks in host headers for zlib.h, unless given a headers
directory as --with-zlib parameter.

Note: a bug in the zlib.h header lookup logic causes configure.in to add
-l$(STAGING_DIR)/usr/include/include, and -L$(STAGING_DIR)/usr/include/lib.
But this does not affect us.

Fixes:
http://autobuild.buildroot.net/results/e96/e96a36c4da3c3be4b79a27af75a70bb8955c31a9/
http://autobuild.buildroot.net/results/e0b/e0bd7df5c19c7c65ce0009b7c2b4d4104a5c3109/
http://autobuild.buildroot.net/results/e99/e993940067f7ae841132765f91bfee7248ab125f/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/bind/bind.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Oct. 19, 2016, 9:23 a.m. UTC | #1
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > configure.in looks in host headers for zlib.h, unless given a headers
 > directory as --with-zlib parameter.

 > Note: a bug in the zlib.h header lookup logic causes configure.in to add
 > -l$(STAGING_DIR)/usr/include/include, and -L$(STAGING_DIR)/usr/include/lib.
 > But this does not affect us.

 > Fixes:
 > http://autobuild.buildroot.net/results/e96/e96a36c4da3c3be4b79a27af75a70bb8955c31a9/
 > http://autobuild.buildroot.net/results/e0b/e0bd7df5c19c7c65ce0009b7c2b4d4104a5c3109/
 > http://autobuild.buildroot.net/results/e99/e993940067f7ae841132765f91bfee7248ab125f/

 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.
diff mbox

Patch

diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index cda9fed875f9..9b5d8c56de6d 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -33,7 +33,7 @@  BIND_CONF_OPTS = \
 	--enable-filter-aaaa
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
-BIND_CONF_OPTS += --with-zlib
+BIND_CONF_OPTS += --with-zlib=$(STAGING_DIR)/usr/include
 BIND_DEPENDENCIES += zlib
 else
 BIND_CONF_OPTS += --without-zlib