| Message ID | 20160918141311.17140-1-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Alexandre Courbot |
| Headers | show |
On 18/09/16 15:13, Paul Kocialkowski wrote: > This enables the GPU node for tegra124 nyan boards, which is required to > get graphics acceleration with nouveau on these devices. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi > index dab9509..225ca77 100644 > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi > @@ -42,6 +42,12 @@ > }; > }; > > + gpu@0,57000000 { > + status = "okay"; > + > + vdd-supply = <&vdd_gpu>; > + }; > + > serial@70006000 { > /* Debug connector on the bottom of the board near SD card. */ > status = "okay"; > @@ -214,7 +220,7 @@ > regulator-always-on; > }; > > - sd6 { > + vdd_gpu: sd6 { > regulator-name = "+VDD_GPU_AP"; > regulator-min-microvolt = <650000>; > regulator-max-microvolt = <1200000>; > Looks good to me. I see the following error when booting but looking at the code appears to be benign. Thierry, Alex, is this normal/okay? [ 5.715181] nouveau 57000000.gpu: NVIDIA GK20A (0ea000a1) [ 5.720625] nouveau 57000000.gpu: imem: using IOMMU [ 5.803694] nouveau 57000000.gpu: DRM: VRAM: 0 MiB [ 5.808501] nouveau 57000000.gpu: DRM: GART: 1048576 MiB [ 5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel, -22 [ 5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies Cheers Jon
Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : > On 18/09/16 15:13, Paul Kocialkowski wrote: > > > > This enables the GPU node for tegra124 nyan boards, which is required to > > get graphics acceleration with nouveau on these devices. > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > --- > > arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi > > b/arch/arm/boot/dts/tegra124-nyan.dtsi > > index dab9509..225ca77 100644 > > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi > > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi > > @@ -42,6 +42,12 @@ > > }; > > }; > > > > + gpu@0,57000000 { > > + status = "okay"; > > + > > + vdd-supply = <&vdd_gpu>; > > + }; > > + > > serial@70006000 { > > /* Debug connector on the bottom of the board near SD card. > > */ > > status = "okay"; > > @@ -214,7 +220,7 @@ > > regulator-always-on; > > }; > > > > - sd6 { > > + vdd_gpu: sd6 { > > regulator-name = "+VDD_GPU_AP"; > > regulator-min-microvolt = <650000>; > > regulator-max-microvolt = > > <1200000>; > > > > Looks good to me. I see the following error when booting but looking at the > code appears to be benign. Thierry, Alex, is this normal/okay? I have the same messages and asked Alexandre about them the other day. He told me that it looks normal. > [ 5.715181] nouveau 57000000.gpu: NVIDIA GK20A > (0ea000a1) > > [ 5.720625] nouveau 57000000.gpu: imem: using > IOMMU > > [ 5.803694] nouveau 57000000.gpu: DRM: VRAM: 0 > MiB > > [ 5.808501] nouveau 57000000.gpu: DRM: GART: 1048576 > MiB > > [ 5.816000] nouveau 57000000.gpu: DRM: failed to create ce channel, > -22 > > [ 5.924140] nouveau 57000000.gpu: DRM: MM: using GRCE for buffer copies > > Cheers > Jon >
On 20/09/16 19:17, Paul Kocialkowski wrote: > * PGP Signed by an unknown key > > Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : >> On 18/09/16 15:13, Paul Kocialkowski wrote: >>> >>> This enables the GPU node for tegra124 nyan boards, which is required to >>> get graphics acceleration with nouveau on these devices. >>> >>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr> >>> --- >>> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >>> b/arch/arm/boot/dts/tegra124-nyan.dtsi >>> index dab9509..225ca77 100644 >>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >>> @@ -42,6 +42,12 @@ >>> }; >>> }; >>> >>> + gpu@0,57000000 { >>> + status = "okay"; >>> + >>> + vdd-supply = <&vdd_gpu>; >>> + }; >>> + >>> serial@70006000 { >>> /* Debug connector on the bottom of the board near SD card. >>> */ >>> status = "okay"; >>> @@ -214,7 +220,7 @@ >>> regulator-always-on; >>> }; >>> >>> - sd6 { >>> + vdd_gpu: sd6 { >>> regulator-name = "+VDD_GPU_AP"; >>> regulator-min-microvolt = <650000>; >>> regulator-max-microvolt = >>> <1200000>; >>> >> >> Looks good to me. I see the following error when booting but looking at the >> code appears to be benign. Thierry, Alex, is this normal/okay? > > I have the same messages and asked Alexandre about them the other day. He told > me that it looks normal. Ok great. Hopefully, Alex can ACK then. Cheers Jon
On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter <jonathanh@nvidia.com> wrote: > > On 20/09/16 19:17, Paul Kocialkowski wrote: >> * PGP Signed by an unknown key >> >> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : >>> On 18/09/16 15:13, Paul Kocialkowski wrote: >>>> >>>> This enables the GPU node for tegra124 nyan boards, which is required to >>>> get graphics acceleration with nouveau on these devices. >>>> >>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr> >>>> --- >>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> index dab9509..225ca77 100644 >>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>> @@ -42,6 +42,12 @@ >>>> }; >>>> }; >>>> >>>> + gpu@0,57000000 { >>>> + status = "okay"; >>>> + >>>> + vdd-supply = <&vdd_gpu>; >>>> + }; >>>> + >>>> serial@70006000 { >>>> /* Debug connector on the bottom of the board near SD card. >>>> */ >>>> status = "okay"; >>>> @@ -214,7 +220,7 @@ >>>> regulator-always-on; >>>> }; >>>> >>>> - sd6 { >>>> + vdd_gpu: sd6 { >>>> regulator-name = "+VDD_GPU_AP"; >>>> regulator-min-microvolt = <650000>; >>>> regulator-max-microvolt = >>>> <1200000>; >>>> >>> >>> Looks good to me. I see the following error when booting but looking at the >>> code appears to be benign. Thierry, Alex, is this normal/okay? >> >> I have the same messages and asked Alexandre about them the other day. He told >> me that it looks normal. > > Ok great. Hopefully, Alex can ACK then. Apologies for the (very) delayed reply. Yes, the messages you are seeing are part of the normal probe sequence on Tegra. So this looks good to me. Acked-by: Alexandre Courbot <acourbot@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thierry, On 07/11/16 12:51, Alexandre Courbot wrote: > On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter <jonathanh@nvidia.com> wrote: >> >> On 20/09/16 19:17, Paul Kocialkowski wrote: >>> * PGP Signed by an unknown key >>> >>> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit : >>>> On 18/09/16 15:13, Paul Kocialkowski wrote: >>>>> >>>>> This enables the GPU node for tegra124 nyan boards, which is required to >>>>> get graphics acceleration with nouveau on these devices. >>>>> >>>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr> >>>>> --- >>>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> index dab9509..225ca77 100644 >>>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >>>>> @@ -42,6 +42,12 @@ >>>>> }; >>>>> }; >>>>> >>>>> + gpu@0,57000000 { >>>>> + status = "okay"; >>>>> + >>>>> + vdd-supply = <&vdd_gpu>; >>>>> + }; >>>>> + >>>>> serial@70006000 { >>>>> /* Debug connector on the bottom of the board near SD card. >>>>> */ >>>>> status = "okay"; >>>>> @@ -214,7 +220,7 @@ >>>>> regulator-always-on; >>>>> }; >>>>> >>>>> - sd6 { >>>>> + vdd_gpu: sd6 { >>>>> regulator-name = "+VDD_GPU_AP"; >>>>> regulator-min-microvolt = <650000>; >>>>> regulator-max-microvolt = >>>>> <1200000>; >>>>> >>>> >>>> Looks good to me. I see the following error when booting but looking at the >>>> code appears to be benign. Thierry, Alex, is this normal/okay? >>> >>> I have the same messages and asked Alexandre about them the other day. He told >>> me that it looks normal. >> >> Ok great. Hopefully, Alex can ACK then. > > Apologies for the (very) delayed reply. > > Yes, the messages you are seeing are part of the normal probe sequence > on Tegra. So this looks good to me. > > Acked-by: Alexandre Courbot <acourbot@nvidia.com> Can you pick this one up for v4.10 as well? Cheers Jon
On Sun, Sep 18, 2016 at 04:13:11PM +0200, Paul Kocialkowski wrote: > This enables the GPU node for tegra124 nyan boards, which is required to > get graphics acceleration with nouveau on these devices. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Applied, thanks. Thierry
diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi index dab9509..225ca77 100644 --- a/arch/arm/boot/dts/tegra124-nyan.dtsi +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi @@ -42,6 +42,12 @@ }; }; + gpu@0,57000000 { + status = "okay"; + + vdd-supply = <&vdd_gpu>; + }; + serial@70006000 { /* Debug connector on the bottom of the board near SD card. */ status = "okay"; @@ -214,7 +220,7 @@ regulator-always-on; }; - sd6 { + vdd_gpu: sd6 { regulator-name = "+VDD_GPU_AP"; regulator-min-microvolt = <650000>; regulator-max-microvolt = <1200000>;
This enables the GPU node for tegra124 nyan boards, which is required to get graphics acceleration with nouveau on these devices. Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)