| Message ID | 1280849651.25461.10386.camel@emiko |
|---|---|
| State | Accepted |
| Delegated to: | Leann Ogasawara |
| Headers | show |
2010-08-03 17:34, Leann Ogasawara skrev: > On Tue, 2010-08-03 at 09:50 +0200, David Henningsson wrote: >> I would like us to cherry-pick commit b08b1637ce from >> git.kernel.org/linux/kernel/git/tiwai/sound-2.6.git, put it into >> Maverick, test it there for a month or two and assuming no regressions, >> I'll submit it to stable@kernel.org and it'll reach Lucid that way. It's >> in Takashi's tree, so it will be in 2.6.36. >> >> If applied, it will fix playback on several Dell Optiplex machines and >> some others. There is a theoretical risc for regressions for people >> having ALC268 chips with broken BIOSes, but I believe it is very small, >> but still that's why I would like some testing in Maverick first. >> >> (If the patch does not apply cleanly, apply 5d4abf93 first.) > > Hi David, > > Is there a bug in Launchpad open to track this issue? At least #582199, #586418 and #588031, I'm currently going through other similar bugs to see if it solves those as well. (A few people have complained it does not give auto-mute, but having checked that with upstream, that's intended behavior.) > ie. is there > confirmation that this indeed resolves the issue? Yes. > Care to also add your > SOB (signed-off-by) to this for Maverick? Sure, is the below correct procedure? > Also, I'm just inlining the > patch in question below for ease of review: > >>From b08b1637ce1c0196970348bcabf40f04b6b3d58e Mon Sep 17 00:00:00 2001 > From: Takashi Iwai <tiwai@suse.de> > Date: Fri, 30 Jul 2010 14:08:25 +0200 > Subject: [PATCH] ALSA: hda - Handle pin NID 0x1a on ALC259/269 > > The pin NID 0x1a should be handled as well as NID 0x1b. > Also added comments. > > Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: David Henningsson <david.henningsson@canonical.com> > --- > sound/pci/hda/patch_realtek.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 4d3a6f0..ce6c3a9 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -13158,7 +13158,8 @@ static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid, > dac = 0x02; > break; > case 0x15: > - case 0x1b: > + case 0x1a: /* ALC259/269 only */ > + case 0x1b: /* ALC259/269 only */ > case 0x21: /* ALC269vb has this pin, too */ > dac = 0x03; > break;
Applied to Maverick linux master as two separate cherry-picks (b08b1637 and 5d4abf93) from sound-2.6.git. Thanks, Leann On Tue, 2010-08-03 at 19:38 +0200, David Henningsson wrote: > 2010-08-03 17:34, Leann Ogasawara skrev: > > On Tue, 2010-08-03 at 09:50 +0200, David Henningsson wrote: > >> I would like us to cherry-pick commit b08b1637ce from > >> git.kernel.org/linux/kernel/git/tiwai/sound-2.6.git, put it into > >> Maverick, test it there for a month or two and assuming no regressions, > >> I'll submit it to stable@kernel.org and it'll reach Lucid that way. It's > >> in Takashi's tree, so it will be in 2.6.36. > >> > >> If applied, it will fix playback on several Dell Optiplex machines and > >> some others. There is a theoretical risc for regressions for people > >> having ALC268 chips with broken BIOSes, but I believe it is very small, > >> but still that's why I would like some testing in Maverick first. > >> > >> (If the patch does not apply cleanly, apply 5d4abf93 first.) > > > > Hi David, > > > > Is there a bug in Launchpad open to track this issue? > > At least #582199, #586418 and #588031, I'm currently going through other > similar bugs to see if it solves those as well. (A few people have > complained it does not give auto-mute, but having checked that with > upstream, that's intended behavior.) > > > ie. is there > > confirmation that this indeed resolves the issue? > > Yes. > > > Care to also add your > > SOB (signed-off-by) to this for Maverick? > > Sure, is the below correct procedure? > > > Also, I'm just inlining the > > patch in question below for ease of review: > > > >>From b08b1637ce1c0196970348bcabf40f04b6b3d58e Mon Sep 17 00:00:00 2001 > > From: Takashi Iwai <tiwai@suse.de> > > Date: Fri, 30 Jul 2010 14:08:25 +0200 > > Subject: [PATCH] ALSA: hda - Handle pin NID 0x1a on ALC259/269 > > > > The pin NID 0x1a should be handled as well as NID 0x1b. > > Also added comments. > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > Signed-off-by: David Henningsson <david.henningsson@canonical.com> > > --- > > sound/pci/hda/patch_realtek.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 4d3a6f0..ce6c3a9 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -13158,7 +13158,8 @@ static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid, > > dac = 0x02; > > break; > > case 0x15: > > - case 0x1b: > > + case 0x1a: /* ALC259/269 only */ > > + case 0x1b: /* ALC259/269 only */ > > case 0x21: /* ALC269vb has this pin, too */ > > dac = 0x03; > > break; > >
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4d3a6f0..ce6c3a9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -13158,7 +13158,8 @@ static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid, dac = 0x02; break; case 0x15: - case 0x1b: + case 0x1a: /* ALC259/269 only */ + case 0x1b: /* ALC259/269 only */ case 0x21: /* ALC269vb has this pin, too */ dac = 0x03; break;