diff mbox

[01/10] stick django version to 1.8

Message ID 1471943023-1112-2-git-send-email-wengpingbo@gmail.com
State Superseded
Headers show

Commit Message

WEN Pingbo Aug. 23, 2016, 9:03 a.m. UTC
Avoiding below error:
django.db.utils.ProgrammingError: relation "patchwork_state" does not exist
LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork...

Signed-off-by: WEN Pingbo <wengpingbo@gmail.com>
---
 requirements-dev.txt  | 2 +-
 requirements-prod.txt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Axtens Aug. 28, 2016, 5:06 a.m. UTC | #1
Hi,

WEN Pingbo <wengpingbo@gmail.com> writes:

> Avoiding below error:
> django.db.utils.ProgrammingError: relation "patchwork_state" does not exist
> LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork...

Interesting. Stephen merged my patch
https://github.com/getpatchwork/patchwork/commit/231966452f22dd344eabdd4f0722ce5463d1469a
which should also solve this problem.

Could you rebase on top of master and see if this patch is still needed?

Regards,
Daniel

>
> Signed-off-by: WEN Pingbo <wengpingbo@gmail.com>
> ---
>  requirements-dev.txt  | 2 +-
>  requirements-prod.txt | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/requirements-dev.txt b/requirements-dev.txt
> index d44ebc6..5c5f9eb 100644
> --- a/requirements-dev.txt
> +++ b/requirements-dev.txt
> @@ -1,2 +1,2 @@
> -Django>=1.8,<1.10
> +Django>=1.8,<1.9
>  -r requirements-test.txt
> diff --git a/requirements-prod.txt b/requirements-prod.txt
> index 2c88c7d..9662dad 100644
> --- a/requirements-prod.txt
> +++ b/requirements-prod.txt
> @@ -1,2 +1,2 @@
> -Django>=1.8,<1.10
> +Django>=1.8,<1.9
>  psycopg2==2.6.1
> -- 
> 1.9.1
>
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
Stephen Finucane Aug. 29, 2016, 10:31 p.m. UTC | #2
On 28 Aug 15:06, Daniel Axtens wrote:
> Hi,
> 
> WEN Pingbo <wengpingbo@gmail.com> writes:
> 
> > Avoiding below error:
> > django.db.utils.ProgrammingError: relation "patchwork_state" does not exist
> > LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork...
> 
> Interesting. Stephen merged my patch
> https://github.com/getpatchwork/patchwork/commit/231966452f22dd344eabdd4f0722ce5463d1469a
> which should also solve this problem.
>
> Could you rebase on top of master and see if this patch is still needed?

Yes, this should be resolved in master.

Stephen
WEN Pingbo Sept. 2, 2016, 12:40 p.m. UTC | #3
> 在 2016年8月28日,13:06,Daniel Axtens <dja@axtens.net> 写道:
> 
> Hi,
> 
> WEN Pingbo <wengpingbo@gmail.com> writes:
> 
>> Avoiding below error:
>> django.db.utils.ProgrammingError: relation "patchwork_state" does not exist
>> LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork...
> 
> Interesting. Stephen merged my patch
> https://github.com/getpatchwork/patchwork/commit/231966452f22dd344eabdd4f0722ce5463d1469a
> which should also solve this problem.
> 
> Could you rebase on top of master and see if this patch is still needed?
> 

It seems my work tree is out-of-date. I have try the latest master branch, the patchwork can work with django 1.9.9.

Thanks for your link:)
Pingbo
Thomas Monjalon Sept. 6, 2016, 10:21 a.m. UTC | #4
Hi,

2016-08-28 15:06, Daniel Axtens:
> Hi,
> 
> WEN Pingbo <wengpingbo@gmail.com> writes:
> 
> > Avoiding below error:
> > django.db.utils.ProgrammingError: relation "patchwork_state" does not exist
> > LINE 1: ...dering", "patchwork_state"."action_required" FROM "patchwork...
> 
> Interesting. Stephen merged my patch
> https://github.com/getpatchwork/patchwork/commit/231966452f22dd344eabdd4f0722ce5463d1469a
> which should also solve this problem.
> 
> Could you rebase on top of master and see if this patch is still needed?
> 
> Regards,
> Daniel
> 
> >
> > Signed-off-by: WEN Pingbo <wengpingbo@gmail.com>
[...]
> > --- a/requirements-prod.txt
> > +++ b/requirements-prod.txt
> > @@ -1,2 +1,2 @@
> > -Django>=1.8,<1.10
> > +Django>=1.8,<1.9

Unfortunately, the requirement <1.9 does not download Django 1.8
but a release candidate of the version 1.9.
Is it the expected behaviour?
Daniel Axtens Sept. 7, 2016, 12:42 a.m. UTC | #5
Hi,

>> > --- a/requirements-prod.txt
>> > +++ b/requirements-prod.txt
>> > @@ -1,2 +1,2 @@
>> > -Django>=1.8,<1.10
>> > +Django>=1.8,<1.9
>
> Unfortunately, the requirement <1.9 does not download Django 1.8
> but a release candidate of the version 1.9.
> Is it the expected behaviour?

That's weird - no, I wouldn't expect that. I can try to find a work
around for that if it would be helpful. 

To be honest I would have thought production deployments would use
distro packages rather than pip - have you considered that route?

Regards,
Daniel
Thomas Monjalon Sept. 7, 2016, 7:22 a.m. UTC | #6
2016-09-07 10:42, Daniel Axtens:
> >> > --- a/requirements-prod.txt
> >> > +++ b/requirements-prod.txt
> >> > @@ -1,2 +1,2 @@
> >> > -Django>=1.8,<1.10
> >> > +Django>=1.8,<1.9
> >
> > Unfortunately, the requirement <1.9 does not download Django 1.8
> > but a release candidate of the version 1.9.
> > Is it the expected behaviour?
> 
> That's weird - no, I wouldn't expect that. I can try to find a work
> around for that if it would be helpful. 
> 
> To be honest I would have thought production deployments would use
> distro packages rather than pip - have you considered that route?

There are 2 issues with distro packages in my case:
- they are too old
- I use virtualenv to have a packaging separation between apps
Daniel Axtens Sept. 7, 2016, 7:57 a.m. UTC | #7
Thomas Monjalon <thomas.monjalon@6wind.com> writes:

> 2016-09-07 10:42, Daniel Axtens:
>> >> > --- a/requirements-prod.txt
>> >> > +++ b/requirements-prod.txt
>> >> > @@ -1,2 +1,2 @@
>> >> > -Django>=1.8,<1.10
>> >> > +Django>=1.8,<1.9
>> >
>> > Unfortunately, the requirement <1.9 does not download Django 1.8
>> > but a release candidate of the version 1.9.
>> > Is it the expected behaviour?
>> 
>> That's weird - no, I wouldn't expect that. I can try to find a work
>> around for that if it would be helpful. 
>> 
>> To be honest I would have thought production deployments would use
>> distro packages rather than pip - have you considered that route?
>
> There are 2 issues with distro packages in my case:
> - they are too old
> - I use virtualenv to have a packaging separation between apps

Fair enough. I'm happy to figure out a patch or for you to do so.

Regards,
Daniel
diff mbox

Patch

diff --git a/requirements-dev.txt b/requirements-dev.txt
index d44ebc6..5c5f9eb 100644
--- a/requirements-dev.txt
+++ b/requirements-dev.txt
@@ -1,2 +1,2 @@ 
-Django>=1.8,<1.10
+Django>=1.8,<1.9
 -r requirements-test.txt
diff --git a/requirements-prod.txt b/requirements-prod.txt
index 2c88c7d..9662dad 100644
--- a/requirements-prod.txt
+++ b/requirements-prod.txt
@@ -1,2 +1,2 @@ 
-Django>=1.8,<1.10
+Django>=1.8,<1.9
 psycopg2==2.6.1