Message ID | 20100802205121.GA16520@merkur.ravnborg.org (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Sam Ravnborg <sam@ravnborg.org> writes:
> +bootwrapper_install
Missing colon.
Andreas.
02.08.2010 23:51, Sam Ravnborg skrev: >> >> Thanks, this seems to fix the first issue, but then I get the same erro on the following line 190: >> >> 190: bootwrapper_install %.dtb: >> 191: $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) >> > > Obviously - dunno how I missed that. > Updated patch below. > > I will do a proper submission after you > confirm that powerpc build is working with make 3.82. > Yeah, that was an obvious fix, thanks! One small typo fix below... (a missing ':') Otherwise it works here, so: Tested-by: Thomas Backlund <tmb@mandriva.org> > Sam > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > index 77cfe7a..ace7a3e 100644 > --- a/arch/powerpc/Makefile > +++ b/arch/powerpc/Makefile > @@ -163,9 +163,11 @@ drivers-$(CONFIG_OPROFILE) += arch/powerpc/oprofile/ > # Default to zImage, override when needed > all: zImage > > -BOOT_TARGETS = zImage zImage.initrd uImage zImage% dtbImage% treeImage.% cuImage.% simpleImage.% > +# With make 3.82 we cannot mix normal and wildcard targets > +BOOT_TARGETS1 := zImage zImage.initrd uImaged > +BOOT_TARGETS2 := zImage% dtbImage% treeImage.% cuImage.% simpleImage.% > > -PHONY += $(BOOT_TARGETS) > +PHONY += $(BOOT_TARGETS1) $(BOOT_TARGETS2) > > boot := arch/$(ARCH)/boot > > @@ -180,10 +182,16 @@ relocs_check: arch/powerpc/relocs_check.pl vmlinux > zImage: relocs_check > endif > > -$(BOOT_TARGETS): vmlinux > +$(BOOT_TARGETS1): vmlinux > + $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) > +$(BOOT_TARGETS2): vmlinux > + $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) > + > + > +bootwrapper_install bootwrapper_install: > $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) > > -bootwrapper_install %.dtb: > +%.dtb: > $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) > > define archhelp > . > -- Thomas
On Tue, Aug 03, 2010 at 12:03:35AM +0300, Thomas Backlund wrote: > 02.08.2010 23:51, Sam Ravnborg skrev: > >> > >> Thanks, this seems to fix the first issue, but then I get the same erro on the following line 190: > >> > >> 190: bootwrapper_install %.dtb: > >> 191: $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) > >> > > > > Obviously - dunno how I missed that. > > Updated patch below. > > > > I will do a proper submission after you > > confirm that powerpc build is working with make 3.82. > > > > Yeah, that was an obvious fix, thanks! > > One small typo fix below... > (a missing ':') > > Otherwise it works here, so: > > Tested-by: Thomas Backlund <tmb@mandriva.org> Thanks. I have sent a proper patch to Ben/Paul (powerpc maintainers). Sam
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 77cfe7a..ace7a3e 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -163,9 +163,11 @@ drivers-$(CONFIG_OPROFILE) += arch/powerpc/oprofile/ # Default to zImage, override when needed all: zImage -BOOT_TARGETS = zImage zImage.initrd uImage zImage% dtbImage% treeImage.% cuImage.% simpleImage.% +# With make 3.82 we cannot mix normal and wildcard targets +BOOT_TARGETS1 := zImage zImage.initrd uImaged +BOOT_TARGETS2 := zImage% dtbImage% treeImage.% cuImage.% simpleImage.% -PHONY += $(BOOT_TARGETS) +PHONY += $(BOOT_TARGETS1) $(BOOT_TARGETS2) boot := arch/$(ARCH)/boot @@ -180,10 +182,16 @@ relocs_check: arch/powerpc/relocs_check.pl vmlinux zImage: relocs_check endif -$(BOOT_TARGETS): vmlinux +$(BOOT_TARGETS1): vmlinux + $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) +$(BOOT_TARGETS2): vmlinux + $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) + + +bootwrapper_install $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) -bootwrapper_install %.dtb: +%.dtb: $(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@) define archhelp