| Message ID | 20100713134609.GA14514@hmsreliant.think-freely.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 67238fb721639046b5d76488317522af4ece9d61 |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote: > Hey all- > About 2 years ago now, I sent this patch upstream to allow makedumpfile > to properly filter cores on ppc64: > http://www.mail-archive.com/kexec@lists.infradead.org/msg02426.html > It got acks from the kexec folks so I pulled it into RHEL, but I never checked > back here to make sure it ever made it in, which apparently it didn't. It still > needs to be included, so I'm reposting it here, making sure to copy all the ppc > folks this time. I've retested it on the latest linus kernel and it works fine, > allowing makedumpfile to find all the symbols it needs to properly strip a > vmcore on ppc64. > > Neil > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > Ping, anyone want to chime in on this, its needed for dump filtering to work properly on ppc64 Neil > > machine_kexec.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c > index bb3d893..0df7031 100644 > --- a/arch/powerpc/kernel/machine_kexec.c > +++ b/arch/powerpc/kernel/machine_kexec.c > @@ -45,6 +45,18 @@ void machine_kexec_cleanup(struct kimage *image) > ppc_md.machine_kexec_cleanup(image); > } > > +void arch_crash_save_vmcoreinfo(void) > +{ > + > +#ifdef CONFIG_NEED_MULTIPLE_NODES > + VMCOREINFO_SYMBOL(node_data); > + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES); > +#endif > +#ifndef CONFIG_NEED_MULTIPLE_NODES > + VMCOREINFO_SYMBOL(contig_page_data); > +#endif > +} > + > /* > * Do not allocate memory (or fail in any way) in machine_kexec(). > * We are past the point of no return, committed to rebooting now. > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec >
On Mon, Jul 26, 2010 at 11:23 PM, Neil Horman <nhorman@tuxdriver.com> wrote: > On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote: >> Hey all- >> About 2 years ago now, I sent this patch upstream to allow makedumpfile >> to properly filter cores on ppc64: >> http://www.mail-archive.com/kexec@lists.infradead.org/msg02426.html >> It got acks from the kexec folks so I pulled it into RHEL, but I never checked >> back here to make sure it ever made it in, which apparently it didn't. It still >> needs to be included, so I'm reposting it here, making sure to copy all the ppc >> folks this time. I've retested it on the latest linus kernel and it works fine, >> allowing makedumpfile to find all the symbols it needs to properly strip a >> vmcore on ppc64. >> >> Neil >> >> Signed-off-by: Neil Horman <nhorman@tuxdriver.com> >> > Ping, anyone want to chime in on this, its needed for dump filtering to work > properly on ppc64 This patch looks good for me. Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com> Thanks!
On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote: > Hey all- > About 2 years ago now, I sent this patch upstream to allow makedumpfile > to properly filter cores on ppc64: > http://www.mail-archive.com/kexec@lists.infradead.org/msg02426.html > It got acks from the kexec folks so I pulled it into RHEL, but I never checked > back here to make sure it ever made it in, which apparently it didn't. It still > needs to be included, so I'm reposting it here, making sure to copy all the ppc > folks this time. I've retested it on the latest linus kernel and it works fine, > allowing makedumpfile to find all the symbols it needs to properly strip a > vmcore on ppc64. > > Neil > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > > > machine_kexec.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c > index bb3d893..0df7031 100644 > --- a/arch/powerpc/kernel/machine_kexec.c > +++ b/arch/powerpc/kernel/machine_kexec.c > @@ -45,6 +45,18 @@ void machine_kexec_cleanup(struct kimage *image) > ppc_md.machine_kexec_cleanup(image); > } > > +void arch_crash_save_vmcoreinfo(void) > +{ > + > +#ifdef CONFIG_NEED_MULTIPLE_NODES > + VMCOREINFO_SYMBOL(node_data); > + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES); > +#endif > +#ifndef CONFIG_NEED_MULTIPLE_NODES > + VMCOREINFO_SYMBOL(contig_page_data); > +#endif > +} > + > /* > * Do not allocate memory (or fail in any way) in machine_kexec(). > * We are past the point of no return, committed to rebooting now. > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec > Ping yet again. Ben, This needs review/acceptance from you or Paul Neil
On Wed, 2010-08-04 at 10:49 -0400, Neil Horman wrote: > Ping yet again. Ben, This needs review/acceptance from you or Paul > Neil Isn't it already in powerpc-next about to be pulled by Linus ? In general, I recommend you check the status of your patches on patchwork. I'm nagging Jeremy to add a feature so it emails the submitter when the patch status changes :-) Cheers, Ben.
On Thu, Aug 05, 2010 at 12:04:26PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2010-08-04 at 10:49 -0400, Neil Horman wrote: > > Ping yet again. Ben, This needs review/acceptance from you or Paul > > Neil > > Isn't it already in powerpc-next about to be pulled by Linus ? > Yes, there it is. Apologies. For whatever reason, I was looking on the main branch of your tree. It didn't occur to me to check your next branch. Sorry. > In general, I recommend you check the status of your patches on > patchwork. I'm nagging Jeremy to add a feature so it emails the > submitter when the patch status changes :-) > Noted, I'll remember that. Email from patchwork would be a nice feature. +1 from me. Thanks & Regards Neil > Cheers, > Ben. > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec
diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c index bb3d893..0df7031 100644 --- a/arch/powerpc/kernel/machine_kexec.c +++ b/arch/powerpc/kernel/machine_kexec.c @@ -45,6 +45,18 @@ void machine_kexec_cleanup(struct kimage *image) ppc_md.machine_kexec_cleanup(image); } +void arch_crash_save_vmcoreinfo(void) +{ + +#ifdef CONFIG_NEED_MULTIPLE_NODES + VMCOREINFO_SYMBOL(node_data); + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES); +#endif +#ifndef CONFIG_NEED_MULTIPLE_NODES + VMCOREINFO_SYMBOL(contig_page_data); +#endif +} + /* * Do not allocate memory (or fail in any way) in machine_kexec(). * We are past the point of no return, committed to rebooting now.
Hey all- About 2 years ago now, I sent this patch upstream to allow makedumpfile to properly filter cores on ppc64: http://www.mail-archive.com/kexec@lists.infradead.org/msg02426.html It got acks from the kexec folks so I pulled it into RHEL, but I never checked back here to make sure it ever made it in, which apparently it didn't. It still needs to be included, so I'm reposting it here, making sure to copy all the ppc folks this time. I've retested it on the latest linus kernel and it works fine, allowing makedumpfile to find all the symbols it needs to properly strip a vmcore on ppc64. Neil Signed-off-by: Neil Horman <nhorman@tuxdriver.com> machine_kexec.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)