diff mbox

[v1,8/8] target-ppc: add extswsli[.] instruction

Message ID 1469688581-30853-9-git-send-email-nikunj@linux.vnet.ibm.com
State New
Headers show

Commit Message

Nikunj A Dadhania July 28, 2016, 6:49 a.m. UTC 
extswsli : Extend Sign Word & Shift Left Immediate

Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
 target-ppc/translate.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Richard Henderson July 28, 2016, 1:04 p.m. UTC | #1 
On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
> +    tcg_gen_ext32s_tl(dst, src);
> +    if (sh != 0) {
> +        tcg_gen_shli_tl(dst, dst, sh);
> +    }

You need not test for sh != 0, since that will be done in tcg_gen_shli_tl. 
Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~
Nikunj A Dadhania July 28, 2016, 5:33 p.m. UTC | #2 
Richard Henderson <rth@twiddle.net> writes:

> On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
>> +    tcg_gen_ext32s_tl(dst, src);
>> +    if (sh != 0) {
>> +        tcg_gen_shli_tl(dst, dst, sh);
>> +    }
>
> You need not test for sh != 0, since that will be done in
> tcg_gen_shli_tl.

Sure, will updated.

> Otherwise,
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
>
>
> r~
diff mbox

Patch

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 82349ed..8d25121 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -2328,6 +2328,32 @@  static void gen_sradi1(DisasContext *ctx)
     gen_sradi(ctx, 1);
 }
 
+/* extswsli & extswsli. */
+static inline void gen_extswsli(DisasContext *ctx, int n)
+{
+    int sh = SH(ctx->opcode) + (n << 5);
+    TCGv dst = cpu_gpr[rA(ctx->opcode)];
+    TCGv src = cpu_gpr[rS(ctx->opcode)];
+
+    tcg_gen_ext32s_tl(dst, src);
+    if (sh != 0) {
+        tcg_gen_shli_tl(dst, dst, sh);
+    }
+    if (unlikely(Rc(ctx->opcode) != 0)) {
+        gen_set_Rc0(ctx, dst);
+    }
+}
+
+static void gen_extswsli0(DisasContext *ctx)
+{
+    gen_extswsli(ctx, 0);
+}
+
+static void gen_extswsli1(DisasContext *ctx)
+{
+    gen_extswsli(ctx, 1);
+}
+
 /* srd & srd. */
 static void gen_srd(DisasContext *ctx)
 {
@@ -6227,6 +6253,10 @@  GEN_HANDLER(srad, 0x1F, 0x1A, 0x18, 0x00000000, PPC_64B),
 GEN_HANDLER2(sradi0, "sradi", 0x1F, 0x1A, 0x19, 0x00000000, PPC_64B),
 GEN_HANDLER2(sradi1, "sradi", 0x1F, 0x1B, 0x19, 0x00000000, PPC_64B),
 GEN_HANDLER(srd, 0x1F, 0x1B, 0x10, 0x00000000, PPC_64B),
+GEN_HANDLER2_E(extswsli0, "extswsli", 0x1F, 0x1A, 0x1B, 0x00000000,
+               PPC_NONE, PPC2_ISA300),
+GEN_HANDLER2_E(extswsli1, "extswsli", 0x1F, 0x1B, 0x1B, 0x00000000,
+               PPC_NONE, PPC2_ISA300),
 #endif
 #if defined(TARGET_PPC64)
 GEN_HANDLER(ld, 0x3A, 0xFF, 0xFF, 0x00000000, PPC_64B),