| Message ID | 1469180045-26155-1-git-send-email-kever.yang@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Kever, On 22 July 2016 at 03:34, Kever Yang <kever.yang@rock-chips.com> wrote: For the commit message, you have "rk3399: reseve space for trust". I think it should be "rk3399: Reseve space for ARM Trusted Firmware" or perhaps ATF > rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage. needs beginning s/usage/use/ > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c > index dffacd0..37d3851 100644 > --- a/board/rockchip/evb_rk3399/evb-rk3399.c > +++ b/board/rockchip/evb_rk3399/evb-rk3399.c > @@ -21,6 +21,7 @@ int dram_init(void) > > void dram_init_banksize(void) > { > - gd->bd->bi_dram[0].start = 0; > + /* Reserve 0x200000 for trust word */ What does 'trust word' mean? Do you mean space for ATF, or a single word of memory? > + gd->bd->bi_dram[0].start = 0x200000; > gd->bd->bi_dram[0].size = 0x80000000; > } > -- > 1.9.1 > > Regards, Simon
Hi again, On 22 July 2016 at 20:57, Simon Glass <sjg@chromium.org> wrote: > Hi Kever, > > On 22 July 2016 at 03:34, Kever Yang <kever.yang@rock-chips.com> wrote: > > For the commit message, you have "rk3399: reseve space for trust". > > I think it should be "rk3399: Reseve space for ARM Trusted Firmware" > or perhaps ATF Ooops I mean 'Reserve' ! > > >> rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage. > > needs > beginning > s/usage/use/ > >> >> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >> --- >> >> board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c >> index dffacd0..37d3851 100644 >> --- a/board/rockchip/evb_rk3399/evb-rk3399.c >> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c >> @@ -21,6 +21,7 @@ int dram_init(void) >> >> void dram_init_banksize(void) >> { >> - gd->bd->bi_dram[0].start = 0; >> + /* Reserve 0x200000 for trust word */ > > What does 'trust word' mean? Do you mean space for ATF, or a single > word of memory? > >> + gd->bd->bi_dram[0].start = 0x200000; >> gd->bd->bi_dram[0].size = 0x80000000; >> } >> -- >> 1.9.1 >> >> > > Regards, > Simon Regards, Simon
Hi Simon, On 07/23/2016 11:03 AM, Simon Glass wrote: > Hi again, > > On 22 July 2016 at 20:57, Simon Glass <sjg@chromium.org> wrote: >> Hi Kever, >> >> On 22 July 2016 at 03:34, Kever Yang <kever.yang@rock-chips.com> wrote: >> >> For the commit message, you have "rk3399: reseve space for trust". >> >> I think it should be "rk3399: Reseve space for ARM Trusted Firmware" >> or perhaps ATF > Ooops I mean 'Reserve' ! I though the memory is used by ATF BL31 and BL32 which is not including in ATF, this reserve memory only use for ATF BL31 in fact, so I will send Version 2 with all you comments applied. Thanks, - Kever > >> >>> rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage. >> needs >> beginning >> s/usage/use/ >> >>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com> >>> --- >>> >>> board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c >>> index dffacd0..37d3851 100644 >>> --- a/board/rockchip/evb_rk3399/evb-rk3399.c >>> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c >>> @@ -21,6 +21,7 @@ int dram_init(void) >>> >>> void dram_init_banksize(void) >>> { >>> - gd->bd->bi_dram[0].start = 0; >>> + /* Reserve 0x200000 for trust word */ >> What does 'trust word' mean? Do you mean space for ATF, or a single >> word of memory? >> >>> + gd->bd->bi_dram[0].start = 0x200000; >>> gd->bd->bi_dram[0].size = 0x80000000; >>> } >>> -- >>> 1.9.1 >>> >>> >> Regards, >> Simon > > Regards, > Simon >
diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c index dffacd0..37d3851 100644 --- a/board/rockchip/evb_rk3399/evb-rk3399.c +++ b/board/rockchip/evb_rk3399/evb-rk3399.c @@ -21,6 +21,7 @@ int dram_init(void) void dram_init_banksize(void) { - gd->bd->bi_dram[0].start = 0; + /* Reserve 0x200000 for trust word */ + gd->bd->bi_dram[0].start = 0x200000; gd->bd->bi_dram[0].size = 0x80000000; }
rk3399 need reserve 0x200000 at the begining of DRAM, for ATF usage. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- board/rockchip/evb_rk3399/evb-rk3399.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)