Message ID | CA+yXCZDtVJM1APW5SB4rNaM1hgUc780G4D93M+h0Mr+dbHSRSA@mail.gmail.com |
---|---|
State | New |
Headers | show |
On Jul 5, 2016, at 1:39 AM, Kito Cheng <kito.cheng@gmail.com> wrote: > > pr69102.c use -fPIC flag in dg-options but not check is available for > target, so I add "dg-require-effective-target fpic" for it.' I happened to notice you didn't ask Ok?, and you didn't apply it or have it applied. I'd recommend one or the other. I'm assuming you meant to ask Ok? Ok. I've applied it: Committed revision 238023. for you. Thanks. > 2016-07-05 Kito Cheng <kito.cheng@gmail.com> > > * gcc.c-torture/compile/pr69102.c: Require fpic support.
Hi Mike: thanks for your review :) On Wed, Jul 6, 2016 at 2:54 AM, Mike Stump <mrs@mrs.kithrup.com> wrote: > On Jul 5, 2016, at 1:39 AM, Kito Cheng <kito.cheng@gmail.com> wrote: >> >> pr69102.c use -fPIC flag in dg-options but not check is available for >> target, so I add "dg-require-effective-target fpic" for it.' > > I happened to notice you didn't ask Ok?, and you didn't apply it or have it applied. I'd recommend one or the other. > > I'm assuming you meant to ask Ok? > > Ok. > > I've applied it: > > Committed revision 238023. > > for you. Thanks. > >> 2016-07-05 Kito Cheng <kito.cheng@gmail.com> >> >> * gcc.c-torture/compile/pr69102.c: Require fpic support. >
From caa51d92e620694ee1365ce0f77ac2b152662982 Mon Sep 17 00:00:00 2001 From: Kito Cheng <kito@andestech.com> Date: Tue, 5 Jul 2016 16:14:45 +0800 Subject: [PATCH] Check fpic for pr69102.c --- gcc/testsuite/gcc.c-torture/compile/pr69102.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.c-torture/compile/pr69102.c b/gcc/testsuite/gcc.c-torture/compile/pr69102.c index 1f0cdc6..5c8c541 100644 --- a/gcc/testsuite/gcc.c-torture/compile/pr69102.c +++ b/gcc/testsuite/gcc.c-torture/compile/pr69102.c @@ -1,5 +1,6 @@ /* { dg-options "-Og -fPIC -fschedule-insns2 -fselective-scheduling2 -fno-tree-fre --param=max-sched-extend-regions-iters=10" } */ /* { dg-require-effective-target scheduling } */ +/* { dg-require-effective-target fpic } */ void bar (unsigned int); void -- 1.9.1