| Message ID | 20100710155902.GA7402@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 10.07.2010 17:59, schrieb Shahar Havivi: > When there is no block driver associate with BlockDriverState bdrv_getlength > returns -ENOMEDIUM that cause block migration to fail > > v2: > fix sectors<0 to sectors<=0 Please put the changes between patch versions below the --- line so that git am ignores it. > > Signed-off-by: Shahar Havivi <shaharh@redhat.com> > --- > block-migration.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block-migration.c b/block-migration.c > index 7db6f02..a77106e 100644 > --- a/block-migration.c > +++ b/block-migration.c > @@ -238,7 +238,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs) > > if (!bdrv_is_read_only(bs)) { > sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS; > - if (sectors == 0) { > + if (sectors <= 0) { > return; > } > Dealing with -errno shifted by 9 looks really strange, but it should be correct (sectors being -1 for error cases in practice). Thanks, applied to the block branch. Kevin
diff --git a/block-migration.c b/block-migration.c index 7db6f02..a77106e 100644 --- a/block-migration.c +++ b/block-migration.c @@ -238,7 +238,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs) if (!bdrv_is_read_only(bs)) { sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS; - if (sectors == 0) { + if (sectors <= 0) { return; }
When there is no block driver associate with BlockDriverState bdrv_getlength returns -ENOMEDIUM that cause block migration to fail v2: fix sectors<0 to sectors<=0 Signed-off-by: Shahar Havivi <shaharh@redhat.com> --- block-migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)