| Message ID | 4C34A341.30609@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
> Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -----Original Message----- > From: Lee Jones [mailto:lee.jones@canonical.com] > Sent: Wednesday, July 07, 2010 5:55 PM > To: Dechesne, Nicolas > Cc: kernel-team > Subject: Re: [maverick][PATCH] UBUNTU: SAUCE: Load SysLink modules on > start-up on OMAP4 devices > > How about this Nicolas? Acked-by: Nicolas Dechesne <n-dechesne@ti.com> thanks > > This patch registers the SysLink driver-set as a platform device. > During the registration process a uevent will be fired, allowing > udev to pick it up and load the necessary loadable modules. > > Signed-off-by: Lee Jones <lee.jones@canonical.com> > --- > arch/arm/mach-omap2/omap4-common.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach- > omap2/omap4-common.c > index 91b5d36..dcc9f99 100644 > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -71,4 +71,23 @@ static int __init omap_l2_cache_init(void) > early_initcall(omap_l2_cache_init); > #endif > > +static struct platform_device omap4_syslink_device = { > + .name = "syslink_ipc", > + .id = -1, > + .num_resources = 0, > +}; > > +static int __init omap4_syslink_init(void) > +{ > + int retval; > + > + retval = platform_device_register(&omap4_syslink_device); > + > + if (retval != 0) > + pr_err("%s: Failed to register devices: %d\n", __func__, > retval); > + else > + pr_info("%s: Successfully registered devices\n", __func__); > + > + return retval; > +} > +device_initcall(omap4_syslink_init);
On 07/07/2010 10:19 AM, Dechesne, Nicolas wrote: >> > Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 > > -----Original Message----- > >> From: Lee Jones [mailto:lee.jones@canonical.com] >> Sent: Wednesday, July 07, 2010 5:55 PM >> To: Dechesne, Nicolas >> Cc: kernel-team >> Subject: Re: [maverick][PATCH] UBUNTU: SAUCE: Load SysLink modules on >> start-up on OMAP4 devices >> >> How about this Nicolas? > > Acked-by: Nicolas Dechesne<n-dechesne@ti.com> > > thanks > >> >> This patch registers the SysLink driver-set as a platform device. >> During the registration process a uevent will be fired, allowing >> udev to pick it up and load the necessary loadable modules. >> >> Signed-off-by: Lee Jones<lee.jones@canonical.com> >> --- >> arch/arm/mach-omap2/omap4-common.c | 19 +++++++++++++++++++ >> 1 files changed, 19 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach- >> omap2/omap4-common.c >> index 91b5d36..dcc9f99 100644 >> --- a/arch/arm/mach-omap2/omap4-common.c >> +++ b/arch/arm/mach-omap2/omap4-common.c >> @@ -71,4 +71,23 @@ static int __init omap_l2_cache_init(void) >> early_initcall(omap_l2_cache_init); >> #endif >> >> +static struct platform_device omap4_syslink_device = { >> + .name = "syslink_ipc", >> + .id = -1, >> + .num_resources = 0, >> +}; >> >> +static int __init omap4_syslink_init(void) >> +{ >> + int retval; >> + >> + retval = platform_device_register(&omap4_syslink_device); >> + >> + if (retval != 0) >> + pr_err("%s: Failed to register devices: %d\n", __func__, >> retval); >> + else >> + pr_info("%s: Successfully registered devices\n", __func__); >> + >> + return retval; >> +} >> +device_initcall(omap4_syslink_init); > > applied
>>> +device_initcall(omap4_syslink_init); > applied This line appears to be missing from our latest branch. Was this intentional?
On 07/09/2010 03:31 AM, Lee Jones wrote: >>>> +device_initcall(omap4_syslink_init); > >> applied > > This line appears to be missing from our latest branch. > > Was this intentional? No, not intentional. I think this was a straightforward cherry-pick from your repository. If its not correct, then send another patch that fixes the deficiency. rtg
On 07/09/2010 06:10 AM, Tim Gardner wrote: > On 07/09/2010 03:31 AM, Lee Jones wrote: >>>>> +device_initcall(omap4_syslink_init); >> >>> applied >> >> This line appears to be missing from our latest branch. >> >> Was this intentional? > > No, not intentional. I think this was a straightforward cherry-pick from > your repository. If its not correct, then send another patch that fixes > the deficiency. > > rtg OK, I've refetched, reapplied, and repushed. rtg
diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 91b5d36..dcc9f99 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -71,4 +71,23 @@ static int __init omap_l2_cache_init(void) early_initcall(omap_l2_cache_init); #endif +static struct platform_device omap4_syslink_device = { + .name = "syslink_ipc", + .id = -1, + .num_resources = 0, +}; +static int __init omap4_syslink_init(void) +{ + int retval; + + retval = platform_device_register(&omap4_syslink_device); + + if (retval != 0) + pr_err("%s: Failed to register devices: %d\n", __func__, retval); + else + pr_info("%s: Successfully registered devices\n", __func__); + + return retval; +} +device_initcall(omap4_syslink_init);
How about this Nicolas? This patch registers the SysLink driver-set as a platform device. During the registration process a uevent will be fired, allowing udev to pick it up and load the necessary loadable modules. Signed-off-by: Lee Jones <lee.jones@canonical.com> --- arch/arm/mach-omap2/omap4-common.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)