| Message ID | 1278522874.5906.9.camel@edumazet-laptop |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2010-07-07 at 19:14 +0200, Eric Dumazet wrote: > When we need to shape traffic with low speeds, we need to disable tso on > network interface : > > ethtool -K eth0.2240 tso off > > It seems vlan interfaces miss the set_tso() ethtool method. > Propagating tso changes from lower device is not always wanted, some > vlan want TSO on, other want TSO off. But it should not be possible to enable TSO if the underlying device doesn't support it. Ben. > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > --- > > diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c > index c6456cb..d827c2e 100644 > --- a/net/8021q/vlan_dev.c > +++ b/net/8021q/vlan_dev.c > @@ -844,6 +844,7 @@ static const struct ethtool_ops vlan_ethtool_ops = { > .get_link = ethtool_op_get_link, > .get_rx_csum = vlan_ethtool_get_rx_csum, > .get_flags = vlan_ethtool_get_flags, > + .set_tso = ethtool_op_set_tso, > }; > > static const struct net_device_ops vlan_netdev_ops = { >
Le mercredi 07 juillet 2010 à 18:25 +0100, Ben Hutchings a écrit : > On Wed, 2010-07-07 at 19:14 +0200, Eric Dumazet wrote: > > When we need to shape traffic with low speeds, we need to disable tso on > > network interface : > > > > ethtool -K eth0.2240 tso off > > > > It seems vlan interfaces miss the set_tso() ethtool method. > > Propagating tso changes from lower device is not always wanted, some > > vlan want TSO on, other want TSO off. > > But it should not be possible to enable TSO if the underlying device > doesn't support it. Yes indeed, I'll provide a more generic patch, thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index c6456cb..d827c2e 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -844,6 +844,7 @@ static const struct ethtool_ops vlan_ethtool_ops = { .get_link = ethtool_op_get_link, .get_rx_csum = vlan_ethtool_get_rx_csum, .get_flags = vlan_ethtool_get_flags, + .set_tso = ethtool_op_set_tso, }; static const struct net_device_ops vlan_netdev_ops = {
When we need to shape traffic with low speeds, we need to disable tso on network interface : ethtool -K eth0.2240 tso off It seems vlan interfaces miss the set_tso() ethtool method. Propagating tso changes from lower device is not always wanted, some vlan want TSO on, other want TSO off. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html