Message ID | 20100706232658.GA10654@bromo.med.uc.edu |
---|---|
State | New |
Headers | show |
On Tue, Jul 6, 2010 at 4:26 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote: > On Tue, Jul 06, 2010 at 08:28:48PM +0200, Kai Tietz wrote: >> 2010/7/6 Uros Bizjak <ubizjak@gmail.com>: >> > Hello! >> > >> >> Better, but honestly I'd been thinking just to bring one >> >> directive per line, rather than trying to block the output >> >> onto several lines. I.e. >> >> >> >> for (i = 0; i < filler_count; i += 4) >> >> fprintf (asm_out_file, ASM_LONG " 0x%x\n", filler_cc); >> >> >> >> >> >> Ok with that change. >> > >> > Please also use %#x instead of 0x%x. >> > >> > Thanks, >> > Uros. >> > >> >> >> Ok, changed it to a simple loop without formatting and I use %#x. >> Committed at revision 161875 & 161876 >> >> Thanks, >> Kai > > This patch breaks the bootstrap on i386-apple-darwin* and > x86_64-apple-darwin* since gcc/config/darwin.h defines > ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL). Simply changing... > This may also cause: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44850
Index: gcc/config/darwin.h =================================================================== --- gcc/config/darwin.h (revision 161889) +++ gcc/config/darwin.h (working copy) @@ -635,7 +635,8 @@ assemble_zeros (1); \ } while (0) -#define ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL) \ +#undef SUBTARGET_ASM_DECLARE_FUNCTION_NAME +#define SUBTARGET_ASM_DECLARE_FUNCTION_NAME(FILE, NAME, DECL) \ do { \ const char *xname = NAME; \ if (GET_CODE (XEXP (DECL_RTL (DECL), 0)) != SYMBOL_REF) \ @@ -649,7 +650,6 @@ && (!DECL_COMMON (DECL) || !TREE_PUBLIC (DECL))) \ || DECL_INITIAL (DECL)) \ (* targetm.encode_section_info) (DECL, DECL_RTL (DECL), false); \ - ASM_OUTPUT_LABEL (FILE, xname); \ } while (0) #undef TARGET_ASM_DECLARE_CONSTANT_NAME