| Message ID | 20100629163857.0dcc1245@dhcp-lab-109.englab.brq.redhat.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Jun 29, 2010 at 07:38, Stanislaw Gruszka <sgruszka@redhat.com> wrote: > Both ETH_FLAG_LRO and NETIF_F_LRO have the same value, but NETIF_F_LRO > is intended to use with netdev->features. > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> > --- > drivers/net/ixgbe/ixgbe_ethtool.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c > index 873b45e..e2ab4ae 100644 > --- a/drivers/net/ixgbe/ixgbe_ethtool.c > +++ b/drivers/net/ixgbe/ixgbe_ethtool.c > @@ -2227,7 +2227,7 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data) > break; > } > } else if (!adapter->rx_itr_setting) { > - netdev->features &= ~ETH_FLAG_LRO; > + netdev->features &= ~NETIF_F_LRO; > if (data & ETH_FLAG_LRO) > e_info("rx-usecs set to 0, " > "LRO/RSC cannot be enabled.\n"); > -- Thanks, I have added it to my queue of patches.
diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c index 873b45e..e2ab4ae 100644 --- a/drivers/net/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ixgbe/ixgbe_ethtool.c @@ -2227,7 +2227,7 @@ static int ixgbe_set_flags(struct net_device *netdev, u32 data) break; } } else if (!adapter->rx_itr_setting) { - netdev->features &= ~ETH_FLAG_LRO; + netdev->features &= ~NETIF_F_LRO; if (data & ETH_FLAG_LRO) e_info("rx-usecs set to 0, " "LRO/RSC cannot be enabled.\n");
Both ETH_FLAG_LRO and NETIF_F_LRO have the same value, but NETIF_F_LRO is intended to use with netdev->features. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> --- drivers/net/ixgbe/ixgbe_ethtool.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)