| Message ID | 1462104443-30724-1-git-send-email-Julia.Lawall@lip6.fr |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Kirsher |
| Headers | show |
On Sun, May 01, 2016 at 02:07:23PM +0200, Julia Lawall wrote: > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > Thanks Julia, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On > Behalf Of Julia Lawall > Sent: Sunday, May 01, 2016 5:07 AM > To: linux-kernel@vger.kernel.org > Cc: Ismail, Mustafa <mustafa.ismail@intel.com>; netdev@vger.kernel.org; > Latif, Faisal <faisal.latif@intel.com>; linux-rdma@vger.kernel.org; Nikolova, > Tatyana E <tatyana.e.nikolova@intel.com>; Tung, Chien Tin > <chien.tin.tung@intel.com>; kernel-janitors@vger.kernel.org; Doug Ledford > <dledford@redhat.com>; intel-wired-lan@lists.osuosl.org; Hefty, Sean > <sean.hefty@intel.com>; Saleem, Shiraz <shiraz.saleem@intel.com>; Hal > Rosenstock <hal.rosenstock@gmail.com> > Subject: [Intel-wired-lan] [PATCH] i40e: constify i40e_client_ops structure > > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- > drivers/net/ethernet/intel/i40e/i40e_client.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Changes applied correctly, driver builds and passes traffic as expected
On 05/01/2016 08:07 AM, Julia Lawall wrote: > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Thanks, applied.
On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote: > On 05/01/2016 08:07 AM, Julia Lawall wrote: > > The i40e_client_ops structure is never modified, so declare it as > const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > Thanks, applied. I already have this patch queued up to push through David Miller's net-next tree. Julia- please do not shotgun blast several maintainers and several lists, it causes confusion on who is *REALLY* going to accept and apply the patch. Please use scripts/get_maintainer.pl to get the correct mailing lists and maintainers to add to the To: and CC: lines.
On Fri, 13 May 2016, Jeff Kirsher wrote: > On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote: > > On 05/01/2016 08:07 AM, Julia Lawall wrote: > > > The i40e_client_ops structure is never modified, so declare it as > > const. > > > > > > Done with the help of Coccinelle. > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > Thanks, applied. > > I already have this patch queued up to push through David Miller's net-next > tree. > > Julia- please do not shotgun blast several maintainers and several lists, > it causes confusion on who is *REALLY* going to accept and apply the patch. > Please use scripts/get_maintainer.pl to get the correct mailing lists and > maintainers to add to the To: and CC: lines. I do. Probably the patch affects files maintained by different people. My assumption would be that everyone responsible for the code that is affected by the patch would want to see it. Perhaps there would have been a way to separate it, but the const annotations typically have to be consistent everywhere. julia
On 05/13/2016 03:40 PM, Jeff Kirsher wrote: > On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote: >> On 05/01/2016 08:07 AM, Julia Lawall wrote: >>> The i40e_client_ops structure is never modified, so declare it as >> const. >>> >>> Done with the help of Coccinelle. >>> >>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> >> >> Thanks, applied. > > I already have this patch queued up to push through David Miller's net-next > tree. > > Julia- please do not shotgun blast several maintainers and several lists, > it causes confusion on who is *REALLY* going to accept and apply the patch. > Please use scripts/get_maintainer.pl to get the correct mailing lists and > maintainers to add to the To: and CC: lines. > I've dropped it from my tree. There won't be a conflict.
diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c index 90e5af2..e41fae24 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_main.c +++ b/drivers/infiniband/hw/i40iw/i40iw_main.c @@ -1863,7 +1863,7 @@ static enum i40iw_status_code i40iw_virtchnl_send(struct i40iw_sc_dev *dev, } /* client interface functions */ -static struct i40e_client_ops i40e_ops = { +static const struct i40e_client_ops i40e_ops = { .open = i40iw_open, .close = i40iw_close, .l2_param_change = i40iw_l2param_change, diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.h b/drivers/net/ethernet/intel/i40e/i40e_client.h index bf6b453..a4601d9 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_client.h +++ b/drivers/net/ethernet/intel/i40e/i40e_client.h @@ -217,7 +217,7 @@ struct i40e_client { #define I40E_CLIENT_FLAGS_LAUNCH_ON_PROBE BIT(0) #define I40E_TX_FLAGS_NOTIFY_OTHER_EVENTS BIT(2) enum i40e_client_type type; - struct i40e_client_ops *ops; /* client ops provided by the client */ + const struct i40e_client_ops *ops; /* client ops provided by the client */ }; static inline bool i40e_client_is_registered(struct i40e_client *client)
The i40e_client_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/infiniband/hw/i40iw/i40iw_main.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_client.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)