| Message ID | a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 06/23/2010 04:44 PM, Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah<amit.shah@redhat.com> > --- > qemu-config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/qemu-config.c b/qemu-config.c > index 95abe61..730ffd9 100644 > --- a/qemu-config.c > +++ b/qemu-config.c > @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { > },{ > .name = "clock", > .type = QEMU_OPT_STRING, > -#ifdef TARGET_I386 > },{ > .name = "driftfix", > .type = QEMU_OPT_STRING, > -#endif > }, > { /* end if list */ } > }, Acked-by: Paolo Bonzini <pbonzini@redhat.com> Paolo
Amit Shah <amit.shah@redhat.com> wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah <amit.shah@redhat.com> Acked-by: Juan Quintela <quintela@redhat.com> Agreed. /me had forgot that vl.c is not target dependent anymore :( Later, Juan.
On 06/23/10 16:44, Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah <amit.shah@redhat.com> > --- > qemu-config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) I really don't like exposing all these options in targets where they are not functional. It would be really nice if we could come up with a better way to handle this without just exposing them globally. Cheers, Jes
On (Wed) Jun 23 2010 [20:14:04], Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah <amit.shah@redhat.com> Ping Amit
On 07/14/2010 03:32 PM, Amit Shah wrote: > On (Wed) Jun 23 2010 [20:14:04], Amit Shah wrote: >> qemu-config.c doesn't contain any target-specific code, and the >> TARGET_I386 conditional code didn't get compiled as a result. Removing >> this enables the driftfix parameter for rtc. >> >> Signed-off-by: Amit Shah<amit.shah@redhat.com> > > Ping Ping^2 Paolo
On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah <amit.shah@redhat.com> > --- > qemu-config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/qemu-config.c b/qemu-config.c > index 95abe61..730ffd9 100644 > --- a/qemu-config.c > +++ b/qemu-config.c > @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { > },{ > .name = "clock", > .type = QEMU_OPT_STRING, > -#ifdef TARGET_I386 > },{ > .name = "driftfix", > .type = QEMU_OPT_STRING, > -#endif > }, > { /* end if list */ } > }, Is there any reason this patch hasn't been applied to GIT yet ? I'm told that using this option is critical to making certain guests work reliably so we want to use it from libvirt/virt-manager for the OS in question. Regards, Daniel
On (Fri) Aug 06 2010 [12:12:45], Daniel P. Berrange wrote: > On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote: > > qemu-config.c doesn't contain any target-specific code, and the > > TARGET_I386 conditional code didn't get compiled as a result. Removing > > this enables the driftfix parameter for rtc. > > > > Signed-off-by: Amit Shah <amit.shah@redhat.com> > > --- > > qemu-config.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/qemu-config.c b/qemu-config.c > > index 95abe61..730ffd9 100644 > > --- a/qemu-config.c > > +++ b/qemu-config.c > > @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { > > },{ > > .name = "clock", > > .type = QEMU_OPT_STRING, > > -#ifdef TARGET_I386 > > },{ > > .name = "driftfix", > > .type = QEMU_OPT_STRING, > > -#endif > > }, > > { /* end if list */ } > > }, > > > Is there any reason this patch hasn't been applied to GIT yet ? I'm told > that using this option is critical to making certain guests work reliably > so we want to use it from libvirt/virt-manager for the OS in question. Multiple pings have gone out already; I hope it's in someone's queue to be applied. Amit
On 08/06/2010 03:40 PM, Amit Shah wrote: > On (Fri) Aug 06 2010 [12:12:45], Daniel P. Berrange wrote: > >> On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote: >> >>> qemu-config.c doesn't contain any target-specific code, and the >>> TARGET_I386 conditional code didn't get compiled as a result. Removing >>> this enables the driftfix parameter for rtc. >>> >>> Signed-off-by: Amit Shah<amit.shah@redhat.com> >>> --- >>> qemu-config.c | 2 -- >>> 1 files changed, 0 insertions(+), 2 deletions(-) >>> >>> diff --git a/qemu-config.c b/qemu-config.c >>> index 95abe61..730ffd9 100644 >>> --- a/qemu-config.c >>> +++ b/qemu-config.c >>> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { >>> },{ >>> .name = "clock", >>> .type = QEMU_OPT_STRING, >>> -#ifdef TARGET_I386 >>> },{ >>> .name = "driftfix", >>> .type = QEMU_OPT_STRING, >>> -#endif >>> }, >>> { /* end if list */ } >>> }, >>> >> >> Is there any reason this patch hasn't been applied to GIT yet ? I'm told >> that using this option is critical to making certain guests work reliably >> so we want to use it from libvirt/virt-manager for the OS in question. >> > Multiple pings have gone out already; I hope it's in someone's queue to > be applied > Sorry, I've got it now. In the future, please resend patches with [RESEND] as opposed to just bumping it. Regards, Anthony Liguori > Amit >
On 06/23/2010 09:44 AM, Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah<amit.shah@redhat.com> > Applied. Thanks. Regards, Anthony Liguori > --- > qemu-config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/qemu-config.c b/qemu-config.c > index 95abe61..730ffd9 100644 > --- a/qemu-config.c > +++ b/qemu-config.c > @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { > },{ > .name = "clock", > .type = QEMU_OPT_STRING, > -#ifdef TARGET_I386 > },{ > .name = "driftfix", > .type = QEMU_OPT_STRING, > -#endif > }, > { /* end if list */ } > }, >
diff --git a/qemu-config.c b/qemu-config.c index 95abe61..730ffd9 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = { },{ .name = "clock", .type = QEMU_OPT_STRING, -#ifdef TARGET_I386 },{ .name = "driftfix", .type = QEMU_OPT_STRING, -#endif }, { /* end if list */ } },
qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah <amit.shah@redhat.com> --- qemu-config.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)