| Message ID | 20100607145158.GO5483@bicker |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> From: Dan Carpenter [mailto:error27@gmail.com] > > The extra ! character means that these conditions are always false. Looks good, thanks. This is embarrassing, I should caught this ages ago. Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com> > > Signed-off-by: Dan Carpenter <error27@gmail.com> > > diff --git a/net/caif/cfveil.c b/net/caif/cfveil.c > index 0fd827f..e04f7d9 100644 > --- a/net/caif/cfveil.c > +++ b/net/caif/cfveil.c > @@ -84,7 +84,7 @@ static int cfvei_transmit(struct cflayer *layr, > struct cfpkt *pkt) > return ret; > caif_assert(layr->dn != NULL); > caif_assert(layr->dn->transmit != NULL); > - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { > + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { > pr_warning("CAIF: %s(): Packet too large - size=%d\n", > __func__, cfpkt_getlen(pkt)); > return -EOVERFLOW; > diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c > index cd2830f..fd27b17 100644 > --- a/net/caif/cfrfml.c > +++ b/net/caif/cfrfml.c > @@ -83,7 +83,7 @@ static int cfrfml_transmit(struct cflayer *layr, > struct cfpkt *pkt) > if (!cfsrvl_ready(service, &ret)) > return ret; > > - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { > + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { > pr_err("CAIF: %s():Packet too large - size=%d\n", > __func__, cfpkt_getlen(pkt)); > return -EOVERFLOW; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com> Date: Wed, 9 Jun 2010 11:11:38 +0200 >> From: Dan Carpenter [mailto:error27@gmail.com] >> >> The extra ! character means that these conditions are always false. > > > Looks good, thanks. This is embarrassing, I should caught this ages ago. > Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com> Applied, thanks guys. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/caif/cfveil.c b/net/caif/cfveil.c index 0fd827f..e04f7d9 100644 --- a/net/caif/cfveil.c +++ b/net/caif/cfveil.c @@ -84,7 +84,7 @@ static int cfvei_transmit(struct cflayer *layr, struct cfpkt *pkt) return ret; caif_assert(layr->dn != NULL); caif_assert(layr->dn->transmit != NULL); - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { pr_warning("CAIF: %s(): Packet too large - size=%d\n", __func__, cfpkt_getlen(pkt)); return -EOVERFLOW; diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c index cd2830f..fd27b17 100644 --- a/net/caif/cfrfml.c +++ b/net/caif/cfrfml.c @@ -83,7 +83,7 @@ static int cfrfml_transmit(struct cflayer *layr, struct cfpkt *pkt) if (!cfsrvl_ready(service, &ret)) return ret; - if (!cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { + if (cfpkt_getlen(pkt) > CAIF_MAX_PAYLOAD_SIZE) { pr_err("CAIF: %s():Packet too large - size=%d\n", __func__, cfpkt_getlen(pkt)); return -EOVERFLOW;
The extra ! character means that these conditions are always false. Signed-off-by: Dan Carpenter <error27@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html