| Message ID | 20160316222358.GA5106@sonyv |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
On Wed, Mar 16, 2016 at 11:24:00PM +0100, Laura Garcia Liebana wrote: > Avoid to print the reject with value in the translation when the value is the default. > > Before this patch: > > $ sudo iptables-translate -A FORWARD -p TCP --dport 22 -j REJECT > nft add rule ip filter FORWARD tcp dport 22 counter reject with icmp type port-unreachable > > After this patch: > > $ sudo iptables-translate -A FORWARD -p TCP --dport 22 -j REJECT > nft add rule ip filter FORWARD tcp dport 22 counter reject Applied this too, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/extensions/libipt_REJECT.c b/extensions/libipt_REJECT.c index 4148776..c211da9 100644 --- a/extensions/libipt_REJECT.c +++ b/extensions/libipt_REJECT.c @@ -171,7 +171,9 @@ static int REJECT_xlate(const void *ip, const struct xt_entry_target *target, break; } - if (reject->with == IPT_TCP_RESET) + if (reject->with == IPT_ICMP_PORT_UNREACHABLE) + xt_xlate_add(xl, "reject"); + else if (reject->with == IPT_TCP_RESET) xt_xlate_add(xl, "reject with %s", reject_table_xlate[i].name); else
Avoid to print the reject with value in the translation when the value is the default. Before this patch: $ sudo iptables-translate -A FORWARD -p TCP --dport 22 -j REJECT nft add rule ip filter FORWARD tcp dport 22 counter reject with icmp type port-unreachable After this patch: $ sudo iptables-translate -A FORWARD -p TCP --dport 22 -j REJECT nft add rule ip filter FORWARD tcp dport 22 counter reject Signed-off-by: Laura Garcia Liebana <nevola@gmail.com> --- v2: - Fix default constant, as Pablo suggested. extensions/libipt_REJECT.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)