| Message ID | 1457083241-7492-16-git-send-email-janusz.dziedzic@tieto.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Fri, Mar 04, 2016 at 10:20:31AM +0100, Janusz Dziedzic wrote: > In case we are using wpa_cli to connect global UDP > interface, before we have "UNKNOWN COMMAND\n" string > as ifname. Change this to "unknown". Why would "unknown" be any better than "UNKNOWN COMMAND\n"? "unknown" would be a valid name of an interface. If we want to changes "UNKNOWN COMMAND\n" to something, that something better be something that can be clearly identified as not being a network interface.
On 5 March 2016 at 15:33, Jouni Malinen <j@w1.fi> wrote: > On Fri, Mar 04, 2016 at 10:20:31AM +0100, Janusz Dziedzic wrote: >> In case we are using wpa_cli to connect global UDP >> interface, before we have "UNKNOWN COMMAND\n" string >> as ifname. Change this to "unknown". > > Why would "unknown" be any better than "UNKNOWN COMMAND\n"? "unknown" > would be a valid name of an interface. If we want to changes "UNKNOWN > COMMAND\n" to something, that something better be something that can be > clearly identified as not being a network interface. > No idea here, added this because of "cosmetic" purpose. So, maybe skip this one or just remove "\n"? BR Janusz > -- > Jouni Malinen PGP id EFC895FA
On Sun, Mar 06, 2016 at 12:00:50PM +0100, Janusz Dziedzic wrote: > On 5 March 2016 at 15:33, Jouni Malinen <j@w1.fi> wrote: > > On Fri, Mar 04, 2016 at 10:20:31AM +0100, Janusz Dziedzic wrote: > >> In case we are using wpa_cli to connect global UDP > >> interface, before we have "UNKNOWN COMMAND\n" string > >> as ifname. Change this to "unknown". > > > > Why would "unknown" be any better than "UNKNOWN COMMAND\n"? "unknown" > > would be a valid name of an interface. If we want to changes "UNKNOWN > > COMMAND\n" to something, that something better be something that can be > > clearly identified as not being a network interface. > > > No idea here, added this because of "cosmetic" purpose. So, maybe skip > this one or just remove "\n"? Why would "\n" be removed? I don't really understand what is the point of this change in the first place. What is this needed for?
On 7 March 2016 at 09:59, Jouni Malinen <j@w1.fi> wrote: > On Sun, Mar 06, 2016 at 12:00:50PM +0100, Janusz Dziedzic wrote: >> On 5 March 2016 at 15:33, Jouni Malinen <j@w1.fi> wrote: >> > On Fri, Mar 04, 2016 at 10:20:31AM +0100, Janusz Dziedzic wrote: >> >> In case we are using wpa_cli to connect global UDP >> >> interface, before we have "UNKNOWN COMMAND\n" string >> >> as ifname. Change this to "unknown". >> > >> > Why would "unknown" be any better than "UNKNOWN COMMAND\n"? "unknown" >> > would be a valid name of an interface. If we want to changes "UNKNOWN >> > COMMAND\n" to something, that something better be something that can be >> > clearly identified as not being a network interface. >> > >> No idea here, added this because of "cosmetic" purpose. So, maybe skip >> this one or just remove "\n"? > > Why would "\n" be removed? I don't really understand what is the point > of this change in the first place. What is this needed for? > When using wpa_cli with UDP support we have nice prompt: hostname/wlan0> wlan0 is a result of "IFNAME", so for global iface we see: localhost/UNKNOWN COMMAND > BR Janusz > -- > Jouni Malinen PGP id EFC895FA
diff --git a/src/common/wpa_ctrl.c b/src/common/wpa_ctrl.c index 623c2a7..042914f 100644 --- a/src/common/wpa_ctrl.c +++ b/src/common/wpa_ctrl.c @@ -435,6 +435,8 @@ struct wpa_ctrl * wpa_ctrl_open(const char *ctrl_path) if (wpa_ctrl_request(ctrl, "IFNAME", 6, buf, &len, NULL) == 0) { buf[len] = '\0'; + if (os_strcmp(buf, "UNKNOWN COMMAND\n") == 0) + os_snprintf(buf, len, "unknown"); ctrl->remote_ifname = os_strdup(buf); }
In case we are using wpa_cli to connect global UDP interface, before we have "UNKNOWN COMMAND\n" string as ifname. Change this to "unknown". Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com> --- src/common/wpa_ctrl.c | 2 ++ 1 file changed, 2 insertions(+)