| Message ID | 1274490476-16057-3-git-send-email-maximlevitsky@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, 2010-05-22 at 04:07 +0300, Maxim Levitsky wrote: > > @@ -129,6 +131,7 @@ config MTD_NAND_RICOH > default n > depends on PCI > select MTD_SM_COMMON > + select MTD_NAND_ECC_SMC I thought we had a better solution than this -- weren't we going to make it a runtime thing? And default to the 'correct' order? Then, only the legacy devices which need to retain the 'wrong' byteorder for compatibility reasons will need to do it.
On Sat, 2010-05-22 at 08:47 +0100, David Woodhouse wrote: > On Sat, 2010-05-22 at 04:07 +0300, Maxim Levitsky wrote: > > > > @@ -129,6 +131,7 @@ config MTD_NAND_RICOH > > default n > > depends on PCI > > select MTD_SM_COMMON > > + select MTD_NAND_ECC_SMC > > I thought we had a better solution than this -- weren't we going to make > it a runtime thing? And default to the 'correct' order? > > Then, only the legacy devices which need to retain the 'wrong' byteorder > for compatibility reasons will need to do it. > Sure, but I'll need to do several changes to drivers that I can't test. For now this ensures correctness, then I fix all of this. Best regards, Maxim Levitsky
On Sat, 2010-05-22 at 10:58 +0300, Maxim Levitsky wrote: > On Sat, 2010-05-22 at 08:47 +0100, David Woodhouse wrote: > > On Sat, 2010-05-22 at 04:07 +0300, Maxim Levitsky wrote: > > > > > > @@ -129,6 +131,7 @@ config MTD_NAND_RICOH > > > default n > > > depends on PCI > > > select MTD_SM_COMMON > > > + select MTD_NAND_ECC_SMC > > > > I thought we had a better solution than this -- weren't we going to make > > it a runtime thing? And default to the 'correct' order? > > > > Then, only the legacy devices which need to retain the 'wrong' byteorder > > for compatibility reasons will need to do it. > > > Sure, but I'll need to do several changes to drivers that I can't test. > For now this ensures correctness, then I fix all of this. In other words, when I get a bit more free time I promise I fix this and other problems. For now this ensures correctness at least of this thing. Best regards, Maxim Levitsky
On Sat, 2010-05-22 at 11:06 +0300, Maxim Levitsky wrote: > On Sat, 2010-05-22 at 10:58 +0300, Maxim Levitsky wrote: > > On Sat, 2010-05-22 at 08:47 +0100, David Woodhouse wrote: > > > On Sat, 2010-05-22 at 04:07 +0300, Maxim Levitsky wrote: > > > > > > > > @@ -129,6 +131,7 @@ config MTD_NAND_RICOH > > > > default n > > > > depends on PCI > > > > select MTD_SM_COMMON > > > > + select MTD_NAND_ECC_SMC > > > > > > I thought we had a better solution than this -- weren't we going to make > > > it a runtime thing? And default to the 'correct' order? > > > > > > Then, only the legacy devices which need to retain the 'wrong' byteorder > > > for compatibility reasons will need to do it. > > > > > Sure, but I'll need to do several changes to drivers that I can't test. > > For now this ensures correctness, then I fix all of this. > In other words, when I get a bit more free time I promise I fix this and > other problems. For now this ensures correctness at least of this thing. Thinking again about this, this doesn't help much ether, so lets keep it as is, except that 'if MTD_NAND' should be moved higher. Best regards, Maxim Levitsky
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 98a04b3..8db333f 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -8,6 +8,8 @@ menuconfig MTD_NAND devices. For further information see <http://www.linux-mtd.infradead.org/doc/nand.html>. +if MTD_NAND + config MTD_NAND_ECC tristate @@ -19,7 +21,7 @@ config MTD_NAND_ECC_SMC Software ECC according to the Smart Media Specification. The original Linux implementation had byte 0 and 1 swapped. -if MTD_NAND + config MTD_NAND_VERIFY_WRITE bool "Verify NAND page writes" @@ -129,6 +131,7 @@ config MTD_NAND_RICOH default n depends on PCI select MTD_SM_COMMON + select MTD_NAND_ECC_SMC help Enable support for Ricoh R5C852 xD card reader You also need to enable ether
Move all nand options under 'if MTD_NAND' otherwise xconfig output is broken. make Ricoh xD driver depend on MTD_NAND_ECC_SMC, untill proper solution is made Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> --- drivers/mtd/nand/Kconfig | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)