| Message ID | alpine.DEB.2.00.1601100130120.5958@tp.orcam.me.uk |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, 11 Jan 2016, Maciej W. Rozycki wrote: > The timing is such that support for the said feature is scheduled for > inclusion in Linux 4.5.0 and the first release candidate, 4.5.0-rc1, which > is expected to be the first upstream kernel version to include the > feature, is currently scheduled for Jan 24th. This date is however > already after the hard freeze for our code is expected to have started. OK once the feature is in Linus's git tree, and with a reference in the glibc commit message to the git commit in Linus's tree.
On Mon, 11 Jan 2016, Joseph Myers wrote: > > The timing is such that support for the said feature is scheduled for > > inclusion in Linux 4.5.0 and the first release candidate, 4.5.0-rc1, which > > is expected to be the first upstream kernel version to include the > > feature, is currently scheduled for Jan 24th. This date is however > > already after the hard freeze for our code is expected to have started. > > OK once the feature is in Linus's git tree, and with a reference in the > glibc commit message to the git commit in Linus's tree. Linux 4.5-rc1 is out now, with the 2008 NaN feature included, so I have commited this change now. Thanks for your review. Maciej
Index: glibc/sysdeps/unix/sysv/linux/mips/configure =================================================================== --- glibc.orig/sysdeps/unix/sysv/linux/mips/configure 2016-01-07 13:57:37.121968046 +0000 +++ glibc/sysdeps/unix/sysv/linux/mips/configure 2016-01-07 15:25:08.876938262 +0000 @@ -472,9 +472,6 @@ libc_cv_gcc_unwind_find_fde=yes if test -z "$arch_minimum_kernel"; then if test x$libc_cv_mips_nan2008 = xyes; then - # FIXME: Adjust this setting to the actual first upstream kernel - # version to support the 2008 NaN encoding and then remove this - # comment. - arch_minimum_kernel=10.0.0 + arch_minimum_kernel=4.5.0 fi fi Index: glibc/sysdeps/unix/sysv/linux/mips/configure.ac =================================================================== --- glibc.orig/sysdeps/unix/sysv/linux/mips/configure.ac 2016-01-07 13:57:37.143376351 +0000 +++ glibc/sysdeps/unix/sysv/linux/mips/configure.ac 2016-01-07 15:25:20.605523157 +0000 @@ -131,9 +131,6 @@ libc_cv_gcc_unwind_find_fde=yes if test -z "$arch_minimum_kernel"; then if test x$libc_cv_mips_nan2008 = xyes; then - # FIXME: Adjust this setting to the actual first upstream kernel - # version to support the 2008 NaN encoding and then remove this - # comment. - arch_minimum_kernel=10.0.0 + arch_minimum_kernel=4.5.0 fi fi
* sysdeps/unix/sysv/linux/mips/configure.ac: Set `arch_minimum_kernel' to 4.5.0 if 2008 NaN encoding is used. * sysdeps/unix/sysv/linux/mips/configure: Regenerate. --- Hi, This is a heads-up for the upcoming IEEE Std 754-2008 NaN encoding support in the MIPS port of the Linux kernel. I'm sending this note now because of the imminent code freeze for the upcoming 2.23 glibc release. The timing is such that support for the said feature is scheduled for inclusion in Linux 4.5.0 and the first release candidate, 4.5.0-rc1, which is expected to be the first upstream kernel version to include the feature, is currently scheduled for Jan 24th. This date is however already after the hard freeze for our code is expected to have started. As the change, provided below, to set the required Linux kernel version to 4.5.0 for IEEE Std 754-2008 NaN encoding does not really change code in any way and merely records a fact I request for this change to be approved for inclusion in glibc trunk anytime before the 2.23 release has actually been rolled out regardless of the declared freeze state of the code base, provided that the Linux kernel feature has actually been included. In my opinion there is no risk to the quality of our release from having this change included even late in the release preparation cycle, and certainly there is no benefit from deferring this change only until the following 2.24 release, expected half a year from now. Maciej glibc-mips-nan-2008-minimum-kernel.diff