Message ID | 1452338674-3353-1-git-send-email-sedat.dilek@gmail.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
Hi Sedat, [auto build test ERROR on net/master] [cannot apply to net-next/master v4.4-rc8 next-20160108] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Sedat-Dilek/phy-micrel-Fix-build-failure-in-ksz9031_config_init/20160109-192630 config: x86_64-randconfig-x000-01060743 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/net/phy/micrel.c: In function 'ksz9031_config_init': >> drivers/net/phy/micrel.c:479:22: error: 'struct phy_device' has no member named 'mdio' dev_walker = &phydev->mdio.dev; ^ vim +479 drivers/net/phy/micrel.c 473 const struct device *dev_walker; 474 475 /* The Micrel driver has a deprecated option to place phy OF 476 * properties in the MAC node. Walk up the tree of devices to 477 * find a device with an OF node. 478 */ > 479 dev_walker = &phydev->mdio.dev; 480 do { 481 of_node = dev_walker->of_node; 482 dev_walker = dev_walker->parent; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Sat, Jan 9, 2016 at 12:49 PM, kbuild test robot <lkp@intel.com> wrote: > Hi Sedat, > > [auto build test ERROR on net/master] > [cannot apply to net-next/master v4.4-rc8 next-20160108] > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] > This patch is for net.git#master not net-next or Linux-next. I should have add a proper label, Sorry. - Sedat - > url: https://github.com/0day-ci/linux/commits/Sedat-Dilek/phy-micrel-Fix-build-failure-in-ksz9031_config_init/20160109-192630 > config: x86_64-randconfig-x000-01060743 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > drivers/net/phy/micrel.c: In function 'ksz9031_config_init': >>> drivers/net/phy/micrel.c:479:22: error: 'struct phy_device' has no member named 'mdio' > dev_walker = &phydev->mdio.dev; > ^ > > vim +479 drivers/net/phy/micrel.c > > 473 const struct device *dev_walker; > 474 > 475 /* The Micrel driver has a deprecated option to place phy OF > 476 * properties in the MAC node. Walk up the tree of devices to > 477 * find a device with an OF node. > 478 */ > > 479 dev_walker = &phydev->mdio.dev; > 480 do { > 481 of_node = dev_walker->of_node; > 482 dev_walker = dev_walker->parent; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Sat, Jan 9, 2016 at 12:55 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote: > On Sat, Jan 9, 2016 at 12:49 PM, kbuild test robot <lkp@intel.com> wrote: >> Hi Sedat, >> >> [auto build test ERROR on net/master] >> [cannot apply to net-next/master v4.4-rc8 next-20160108] >> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] >> > > This patch is for net.git#master not net-next or Linux-next. > I should have add a proper label, Sorry. > See <https://patchwork.ozlabs.org/patch/565144/> - Sedat - >> url: https://github.com/0day-ci/linux/commits/Sedat-Dilek/phy-micrel-Fix-build-failure-in-ksz9031_config_init/20160109-192630 >> config: x86_64-randconfig-x000-01060743 (attached as .config) >> reproduce: >> # save the attached .config to linux build tree >> make ARCH=x86_64 >> >> All errors (new ones prefixed by >>): >> >> drivers/net/phy/micrel.c: In function 'ksz9031_config_init': >>>> drivers/net/phy/micrel.c:479:22: error: 'struct phy_device' has no member named 'mdio' >> dev_walker = &phydev->mdio.dev; >> ^ >> >> vim +479 drivers/net/phy/micrel.c >> >> 473 const struct device *dev_walker; >> 474 >> 475 /* The Micrel driver has a deprecated option to place phy OF >> 476 * properties in the MAC node. Walk up the tree of devices to >> 477 * find a device with an OF node. >> 478 */ >> > 479 dev_walker = &phydev->mdio.dev; >> 480 do { >> 481 of_node = dev_walker->of_node; >> 482 dev_walker = dev_walker->parent; >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 7a5679982c03..a7e17eabec37 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -476,7 +476,7 @@ static int ksz9031_config_init(struct phy_device *phydev) * properties in the MAC node. Walk up the tree of devices to * find a device with an OF node. */ - dev_walker = &phydev->dev; + dev_walker = &phydev->mdio.dev; do { of_node = dev_walker->of_node; dev_walker = dev_walker->parent;
This fixes the following build failure seen in net.git#master on top of Linux v4.4-rc8+: drivers/net/phy/micrel.c: In function 'ksz9031_config_init': drivers/net/phy/micrel.c:492:22: error: 'struct phy_device' has no member named 'dev' dev_walker = &phydev->dev; Fixes: b4c19f71252e ("phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.") CC: Roosen Henri <Henri.Roosen@ginzinger.com> CC: Andrew Lunn <andrew@lunn.ch> CC: David Daney <david.daney@cavium.com> CC: Florian Fainelli <f.fainelli@gmail.com> CC: David S. Miller <davem@davemloft.net> CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> --- drivers/net/phy/micrel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)