| Message ID | e970485f0e9f4c9e1cb6e594a45dd11308683197@localhost.localdomain |
|---|---|
| State | Accepted |
| Commit | 9ea5973883bbe26372f45d99eb3a500f08d966f9 |
| Headers | show |
On Sat, 2010-04-10 at 11:18 -0700, Kevin Cernekee wrote: > With gcc 4.4.3 -O2 on MIPS32: > > drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present': > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > include/linux/mtd/map.h:375: note: 'r' was declared here > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > include/linux/mtd/map.h:375: note: 'r' was declared here > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> Pushed to l2-mtd-2.6 / dunno
On Tue, 2010-04-27 at 10:46 +0300, Artem Bityutskiy wrote: > On Sat, 2010-04-10 at 11:18 -0700, Kevin Cernekee wrote: > > With gcc 4.4.3 -O2 on MIPS32: > > > > drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present': > > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > > include/linux/mtd/map.h:375: note: 'r' was declared here > > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > > include/linux/mtd/map.h:375: note: 'r' was declared here > > > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> > > Pushed to l2-mtd-2.6 / dunno Removed from my tree because this breaks compilation: [dedekind@eru l2-mtd-2.6]$ make ARCH=arm O=/home/dedekind/tmp/l2-mtd-2.6-arm/ Using /home/dedekind/git/l2-mtd-2.6 as source for kernel GEN /home/dedekind/tmp/l2-mtd-2.6-arm/Makefile CHK include/linux/version.h CHK include/generated/utsrelease.h make[2]: `include/generated/mach-types.h' is up to date. CALL /home/dedekind/git/l2-mtd-2.6/scripts/checksyscalls.sh CHK include/generated/compile.h CC [M] drivers/mtd/lpddr/lpddr_cmds.o In file included from /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/qinfo.h:4, from /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/pfow.h:7, from /home/dedekind/git/l2-mtd-2.6/drivers/mtd/lpddr/lpddr_cmds.c:27: /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h: In function 'inline_map_read': /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h:390: error: implicit declaration of function 'BUG' make[4]: *** [drivers/mtd/lpddr/lpddr_cmds.o] Error 1 make[3]: *** [drivers/mtd/lpddr] Error 2 make[2]: *** [drivers/mtd] Error 2 make[1]: *** [drivers] Error 2 make: *** [sub-make] Error 2 [dedekind@eru l2-mtd-2.6]$ git revert ae60e258dda8a9c575fcbd68f05ca034ad043a36^C [dedekind@eru l2-mtd-2.6]$ git log
On Tue, May 4, 2010 at 6:04 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h: In function 'inline_map_read': > /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h:390: error: implicit declaration of function 'BUG' I did test my patch, but it didn't generate any warnings or errors on MIPS... Could you please apply this patch and retry: http://lists.infradead.org/pipermail/linux-mtd/2010-May/029904.html <linux/bug.h> should probably be added anyway since there are two other BUG statements in that file. Thanks.
On Tue, 2010-05-04 at 13:06 -0700, Kevin Cernekee wrote: > On Tue, May 4, 2010 at 6:04 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > > /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h: In function 'inline_map_read': > > /home/dedekind/git/l2-mtd-2.6/include/linux/mtd/map.h:390: error: implicit declaration of function 'BUG' > > I did test my patch, but it didn't generate any warnings or errors on MIPS... > > Could you please apply this patch and retry: > > http://lists.infradead.org/pipermail/linux-mtd/2010-May/029904.html > > <linux/bug.h> should probably be added anyway since there are two > other BUG statements in that file. Pushed this patch and the '[PATCH] mtd: map.h: add missing bug.h include' one back to l2-mtd-2.6 / dunno.
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index b981b87..56a4592 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -386,6 +386,8 @@ static inline map_word inline_map_read(struct map_info *map, unsigned long ofs) #endif else if (map_bankwidth_is_large(map)) memcpy_fromio(r.x, map->virt+ofs, map->bankwidth); + else + BUG(); return r; }
With gcc 4.4.3 -O2 on MIPS32: drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present': include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function include/linux/mtd/map.h:375: note: 'r' was declared here include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function include/linux/mtd/map.h:375: note: 'r' was declared here Signed-off-by: Kevin Cernekee <cernekee@gmail.com> --- include/linux/mtd/map.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)