diff mbox

[1/1,v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

Message ID 1451985169-4622-1-git-send-email-xypron.glpk@gmx.de
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Heinrich Schuchardt Jan. 5, 2016, 9:12 a.m. UTC
IOCTL SIOCRTMSG does nothing but return EINVAL.

So comment it as unused.

SIOCRTMSG is only used in:
* net/ipv4/af_inet.c
* include/uapi/linux/sockios.h

inet_ioctl calls ip_rt_ioctl.
ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
otherwise.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/uapi/linux/sockios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Jan. 5, 2016, 9:44 p.m. UTC | #1
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue,  5 Jan 2016 10:12:49 +0100

> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.
> 
> SIOCRTMSG is only used in:
> * net/ipv4/af_inet.c
> * include/uapi/linux/sockios.h
> 
> inet_ioctl calls ip_rt_ioctl.
> ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
> otherwise.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
index e888b1a..8e7890b 100644
--- a/include/uapi/linux/sockios.h
+++ b/include/uapi/linux/sockios.h
@@ -27,7 +27,7 @@ 
 /* Routing table calls. */
 #define SIOCADDRT	0x890B		/* add routing table entry	*/
 #define SIOCDELRT	0x890C		/* delete routing table entry	*/
-#define SIOCRTMSG	0x890D		/* call to routing system	*/
+#define SIOCRTMSG	0x890D		/* unused			*/
 
 /* Socket configuration controls. */
 #define SIOCGIFNAME	0x8910		/* get iface name		*/