| Message ID | 201004211217.12697.roman.fietze@telemotive.de |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On 04/21/2010 12:17 PM, Roman Fietze wrote: > Hello, > > If I understand libata-core correctly, esp. arround line 6572: > > /* parse id */ > p = strchr(id, '.'); > ... > > the optional device is separated from the port in the libata.force ID > by a point or dot instead of by a colon. > > If my assumption is correct, this patch will fix the documentation: > > Signed-off-by: Roman Fietze <roman.fietze@telemotive.de> Heh, nice catch. Acked-by: Tejun Heo <tj@kernel.org> Thanks.
On 04/21/2010 06:17 AM, Roman Fietze wrote: > Hello, > > If I understand libata-core correctly, esp. arround line 6572: > > /* parse id */ > p = strchr(id, '.'); > ... > > the optional device is separated from the port in the libata.force ID > by a point or dot instead of by a colon. > > If my assumption is correct, this patch will fix the documentation: > > Signed-off-by: Roman Fietze<roman.fietze@telemotive.de> > --- > Documentation/kernel-parameters.txt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index e7848a0..ea5a826 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -1193,7 +1193,7 @@ and is between 256 and 4096 characters. It is defined in the file > > libata.force= [LIBATA] Force configurations. The format is comma > separated list of "[ID:]VAL" where ID is > - PORT[:DEVICE]. PORT and DEVICE are decimal numbers > + PORT[.DEVICE]. PORT and DEVICE are decimal numbers > matching port, link or device. Basically, it matches > the ATA ID string printed on console by libata. If applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index e7848a0..ea5a826 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -1193,7 +1193,7 @@ and is between 256 and 4096 characters. It is defined in the file libata.force= [LIBATA] Force configurations. The format is comma separated list of "[ID:]VAL" where ID is - PORT[:DEVICE]. PORT and DEVICE are decimal numbers + PORT[.DEVICE]. PORT and DEVICE are decimal numbers matching port, link or device. Basically, it matches the ATA ID string printed on console by libata. If the whole ID part is omitted, the last PORT and DEVICE
Hello, If I understand libata-core correctly, esp. arround line 6572: /* parse id */ p = strchr(id, '.'); ... the optional device is separated from the port in the libata.force ID by a point or dot instead of by a colon. If my assumption is correct, this patch will fix the documentation: Signed-off-by: Roman Fietze <roman.fietze@telemotive.de> --- Documentation/kernel-parameters.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)