| Message ID | 4BCD1FB2.9060100@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | Andy Whitcroft |
| Headers | show |
On 04/19/2010 09:29 PM, Eric Miao wrote: > commit b224640b7e8b201c679dab961de9b36dc832803a > Author: Eric Miao<eric.miao@canonical.com> > Date: Tue Apr 20 10:06:27 2010 +0800 > > UBUNTU: [Config] increase CONFIG_BLK_DEV_RAM_SIZE to 65536 > > BugLink: http://bugs.launchpad.net/bugs/563679 > > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > > Signed-off-by: Eric Miao<eric.miao@canonical.com> > > diff --git a/debian.mvl-dove/config/config.common.ubuntu > b/debian.mvl-dove/config/config.common.ubuntu > index 6f859b4..6d15247 100644 > --- a/debian.mvl-dove/config/config.common.ubuntu > +++ b/debian.mvl-dove/config/config.common.ubuntu > @@ -265,8 +265,8 @@ CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_MD=m > CONFIG_BLK_DEV_NBD=m > CONFIG_BLK_DEV_RAM=y > -CONFIG_BLK_DEV_RAM_COUNT=1 > -CONFIG_BLK_DEV_RAM_SIZE=4096 > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > CONFIG_BLK_DEV_SD=y > CONFIG_BLK_DEV_SR=m > # CONFIG_BLK_DEV_SR_VENDOR is not set > Assuming testing has shown this to work: Acked-by: Tim Gardner <tim.gardner@canonical.com>
On Tue, Apr 20, 2010 at 11:29:54AM +0800, Eric Miao wrote: > commit b224640b7e8b201c679dab961de9b36dc832803a > Author: Eric Miao <eric.miao@canonical.com> > Date: Tue Apr 20 10:06:27 2010 +0800 > > UBUNTU: [Config] increase CONFIG_BLK_DEV_RAM_SIZE to 65536 > > BugLink: http://bugs.launchpad.net/bugs/563679 > > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > > Signed-off-by: Eric Miao <eric.miao@canonical.com> > > diff --git a/debian.mvl-dove/config/config.common.ubuntu > b/debian.mvl-dove/config/config.common.ubuntu > index 6f859b4..6d15247 100644 > --- a/debian.mvl-dove/config/config.common.ubuntu > +++ b/debian.mvl-dove/config/config.common.ubuntu > @@ -265,8 +265,8 @@ CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_MD=m > CONFIG_BLK_DEV_NBD=m > CONFIG_BLK_DEV_RAM=y > -CONFIG_BLK_DEV_RAM_COUNT=1 > -CONFIG_BLK_DEV_RAM_SIZE=4096 > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > CONFIG_BLK_DEV_SD=y > CONFIG_BLK_DEV_SR=m > # CONFIG_BLK_DEV_SR_VENDOR is not set Looks good. Acked-by: Andy Whitcroft <apw@canonical.com> -apw
Applied to Lucid. -apw
On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: > +CONFIG_BLK_DEV_RAM_COUNT=16 > This will have a significant boot performance impact; since now 16 block devices will have to be created and probed, instead of one. Scott
On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: > commit b224640b7e8b201c679dab961de9b36dc832803a > Author: Eric Miao <eric.miao@canonical.com> > Date: Tue Apr 20 10:06:27 2010 +0800 > > UBUNTU: [Config] increase CONFIG_BLK_DEV_RAM_SIZE to 65536 > > BugLink: http://bugs.launchpad.net/bugs/563679 > > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > > Signed-off-by: Eric Miao <eric.miao@canonical.com> > > diff --git a/debian.mvl-dove/config/config.common.ubuntu > b/debian.mvl-dove/config/config.common.ubuntu > index 6f859b4..6d15247 100644 > --- a/debian.mvl-dove/config/config.common.ubuntu > +++ b/debian.mvl-dove/config/config.common.ubuntu > @@ -265,8 +265,8 @@ CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_MD=m > CONFIG_BLK_DEV_NBD=m > CONFIG_BLK_DEV_RAM=y > -CONFIG_BLK_DEV_RAM_COUNT=1 > -CONFIG_BLK_DEV_RAM_SIZE=4096 > +CONFIG_BLK_DEV_RAM_COUNT=16 > +CONFIG_BLK_DEV_RAM_SIZE=65536 > CONFIG_BLK_DEV_SD=y > CONFIG_BLK_DEV_SR=m > # CONFIG_BLK_DEV_SR_VENDOR is not set > Why are we also increasing the count from 1 to 16?
On Thu, Apr 22, 2010 at 4:35 AM, Colin Ian King <colin.king@canonical.com> wrote: > On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: >> commit b224640b7e8b201c679dab961de9b36dc832803a >> Author: Eric Miao <eric.miao@canonical.com> >> Date: Tue Apr 20 10:06:27 2010 +0800 >> >> UBUNTU: [Config] increase CONFIG_BLK_DEV_RAM_SIZE to 65536 >> >> BugLink: http://bugs.launchpad.net/bugs/563679 >> >> +CONFIG_BLK_DEV_RAM_COUNT=16 >> +CONFIG_BLK_DEV_RAM_SIZE=65536 >> >> Signed-off-by: Eric Miao <eric.miao@canonical.com> >> >> diff --git a/debian.mvl-dove/config/config.common.ubuntu >> b/debian.mvl-dove/config/config.common.ubuntu >> index 6f859b4..6d15247 100644 >> --- a/debian.mvl-dove/config/config.common.ubuntu >> +++ b/debian.mvl-dove/config/config.common.ubuntu >> @@ -265,8 +265,8 @@ CONFIG_BLK_DEV_LOOP=y >> CONFIG_BLK_DEV_MD=m >> CONFIG_BLK_DEV_NBD=m >> CONFIG_BLK_DEV_RAM=y >> -CONFIG_BLK_DEV_RAM_COUNT=1 >> -CONFIG_BLK_DEV_RAM_SIZE=4096 >> +CONFIG_BLK_DEV_RAM_COUNT=16 >> +CONFIG_BLK_DEV_RAM_SIZE=65536 >> CONFIG_BLK_DEV_SD=y >> CONFIG_BLK_DEV_SR=m >> # CONFIG_BLK_DEV_SR_VENDOR is not set >> > Why are we also increasing the count from 1 to 16? > Loic pointed out the potential issue of RAM_SIZE being too small to cause d-i initrds to fail. The DEV_RAM_COUNT is actually sync'ed with x86, so it will benefit both ARM and x86 if this can be reduced.
hi, Am Mittwoch, den 21.04.2010, 11:43 -0700 schrieb Scott James Remnant: > On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: > > > +CONFIG_BLK_DEV_RAM_COUNT=16 > > > This will have a significant boot performance impact; since now 16 block > devices will have to be created and probed, instead of one. since the patch is supposed to add initrd (vs. initramfs) support i wonder why we actually need more than one here, bumping the size for one device should be totally enough to make the usecase work. ciao oli
On Wed, Apr 21, 2010 at 11:43:00AM -0700, Scott James Remnant wrote: > On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: > > > +CONFIG_BLK_DEV_RAM_COUNT=16 > > > This will have a significant boot performance impact; since now 16 block > devices will have to be created and probed, instead of one. This change was for the mvl-dove branch only, and mearly brings it into line with the master branch. Is this something we should be reviewing across the board? -apw
On Wed, Apr 21, 2010, Scott James Remnant wrote: > > +CONFIG_BLK_DEV_RAM_COUNT=16 > > > This will have a significant boot performance impact; since now 16 block > devices will have to be created and probed, instead of one. Sounds like we need to revisit this for all configs; this thread was mostly about bringing dove on par with the other configs.
On Thu, 2010-04-22 at 08:19 +0100, Andy Whitcroft wrote: > On Wed, Apr 21, 2010 at 11:43:00AM -0700, Scott James Remnant wrote: > > On Tue, 2010-04-20 at 11:29 +0800, Eric Miao wrote: > > > > > +CONFIG_BLK_DEV_RAM_COUNT=16 > > > > > This will have a significant boot performance impact; since now 16 block > > devices will have to be created and probed, instead of one. > > This change was for the mvl-dove branch only, and mearly brings it into > line with the master branch. Is this something we should be reviewing > across the board? > Right, I was just warning that it might affect that branch - one assumes it was =1 for a reason. I think I'd rather just see on-demand allocation of RAM and LOOP devices rather than fixed numbers in the kernel config ;-) Scott
diff --git a/debian.mvl-dove/config/config.common.ubuntu b/debian.mvl-dove/config/config.common.ubuntu index 6f859b4..6d15247 100644 --- a/debian.mvl-dove/config/config.common.ubuntu +++ b/debian.mvl-dove/config/config.common.ubuntu @@ -265,8 +265,8 @@ CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_MD=m CONFIG_BLK_DEV_NBD=m CONFIG_BLK_DEV_RAM=y -CONFIG_BLK_DEV_RAM_COUNT=1 -CONFIG_BLK_DEV_RAM_SIZE=4096 +CONFIG_BLK_DEV_RAM_COUNT=16 +CONFIG_BLK_DEV_RAM_SIZE=65536 CONFIG_BLK_DEV_SD=y CONFIG_BLK_DEV_SR=m # CONFIG_BLK_DEV_SR_VENDOR is not set
commit b224640b7e8b201c679dab961de9b36dc832803a Author: Eric Miao <eric.miao@canonical.com> Date: Tue Apr 20 10:06:27 2010 +0800 UBUNTU: [Config] increase CONFIG_BLK_DEV_RAM_SIZE to 65536 BugLink: http://bugs.launchpad.net/bugs/563679 +CONFIG_BLK_DEV_RAM_COUNT=16 +CONFIG_BLK_DEV_RAM_SIZE=65536 Signed-off-by: Eric Miao <eric.miao@canonical.com>