| Message ID | 20100321215222.GA27709@Chamillionaire.breakpoint.cc |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
* Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]: >page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here >with the according debuging turned on. David, I've seen that you set this patch to "Not Applicable". May I know why? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Date: Mon, 19 Apr 2010 21:46:18 +0200 > * Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]: > >>page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here >>with the according debuging turned on. > > David, I've seen that you set this patch to "Not Applicable". May I know > why? Because the linux-ide patchwork is for IDE patches, not ATA stuff. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]: >page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here >with the according debuging turned on. > >Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Jeff, a month passed since I posted this patch. Any reason why you ignore it? > drivers/ata/libata-sff.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c >index 561dec2..83ecf48 100644 >--- a/drivers/ata/libata-sff.c >+++ b/drivers/ata/libata-sff.c >@@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) > do_write); > } > >- if (!do_write) >+ if (!do_write && !PageSlab(page)) > flush_dcache_page(page); > > qc->curbytes += qc->sect_size; >-- >1.6.6 Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/28/2010 04:06 PM, Sebastian Andrzej Siewior wrote: > * Sebastian Andrzej Siewior | 2010-03-21 22:52:22 [+0100]: > >> page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here >> with the according debuging turned on. >> >> Signed-off-by: Sebastian Andrzej Siewior<sebastian@breakpoint.cc> > > Jeff, a month passed since I posted this patch. Any reason why you > ignore it? Typically I wait a couple weeks for the Architecture maintainers to voice their objections, if any, on a patch like this. No objections emerged that weren't addressed so far, we can probably push this in. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/21/2010 05:52 PM, Sebastian Andrzej Siewior wrote: > page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here > with the according debuging turned on. > > Signed-off-by: Sebastian Andrzej Siewior<sebastian@breakpoint.cc> > --- > drivers/ata/libata-sff.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c > index 561dec2..83ecf48 100644 > --- a/drivers/ata/libata-sff.c > +++ b/drivers/ata/libata-sff.c > @@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) > do_write); > } > > - if (!do_write) > + if (!do_write&& !PageSlab(page)) > flush_dcache_page(page); applied #upstream, cc'ing stable@kernel.org -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 561dec2..83ecf48 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -893,7 +893,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) do_write); } - if (!do_write) + if (!do_write && !PageSlab(page)) flush_dcache_page(page); qc->curbytes += qc->sect_size;
page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here with the according debuging turned on. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> --- drivers/ata/libata-sff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)