| Message ID | 1446739355-25849-1-git-send-email-clabbe.montjoie@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Nov 6, 2015 at 1:02 AM, LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 199: > priv->flags = of_id->data; > > Reported-by: coverity (CID 1324140) > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> Same (optional) suggestion as the 74xx-mmio patch. Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 5, 2015 at 5:02 PM, LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 199: > priv->flags = of_id->data; > > Reported-by: coverity (CID 1324140) > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> Patch applied with Alexandre's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 045a952..e673c58 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -192,6 +192,9 @@ static int syscon_gpio_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; int ret; + if (!of_id) + return -ENODEV; + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM;
of_match_device could return NULL, and so cause a NULL pointer dereference later at line 199: priv->flags = of_id->data; Reported-by: coverity (CID 1324140) Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/gpio/gpio-syscon.c | 3 +++ 1 file changed, 3 insertions(+)