diff mbox

gpio: fix platform_no_drv_owner.cocci warnings

Message ID 20151007031413.GA12931@roam
State New
Headers show

Commit Message

kernel test robot Oct. 7, 2015, 3:14 a.m. UTC
drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 gpio-104-idio-16.c |    1 -
 1 file changed, 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Linus Walleij Oct. 16, 2015, 2:47 p.m. UTC | #1
On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <lkp@intel.com> wrote:

> drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
>
>  Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: William Breathitt Gray <vilhelm.gray@gmail.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

This is confusing, I mix up the mails coming from my pushed git branches
with this new stuff that is obviously checking patches I haven't even applied.
It's better if these kbuild fixes are sent as Re: to the mail ID of the
patch so it appears in the same thread as the offending patch on the
mailing list.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kernel test robot Oct. 16, 2015, 3:47 p.m. UTC | #2
On Fri, Oct 16, 2015 at 04:47:23PM +0200, Linus Walleij wrote:
> On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <lkp@intel.com> wrote:
> 
> > drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
> >
> >  Remove .owner field if calls are used which set it automatically
> >
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> >
> > CC: William Breathitt Gray <vilhelm.gray@gmail.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> This is confusing, I mix up the mails coming from my pushed git branches
> with this new stuff that is obviously checking patches I haven't even applied.
> It's better if these kbuild fixes are sent as Re: to the mail ID of the
> patch so it appears in the same thread as the offending patch on the
> mailing list.

Hi Linus, the patch email does not start with "Re:", however it does contain

        In-Reply-To: <1444997709-57293-2-git-send-email-ck.hu@mediatek.com>

So it should show up in the same thread as this email?

        [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kernel test robot Oct. 16, 2015, 3:53 p.m. UTC | #3
On Fri, Oct 16, 2015 at 11:47:23PM +0800, Fengguang Wu wrote:
> On Fri, Oct 16, 2015 at 04:47:23PM +0200, Linus Walleij wrote:
> > On Wed, Oct 7, 2015 at 5:14 AM, kbuild test robot <lkp@intel.com> wrote:
> > 
> > > drivers/gpio/gpio-104-idio-16.c:151:3-8: No need to set .owner here. The core will do it.
> > >
> > >  Remove .owner field if calls are used which set it automatically
> > >
> > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > >
> > > CC: William Breathitt Gray <vilhelm.gray@gmail.com>
> > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > 
> > This is confusing, I mix up the mails coming from my pushed git branches
> > with this new stuff that is obviously checking patches I haven't even applied.
> > It's better if these kbuild fixes are sent as Re: to the mail ID of the
> > patch so it appears in the same thread as the offending patch on the
> > mailing list.
> 
> Hi Linus, the patch email does not start with "Re:", however it does contain
> 
>         In-Reply-To: <1444997709-57293-2-git-send-email-ck.hu@mediatek.com>
> 
> So it should show up in the same thread as this email?
> 
>         [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Sorry it's not that email, but here is the mutt thread view in my mbox:

 Oct 06 William Breathi (7.8K:0) [PATCH v4] gpio: Add GPIO support for the ACCES 104-IDIO-16
 Oct 07 kbuild test rob (0.9K:0) |->[PATCH] gpio: fix platform_no_drv_owner.cocci warnings
 Oct 16 Fengguang Wu    (1.3K:0) | `->Re: [kbuild-all] [PATCH] gpio: fix platform_no_drv_owner.cocci warnings
 Oct 07 kbuild test rob (0.7K:0) `->Re: [PATCH v4] gpio: Add GPIO support for the ACCES 104-IDIO-16

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/gpio/gpio-104-idio-16.c
+++ b/drivers/gpio/gpio-104-idio-16.c
@@ -148,7 +148,6 @@  static struct platform_device *a_104_idi
 static struct platform_driver a_104_idio_16_driver = {
 	.driver = {
 		.name = "104-idio-16",
-		.owner = THIS_MODULE
 	},
 	.remove = a_104_idio_16_remove
 };