[ovs-dev] vtep: Make stats and status columns ephemeral.

These fields don't need to be stored, and it causes a lot of unnecessary
writes to the database log.

This commit also fixes a couple of trivial indentation issues with
previous ephemeral declarations.

Signed-off-by: Justin Pettit <jpettit@nicria.com>
---
 vtep/vtep.ovsschema |   22 ++++++++++++----------
 1 files changed, 12 insertions(+), 10 deletions(-)

On Tue, Oct 13, 2015 at 04:58:42PM -0700, Justin Pettit wrote:
> These fields don't need to be stored, and it causes a lot of unnecessary
> writes to the database log.
> 
> This commit also fixes a couple of trivial indentation issues with
> previous ephemeral declarations.
> 
> Signed-off-by: Justin Pettit <jpettit@nicria.com>

Should we run this by anyone else?

Acked-by: Ben Pfaff <blp@nicira.com>

On Tue, Oct 13, 2015 at 04:58:42PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit@nicria.com>

Your Signed-off-by is wrong.

> On Oct 13, 2015, at 5:25 PM, Ben Pfaff <blp@nicira.com> wrote:
> 
> On Tue, Oct 13, 2015 at 04:58:42PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit@nicria.com>
> 
> Your Signed-off-by is wrong.

Yeah, I noticed that after I sent it.  I fixed it.

--Justin

> On Oct 13, 2015, at 5:24 PM, Ben Pfaff <blp@nicira.com> wrote:
> 
> On Tue, Oct 13, 2015 at 04:58:42PM -0700, Justin Pettit wrote:
>> These fields don't need to be stored, and it causes a lot of unnecessary
>> writes to the database log.
>> 
>> This commit also fixes a couple of trivial indentation issues with
>> previous ephemeral declarations.
>> 
>> Signed-off-by: Justin Pettit <jpettit@nicria.com>
> 
> Should we run this by anyone else?
> 
> Acked-by: Ben Pfaff <blp@nicira.com>

Thanks.  I also sent this to Bruce, so i'd just like to get his okay, too.

--Justin

I'm happy with this.

Bruce

> On Oct 14, 2015, at 1:59 AM, Justin Pettit <jpettit@nicira.com> wrote:
> 
> These fields don't need to be stored, and it causes a lot of unnecessary
> writes to the database log.
> 
> This commit also fixes a couple of trivial indentation issues with
> previous ephemeral declarations.
> 
> Signed-off-by: Justin Pettit <jpettit@nicria.com>
> ---
> vtep/vtep.ovsschema |   22 ++++++++++++----------
> 1 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/vtep/vtep.ovsschema b/vtep/vtep.ovsschema
> index c01eb77..1375173 100644
> --- a/vtep/vtep.ovsschema
> +++ b/vtep/vtep.ovsschema
> @@ -1,6 +1,6 @@
> {
>   "name": "hardware_vtep",
> -  "cksum": "262972511 10369",
> +  "cksum": "2177247725 10499",
>   "tables": {
>     "Global": {
>       "columns": {
> @@ -52,7 +52,8 @@
>                            "minInteger": 0, "maxInteger": 4095},
>                    "value": {"type": "uuid",
>                              "refTable": "Logical_Binding_Stats"},
> -                   "min": 0, "max": "unlimited"}},
> +                   "min": 0, "max": "unlimited"},
> +          "ephemeral": true},
>         "port_fault_status": {
>           "type": {
>             "key": "string", "min": 0, "max": "unlimited"},
> @@ -76,13 +77,14 @@
>               "min": 0, "max": "unlimited"}},
>         "bfd_status": {
>           "type": {"key": "string", "value": "string",
> -              "min": 0, "max": "unlimited"}}}},
> +              "min": 0, "max": "unlimited"},
> +          "ephemeral": true}}},
>     "Logical_Binding_Stats": {
>       "columns": {
> -        "bytes_from_local": {"type": "integer"},
> -        "packets_from_local": {"type": "integer"},
> -        "bytes_to_local": {"type": "integer"},
> -        "packets_to_local": {"type": "integer"}}},
> +        "bytes_from_local": {"type": "integer", "ephemeral": true},
> +        "packets_from_local": {"type": "integer", "ephemeral": true},
> +        "bytes_to_local": {"type": "integer", "ephemeral": true},
> +        "packets_to_local": {"type": "integer", "ephemeral": true}}},
>     "Logical_Switch": {
>       "columns": {
>         "name": {"type": "string"},
> @@ -248,7 +250,7 @@
>         "acle_fault_status": {
>           "type": {
>             "key": "string", "min": 0, "max": "unlimited"},
> -            "ephemeral": true}},
> +          "ephemeral": true}},
>        "isRoot": true},
>     "ACL": {
>       "columns": {
> @@ -259,7 +261,7 @@
>         "acl_fault_status": {
>           "type": {
>             "key": "string", "min": 0, "max": "unlimited"},
> -            "ephemeral": true}},
> +          "ephemeral": true}},
>       "indexes": [["acl_name"]],
>       "isRoot": true},
>     "Manager": {
> @@ -281,4 +283,4 @@
>           "ephemeral": true}},
>       "indexes": [["target"]],
>       "isRoot": false}},
> -  "version": "1.4.0"}
> +  "version": "1.4.1"}
> -- 
> 1.7.5.4
>

> On Oct 14, 2015, at 1:06 AM, Bruce Davie <bdavie@vmware.com> wrote:
> 
> I'm happy with this.

Thank you.  I'll push this with Ben's ack in just a minute.

--Justin