Message ID | 1268828189-22182-1-git-send-email-lennart.schulte@nets.rwth-aachen.de |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de> Date: Wed, 17 Mar 2010 13:16:29 +0100 > A packet is marked as lost in case packets == 0, although nothing should be done. > This results in a too early retransmitted packet during recovery in some cases. > This small patch fixes this issue by returning immediately. > > Signed-off-by: Lennart Schulte <lennart.schulte@nets.rwth-aachen.de> > Signed-off-by: Arnd Hannemann <hannemann@nets.rwth-aachen.de> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 788851c..c096a42 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2511,6 +2511,9 @@ static void tcp_mark_head_lost(struct sock *sk, int packets) int err; unsigned int mss; + if (packets == 0) + return; + WARN_ON(packets > tp->packets_out); if (tp->lost_skb_hint) { skb = tp->lost_skb_hint;