| Message ID | 1268337450-6749-2-git-send-email-jengelh@medozas.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 11 Mar 2010 20:57:27 +0100 Jan Engelhardt <jengelh@medozas.de> wrote: > Signed-off-by: Jan Engelhardt <jengelh@medozas.de> > --- > net/ipv4/Kconfig | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig > index 0c94a1a..731c47b 100644 > --- a/net/ipv4/Kconfig > +++ b/net/ipv4/Kconfig > @@ -587,6 +587,9 @@ choice > config DEFAULT_HTCP > bool "Htcp" if TCP_CONG_HTCP=y > > + config DEFAULT_HYBLA > + bool "Hybla" if TCP_CONG_HYBLA=y > + > config DEFAULT_VEGAS > bool "Vegas" if TCP_CONG_VEGAS=y > > @@ -610,6 +613,7 @@ config DEFAULT_TCP_CONG > default "bic" if DEFAULT_BIC > default "cubic" if DEFAULT_CUBIC > default "htcp" if DEFAULT_HTCP > + default "hybla" if DEFAULT_HYBLA > default "vegas" if DEFAULT_VEGAS > default "westwood" if DEFAULT_WESTWOOD > default "reno" if DEFAULT_RENO Hybla seems too experimental to be made default. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 2010-03-11 21:10, Stephen Hemminger wrote: >> >> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig >> index 0c94a1a..731c47b 100644 >> --- a/net/ipv4/Kconfig >> +++ b/net/ipv4/Kconfig >> @@ -587,6 +587,9 @@ choice >> config DEFAULT_HTCP >> bool "Htcp" if TCP_CONG_HTCP=y >> >> + config DEFAULT_HYBLA >> + bool "Hybla" if TCP_CONG_HYBLA=y >> + >> config DEFAULT_VEGAS >> bool "Vegas" if TCP_CONG_VEGAS=y >> >> @@ -610,6 +613,7 @@ config DEFAULT_TCP_CONG >> default "bic" if DEFAULT_BIC >> default "cubic" if DEFAULT_CUBIC >> default "htcp" if DEFAULT_HTCP >> + default "hybla" if DEFAULT_HYBLA >> default "vegas" if DEFAULT_VEGAS >> default "westwood" if DEFAULT_WESTWOOD >> default "reno" if DEFAULT_RENO > >Hybla seems too experimental to be made default. I run Hybla since 2006 on anything that is not connected via wireless and I did not notice any pressing issues. Also, the patch does not make hybla the default default (reno remains), just the default once explicitly selected in a two-step process: 1. CONFIG_TCP_CONG_HYBLA=y *and* 2. choosing Hybla in CONFIG_DEFAULT_TCP_CONG I think that is enough of a "safety measure" against any potential unsuspecting users. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jan Engelhardt <jengelh@medozas.de> Date: Thu, 11 Mar 2010 20:57:27 +0100 > Signed-off-by: Jan Engelhardt <jengelh@medozas.de> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 0c94a1a..731c47b 100644 --- a/net/ipv4/Kconfig +++ b/net/ipv4/Kconfig @@ -587,6 +587,9 @@ choice config DEFAULT_HTCP bool "Htcp" if TCP_CONG_HTCP=y + config DEFAULT_HYBLA + bool "Hybla" if TCP_CONG_HYBLA=y + config DEFAULT_VEGAS bool "Vegas" if TCP_CONG_VEGAS=y @@ -610,6 +613,7 @@ config DEFAULT_TCP_CONG default "bic" if DEFAULT_BIC default "cubic" if DEFAULT_CUBIC default "htcp" if DEFAULT_HTCP + default "hybla" if DEFAULT_HYBLA default "vegas" if DEFAULT_VEGAS default "westwood" if DEFAULT_WESTWOOD default "reno" if DEFAULT_RENO
Signed-off-by: Jan Engelhardt <jengelh@medozas.de> --- net/ipv4/Kconfig | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)