Message ID | 1442333283-13119-38-git-send-email-marcandre.lureau@redhat.com |
---|---|
State | New |
Headers | show |
On 15.09.2015 19:07, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > getopt() optarg points to argv memory, no need to dup those values, > fixes small leaks detected by clang-analyzer. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > contrib/ivshmem-client/main.c | 2 +- > contrib/ivshmem-server/main.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c > index 5d85ae7..bd7cbfc 100644 > --- a/contrib/ivshmem-client/main.c > +++ b/contrib/ivshmem-client/main.c > @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, char *argv[]) > break; > > case 'S': /* unix_sock_path */ > - args->unix_sock_path = strdup(optarg); > + args->unix_sock_path = optarg; > break; > > default: > diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c > index cd8d9ed..71e87ea 100644 > --- a/contrib/ivshmem-server/main.c > +++ b/contrib/ivshmem-server/main.c > @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[]) > break; > > case 'p': /* pid_file */ > - args->pid_file = strdup(optarg); > + args->pid_file = optarg; > break; > > case 'S': /* unix_socket_path */ > - args->unix_socket_path = strdup(optarg); > + args->unix_socket_path = optarg; > break; > > case 'm': /* shm_path */ > - args->shm_path = strdup(optarg); > + args->shm_path = optarg; > break; > > case 'l': /* shm_size */ Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c index 5d85ae7..bd7cbfc 100644 --- a/contrib/ivshmem-client/main.c +++ b/contrib/ivshmem-client/main.c @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, char *argv[]) break; case 'S': /* unix_sock_path */ - args->unix_sock_path = strdup(optarg); + args->unix_sock_path = optarg; break; default: diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index cd8d9ed..71e87ea 100644 --- a/contrib/ivshmem-server/main.c +++ b/contrib/ivshmem-server/main.c @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[]) break; case 'p': /* pid_file */ - args->pid_file = strdup(optarg); + args->pid_file = optarg; break; case 'S': /* unix_socket_path */ - args->unix_socket_path = strdup(optarg); + args->unix_socket_path = optarg; break; case 'm': /* shm_path */ - args->shm_path = strdup(optarg); + args->shm_path = optarg; break; case 'l': /* shm_size */