Message ID | 1440107676-17326-3-git-send-email-ehabkost@redhat.com |
---|---|
State | New |
Headers | show |
On Thu, Aug 20, 2015 at 02:54:28PM -0700, Eduardo Habkost wrote: > The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as > it is an abstract class and the machine class lookup code explicitly > skips abstract classes. We can remove it to make the code simpler. > > Cc: Peter Maydell <peter.maydell@linaro.org> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index da21788..15e4ae9 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -747,7 +747,6 @@ static void vexpress_class_init(ObjectClass *oc, void *data) { MachineClass *mc = MACHINE_CLASS(oc); - mc->name = TYPE_VEXPRESS_MACHINE; mc->desc = "ARM Versatile Express"; mc->init = vexpress_common_init; mc->block_default_type = IF_SCSI;
The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as it is an abstract class and the machine class lookup code explicitly skips abstract classes. We can remove it to make the code simpler. Cc: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- hw/arm/vexpress.c | 1 - 1 file changed, 1 deletion(-)