| Message ID | 6a4b170b1003030355p44dd277fpedae0da7a76ed739@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
[James] > The else part of the if statement is indented but does not have braces > around it. It clearly should since it uses clk_enable and clk_disable > which are supposed to balance. > > Signed-off-by: James Hogan <james@albanarts.com> OMG, thanks for spotting this! Acked-by: Linus Walleij <linus.walleij@stericsson.com> Yours, Linus Walleij
On Wed, 3 Mar 2010 11:55:15 +0000 James Hogan <james@albanarts.com> wrote: > The else part of the if statement is indented but does not have braces > around it. It clearly should since it uses clk_enable and clk_disable > which are supposed to balance. > > Signed-off-by: James Hogan <james@albanarts.com> Acked-by: Alessandro Zummo <a.zummo@towertech.it>
diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c index 03ea530..44c4399 100644 --- a/drivers/rtc/rtc-coh901331.c +++ b/drivers/rtc/rtc-coh901331.c @@ -271,12 +271,13 @@ static int coh901331_resume(struct platform_device *pdev) { struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev); - if (device_may_wakeup(&pdev->dev)) + if (device_may_wakeup(&pdev->dev)) { disable_irq_wake(rtap->irq); - else + } else { clk_enable(rtap->clk); writel(rtap->irqmaskstore, rtap->virtbase + COH901331_IRQ_MASK); clk_disable(rtap->clk); + } return 0; } #else
The else part of the if statement is indented but does not have braces around it. It clearly should since it uses clk_enable and clk_disable which are supposed to balance. Signed-off-by: James Hogan <james@albanarts.com> --- drivers/rtc/rtc-coh901331.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)