diff mbox

MAINTAINERS: Add Samuel Thibault as slirp maintainer

Message ID 20150729093326.GG2979@type.bordeaux.inria.fr
State New
Headers show

Commit Message

Samuel Thibault July 29, 2015, 9:33 a.m. UTC 
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

---
Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> On 2015-07-29 00:12, Samuel Thibault wrote:
> > Hello,
> > 
> > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> >> Of course, I'm fine with handing this over to someone who'd like to
> >> pick up. Do we have volunteers?
> >>
> >> Samuel, would you like to do this? As a subsystem maintainer, you are
> >> already familiar with QEMU processes.
> > 
> > I can help with maintenance, yes.
> 
> "Help with" will easily mean "be the one and only". ;)

Right, I understand that :) That's still preferable to have two contact
people.

Comments

Stefan Hajnoczi Aug. 6, 2015, 10:10 a.m. UTC | #1 
On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> ---
> Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> > On 2015-07-29 00:12, Samuel Thibault wrote:
> > > Hello,
> > > 
> > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> > >> Of course, I'm fine with handing this over to someone who'd like to
> > >> pick up. Do we have volunteers?
> > >>
> > >> Samuel, would you like to do this? As a subsystem maintainer, you are
> > >> already familiar with QEMU processes.
> > > 
> > > I can help with maintenance, yes.
> > 
> > "Help with" will easily mean "be the one and only". ;)
> 
> Right, I understand that :) That's still preferable to have two contact
> people.
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 978b717..b506df5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1018,6 +1018,7 @@ F: scripts/qmp/
>  T: git git://repo.or.cz/qemu/armbru.git qapi-next
>  
>  SLIRP
> +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
>  M: Jan Kiszka <jan.kiszka@siemens.com>
>  S: Maintained
>  F: slirp/

Please resend as a top-level email.

If you send patches as a reply to a thread they are easy to miss.

Stefan
Fam Zheng Aug. 6, 2015, 12:29 p.m. UTC | #2 
On Thu, 08/06 11:10, Stefan Hajnoczi wrote:
> On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > 
> > ---
> > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> > > On 2015-07-29 00:12, Samuel Thibault wrote:
> > > > Hello,
> > > > 
> > > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> > > >> Of course, I'm fine with handing this over to someone who'd like to
> > > >> pick up. Do we have volunteers?
> > > >>
> > > >> Samuel, would you like to do this? As a subsystem maintainer, you are
> > > >> already familiar with QEMU processes.
> > > > 
> > > > I can help with maintenance, yes.
> > > 
> > > "Help with" will easily mean "be the one and only". ;)
> > 
> > Right, I understand that :) That's still preferable to have two contact
> > people.
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 978b717..b506df5 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1018,6 +1018,7 @@ F: scripts/qmp/
> >  T: git git://repo.or.cz/qemu/armbru.git qapi-next
> >  
> >  SLIRP
> > +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >  M: Jan Kiszka <jan.kiszka@siemens.com>
> >  S: Maintained
> >  F: slirp/
> 
> Please resend as a top-level email.

This email has proper subject, sign-off line and patch format, and the header
doesn't have "In-reply-to". So it makes a legit patch. The quotes are below the
"---" line so it should be read as complementary information and I think it is
totally fine. At least patchew treats it so :)

http://qemu.patchew.org/series/%3C20150806111014.GA6432%40type.bordeaux.inria.fr%3E

Therefore,

Reviewed-by: Fam Zheng <famz@redhat.com>
Stefan Hajnoczi Aug. 7, 2015, 10:19 a.m. UTC | #3 
On Thu, Aug 6, 2015 at 1:29 PM, Fam Zheng <famz@redhat.com> wrote:
> On Thu, 08/06 11:10, Stefan Hajnoczi wrote:
>> On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
>> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> >
>> > ---
>> > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
>> > > On 2015-07-29 00:12, Samuel Thibault wrote:
>> > > > Hello,
>> > > >
>> > > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
>> > > >> Of course, I'm fine with handing this over to someone who'd like to
>> > > >> pick up. Do we have volunteers?
>> > > >>
>> > > >> Samuel, would you like to do this? As a subsystem maintainer, you are
>> > > >> already familiar with QEMU processes.
>> > > >
>> > > > I can help with maintenance, yes.
>> > >
>> > > "Help with" will easily mean "be the one and only". ;)
>> >
>> > Right, I understand that :) That's still preferable to have two contact
>> > people.
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 978b717..b506df5 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1018,6 +1018,7 @@ F: scripts/qmp/
>> >  T: git git://repo.or.cz/qemu/armbru.git qapi-next
>> >
>> >  SLIRP
>> > +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> >  M: Jan Kiszka <jan.kiszka@siemens.com>
>> >  S: Maintained
>> >  F: slirp/
>>
>> Please resend as a top-level email.
>
> This email has proper subject, sign-off line and patch format, and the header
> doesn't have "In-reply-to".

It is definitely a reply rather than a top-level post.  Here is what
the headers look like here:

Delivered-To: stefanha@gmail.com
Date: Wed, 29 Jul 2015 11:33:26 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
To: qemu-devel <qemu-devel@nongnu.org>
Message-ID: <20150729093326.GG2979@type.bordeaux.inria.fr>
References: <20150720103208.GA12675@stefanha-thinkpad.redhat.com>
<55ACE1B4.4010109@huawei.com>
<CACaajQsMGGuxTrOYb0AYF_Vv7kzOztn_Phi4TEKtfWPEEkfRyg@mail.gmail.com>
<CAJSP0QWw8SyENL=eMpFstxr9kG038CVs5GKY3qZ+V1foxDmykg@mail.gmail.com>
<55ADE316.1060704@siemens.com>
<20150721094929.GD13993@stefanha-thinkpad.redhat.com>
<20150727101305.GD30018@stefanha-thinkpad.redhat.com>
<55B63327.5080205@siemens.com> <20150728221234.GI3467@type.home>
<55B8826F.1090305@siemens.com>
In-Reply-To: <55B8826F.1090305@siemens.com>
Subject: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp
maintainer
...
Fam Zheng Aug. 7, 2015, 10:34 a.m. UTC | #4 
On Fri, 08/07 11:19, Stefan Hajnoczi wrote:
> It is definitely a reply rather than a top-level post.  Here is what
> the headers look like here:
> 
> Delivered-To: stefanha@gmail.com
> Date: Wed, 29 Jul 2015 11:33:26 +0200
> From: Samuel Thibault <samuel.thibault@gnu.org>
> To: qemu-devel <qemu-devel@nongnu.org>
> Message-ID: <20150729093326.GG2979@type.bordeaux.inria.fr>
> References: <20150720103208.GA12675@stefanha-thinkpad.redhat.com>
> <55ACE1B4.4010109@huawei.com>
> <CACaajQsMGGuxTrOYb0AYF_Vv7kzOztn_Phi4TEKtfWPEEkfRyg@mail.gmail.com>
> <CAJSP0QWw8SyENL=eMpFstxr9kG038CVs5GKY3qZ+V1foxDmykg@mail.gmail.com>
> <55ADE316.1060704@siemens.com>
> <20150721094929.GD13993@stefanha-thinkpad.redhat.com>
> <20150727101305.GD30018@stefanha-thinkpad.redhat.com>
> <55B63327.5080205@siemens.com> <20150728221234.GI3467@type.home>
> <55B8826F.1090305@siemens.com>
> In-Reply-To: <55B8826F.1090305@siemens.com>
> Subject: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp
> maintainer
> ...
> 

Oh you're right! I misread it and my email client displayed as a top level post
too, no idea why...

Fam
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 978b717..b506df5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1018,6 +1018,7 @@  F: scripts/qmp/
 T: git git://repo.or.cz/qemu/armbru.git qapi-next
 
 SLIRP
+M: Samuel Thibault <samuel.thibault@ens-lyon.org>
 M: Jan Kiszka <jan.kiszka@siemens.com>
 S: Maintained
 F: slirp/