| Message ID | 1436365498-25890-1-git-send-email-horia.geanta@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
Acked-by: Ruchika Gupta<ruchika.gupta@freescale.com> > -----Original Message----- > From: Sun York-R58495 > Sent: Sunday, July 19, 2015 3:44 AM > To: Gupta Ruchika-R66431 > Subject: Re: [PATCH 1/3] crypto/fsl: fix "era" property value on LE platforms > > Ruchika, > > Please comment/ack. > > York > > On 07/08/2015 07:24 AM, Horia Geantă wrote: > > Use fdt_setprop_u32() instead of fdt_setprop(). > > > > Fixes: 0181937fa371a ("crypto/fsl: Add fixup for crypto node") > > Signed-off-by: Horia Geantă <horia.geanta@freescale.com> > > Reviewed-by: Mingkai Hu <Mingkai.Hu@freescale.com> > > --- > > drivers/crypto/fsl/sec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/crypto/fsl/sec.c b/drivers/crypto/fsl/sec.c index > > 443ee964feae..b25b1a4052d2 100644 > > --- a/drivers/crypto/fsl/sec.c > > +++ b/drivers/crypto/fsl/sec.c > > @@ -155,8 +155,7 @@ static void fdt_fixup_crypto_era(void *blob, u32 > era) > > return; > > } > > > > - err = fdt_setprop(blob, crypto_node, "fsl,sec-era", &era, > > - sizeof(era)); > > + err = fdt_setprop_u32(blob, crypto_node, "fsl,sec-era", era); > > if (err < 0) { > > printf("ERROR: could not set fsl,sec-era property: %s\n", > > fdt_strerror(err)); > >
On 07/08/2015 07:24 AM, Horia Geantă wrote: > Use fdt_setprop_u32() instead of fdt_setprop(). > > Fixes: 0181937fa371a ("crypto/fsl: Add fixup for crypto node") > Signed-off-by: Horia Geantă <horia.geanta@freescale.com> > Reviewed-by: Mingkai Hu <Mingkai.Hu@freescale.com> > --- Applied to u-boot-fsl-qoriq master with minor change in subject. Thanks. York
diff --git a/drivers/crypto/fsl/sec.c b/drivers/crypto/fsl/sec.c index 443ee964feae..b25b1a4052d2 100644 --- a/drivers/crypto/fsl/sec.c +++ b/drivers/crypto/fsl/sec.c @@ -155,8 +155,7 @@ static void fdt_fixup_crypto_era(void *blob, u32 era) return; } - err = fdt_setprop(blob, crypto_node, "fsl,sec-era", &era, - sizeof(era)); + err = fdt_setprop_u32(blob, crypto_node, "fsl,sec-era", era); if (err < 0) { printf("ERROR: could not set fsl,sec-era property: %s\n", fdt_strerror(err));
Use fdt_setprop_u32() instead of fdt_setprop(). Fixes: 0181937fa371a ("crypto/fsl: Add fixup for crypto node") Signed-off-by: Horia Geantă <horia.geanta@freescale.com> Reviewed-by: Mingkai Hu <Mingkai.Hu@freescale.com> --- drivers/crypto/fsl/sec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)