diff mbox

[1/2] mtd-utils: fs-tests: pass TEST_DIR to integck in run_all.sh

Message ID 1435567759-32518-1-git-send-email-yangds.fnst@cn.fujitsu.com
State Accepted
Headers show

Commit Message

Dongsheng Yang June 29, 2015, 8:49 a.m. UTC
Test integck requires a parameter but run_all.sh did no pass any to it.
Then:
integck: error!: test file-system was not specified (use -h for help)

Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
 tests/fs-tests/run_all.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger June 30, 2015, 7:33 a.m. UTC | #1
Am 29.06.2015 um 10:49 schrieb Dongsheng Yang:
> Test integck requires a parameter but run_all.sh did no pass any to it.
> Then:
> integck: error!: test file-system was not specified (use -h for help)
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
>  tests/fs-tests/run_all.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fs-tests/run_all.sh b/tests/fs-tests/run_all.sh
> index 7c82921..cb481ab 100755
> --- a/tests/fs-tests/run_all.sh
> +++ b/tests/fs-tests/run_all.sh
> @@ -16,7 +16,7 @@ rm -rf ${TEST_DIR}/*
>  
>  rm -rf ${TEST_DIR}/*
>  
> -./integrity/integck || exit 1
> +./integrity/integck $TEST_DIR|| exit 1

Hmm, so, run_all.sh never worked as expected?
TBH I run integck always by hand, so at least I have never noticed.

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard
Brian Norris July 6, 2015, 9:42 p.m. UTC | #2
On Mon, Jun 29, 2015 at 04:49:18PM +0800, Dongsheng Yang wrote:
> Test integck requires a parameter but run_all.sh did no pass any to it.
> Then:
> integck: error!: test file-system was not specified (use -h for help)
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
>  tests/fs-tests/run_all.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fs-tests/run_all.sh b/tests/fs-tests/run_all.sh
> index 7c82921..cb481ab 100755
> --- a/tests/fs-tests/run_all.sh
> +++ b/tests/fs-tests/run_all.sh
> @@ -16,7 +16,7 @@ rm -rf ${TEST_DIR}/*
>  
>  rm -rf ${TEST_DIR}/*
>  
> -./integrity/integck || exit 1
> +./integrity/integck $TEST_DIR|| exit 1

Applied, with a whitespace fixup. Thanks.

>  
>  rm -rf ${TEST_DIR}/*
>  
> -- 
> 1.8.4.2
>
diff mbox

Patch

diff --git a/tests/fs-tests/run_all.sh b/tests/fs-tests/run_all.sh
index 7c82921..cb481ab 100755
--- a/tests/fs-tests/run_all.sh
+++ b/tests/fs-tests/run_all.sh
@@ -16,7 +16,7 @@  rm -rf ${TEST_DIR}/*
 
 rm -rf ${TEST_DIR}/*
 
-./integrity/integck || exit 1
+./integrity/integck $TEST_DIR|| exit 1
 
 rm -rf ${TEST_DIR}/*