| Message ID | 1263541814-6642-1-git-send-email-21cnbao@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2010-01-15 at 15:50 +0800, Barry Song wrote: > Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe > kernel XIP, not like arm which uses XIP_KERNEL Surely the appropriate response to that realisation is to _fix_ the inconsistency, not just work around it?
On Fri, Jan 15, 2010 at 05:29, David Woodhouse wrote: > On Fri, 2010-01-15 at 15:50 +0800, Barry Song wrote: >> Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe >> kernel XIP, not like arm which uses XIP_KERNEL > > Surely the appropriate response to that realisation is to _fix_ the > inconsistency, not just work around it? agree, but this is a lot easier than trying to tell RMK to change all the ARM references ;) this is the only place outside of the respective arch/$ARCH/ where either XIP_KERNEL or ROMKERNEL is utilized ... -mike
On Fri, Jan 15, 2010 at 6:34 PM, Mike Frysinger <vapier.adi@gmail.com> wrote: > On Fri, Jan 15, 2010 at 05:29, David Woodhouse wrote: >> On Fri, 2010-01-15 at 15:50 +0800, Barry Song wrote: >>> Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe >>> kernel XIP, not like arm which uses XIP_KERNEL >> >> Surely the appropriate response to that realisation is to _fix_ the >> inconsistency, not just work around it? > > agree, but this is a lot easier than trying to tell RMK to change all > the ARM references ;) Yes. It will be really difficult to ask the related architectures to change. > > this is the only place outside of the respective arch/$ARCH/ where > either XIP_KERNEL or ROMKERNEL is utilized ... > -mike >
On Fri, 2010-01-15 at 15:50 +0800, Barry Song wrote: > Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe > kernel XIP, not like arm which uses XIP_KERNEL > > Signed-off-by: Barry Song <21cnbao@gmail.com> I've pushed these 2 patches to my l2-mtd-2.6 / dunno
On Tue, Feb 2, 2010 at 1:48 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > On Fri, 2010-01-15 at 15:50 +0800, Barry Song wrote: >> Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe >> kernel XIP, not like arm which uses XIP_KERNEL >> >> Signed-off-by: Barry Song <21cnbao@gmail.com> > > I've pushed these 2 patches to my l2-mtd-2.6 / dunno Will they be merged into mainline? I have found them in Linus's tree yet. > > -- > Best Regards, > Artem Bityutskiy (Артём Битюцкий) > >
diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig index 35c6a23..6c39451 100644 --- a/drivers/mtd/chips/Kconfig +++ b/drivers/mtd/chips/Kconfig @@ -233,7 +233,7 @@ config MTD_ABSENT config MTD_XIP bool "XIP aware MTD support" depends on !SMP && (MTD_CFI_INTELEXT || MTD_CFI_AMDSTD) && EXPERIMENTAL && ARCH_MTD_XIP - default y if XIP_KERNEL + default y if (XIP_KERNEL || ROMKERNEL) help This allows MTD support to work with flash memory which is also used for XIP purposes. If you're not sure what this is all about
Some architectures like blackfin,h8300,m68k use ROMKERNEL to describe kernel XIP, not like arm which uses XIP_KERNEL Signed-off-by: Barry Song <21cnbao@gmail.com> --- drivers/mtd/chips/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)