| Message ID | 1434099170-19778-1-git-send-email-pieter.degendt@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Pieter De Gendt, Please extend the commit log, especially to explain why you're adding a host variant for the neon package. On Fri, 12 Jun 2015 10:52:50 +0200, Pieter De Gendt wrote: > diff --git a/package/libmusicbrainz/libmusicbrainz.mk b/package/libmusicbrainz/libmusicbrainz.mk > new file mode 100644 > index 0000000..a199f34 > --- /dev/null > +++ b/package/libmusicbrainz/libmusicbrainz.mk > @@ -0,0 +1,16 @@ > +################################################################################ > +# > +# libmusicbrainz > +# > +################################################################################ > + > +LIBMUSICBRAINZ_VERSION = release-5.1.0 > +LIBMUSICBRAINZ_SITE = $(call github,metabrainz,libmusicbrainz,$(LIBMUSICBRAINZ_VERSION)) > +LIBMUSICBRAINZ_INSTALL_STAGING = YES Missing LICENSE + LICENSE_FILES. > +LIBMUSICBRAINZ_DEPENDENCIES = libxml2 neon host-pkgconf host-libmusicbrainz > + > +LIBMUSICBRAINZ_CONF_OPTS = -DIMPORT_EXECUTABLES=$(HOST_LIBMUSICBRAINZ_DIR)/ImportExecutables.cmake Please add a comment above these lines to explain what is going on, i.e why we need to build host-libmusicbrainz, and pass this option. Thanks, Thomas
diff --git a/package/Config.in b/package/Config.in index a17901f..3339669 100644 --- a/package/Config.in +++ b/package/Config.in @@ -681,6 +681,7 @@ menu "Audio/Sound" source "package/libmodplug/Config.in" source "package/libmpd/Config.in" source "package/libmpdclient/Config.in" + source "package/libmusicbrainz/Config.in" source "package/libreplaygain/Config.in" source "package/libsamplerate/Config.in" source "package/libsidplay2/Config.in" diff --git a/package/libmusicbrainz/Config.in b/package/libmusicbrainz/Config.in new file mode 100644 index 0000000..51417fe --- /dev/null +++ b/package/libmusicbrainz/Config.in @@ -0,0 +1,18 @@ +config BR2_PACKAGE_LIBMUSICBRAINZ + bool "libmusicbrainz" + depends on BR2_INSTALL_LIBSTDCPP + select BR2_PACKAGE_LIBXML2 + select BR2_PACKAGE_NEON + select BR2_PACKAGE_NEON_LIBXML2 + help + The MusicBrainz Client Library (libmusicbrainz), + also known as mb_client, is a development library + geared towards developers who wish to add MusicBrainz + lookup capabilities to their applications. The library + supports Windows, Linux and Mac OS X, with packages + released for the RedHat and Debian distributions. + + http://musicbrainz.org/doc/libmusicbrainz + +comment "libmusicbrainz needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP diff --git a/package/libmusicbrainz/libmusicbrainz.mk b/package/libmusicbrainz/libmusicbrainz.mk new file mode 100644 index 0000000..a199f34 --- /dev/null +++ b/package/libmusicbrainz/libmusicbrainz.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# libmusicbrainz +# +################################################################################ + +LIBMUSICBRAINZ_VERSION = release-5.1.0 +LIBMUSICBRAINZ_SITE = $(call github,metabrainz,libmusicbrainz,$(LIBMUSICBRAINZ_VERSION)) +LIBMUSICBRAINZ_INSTALL_STAGING = YES + +LIBMUSICBRAINZ_DEPENDENCIES = libxml2 neon host-pkgconf host-libmusicbrainz + +LIBMUSICBRAINZ_CONF_OPTS = -DIMPORT_EXECUTABLES=$(HOST_LIBMUSICBRAINZ_DIR)/ImportExecutables.cmake + +$(eval $(cmake-package)) +$(eval $(host-cmake-package)) diff --git a/package/neon/neon.mk b/package/neon/neon.mk index 0cff1a2..284a98c 100644 --- a/package/neon/neon.mk +++ b/package/neon/neon.mk @@ -48,3 +48,4 @@ NEON_CONF_OPTS += --disable-webdav endif $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signed-off-by: Pieter De Gendt <pieter.degendt@gmail.com> --- package/Config.in | 1 + package/libmusicbrainz/Config.in | 18 ++++++++++++++++++ package/libmusicbrainz/libmusicbrainz.mk | 16 ++++++++++++++++ package/neon/neon.mk | 1 + 4 files changed, 36 insertions(+) create mode 100644 package/libmusicbrainz/Config.in create mode 100644 package/libmusicbrainz/libmusicbrainz.mk