| Message ID | 20100118171720.14623.86072.sendpatchset@localhost |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] ide: fix for ide_timing quantisation errors > > Based on commit 4f701d1 for libata. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > --- > drivers/ide/ide-timings.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > Index: b/drivers/ide/ide-timings.c > =================================================================== > --- a/drivers/ide/ide-timings.c > +++ b/drivers/ide/ide-timings.c > @@ -206,6 +206,12 @@ int ide_timing_compute(ide_drive_t *driv > t->recover = t->cycle - t->active; > } > > + /* In a few cases quantisation may produce enough errors to > + leave t->cycle too low for the sum of active and recovery > + if so we must correct this */ > Comment style should preferrably be: /* * blah * blah * blah */ MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sergei Shtylyov <sshtylyov@ru.mvista.com> Date: Mon, 18 Jan 2010 22:09:02 +0300 > Comment style should preferrably be: > > /* > * blah > * blah > * blah > */ Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ide/ide-timings.c =================================================================== --- a/drivers/ide/ide-timings.c +++ b/drivers/ide/ide-timings.c @@ -206,6 +206,12 @@ int ide_timing_compute(ide_drive_t *driv t->recover = t->cycle - t->active; } + /* In a few cases quantisation may produce enough errors to + leave t->cycle too low for the sum of active and recovery + if so we must correct this */ + if (t->active + t->recover > t->cycle) + t->cycle = t->active + t->recover; + return 0; } EXPORT_SYMBOL_GPL(ide_timing_compute);