| Message ID | 20150511124649.1221e86e@hyperion |
|---|---|
| State | New |
| Headers | show |
On Mon, May 11, 2015 at 12:46:49PM +0200, Michael Brunner wrote: > This patch fixes an inverted return value of the gpio get_direction > function. > > The wrong value causes the direction sysfs entry and GPIO debugfs file > to indicate incorrect GPIO direction settings. In some cases it also > prevents setting GPIO output values. > > The problem is also present in all other stable kernel versions since > linux-3.12. > > Reported-by: Jochen Henneberg <jh@henneberg-systemdesign.com> > Signed-off-by: Michael Brunner <michael.brunner@kontron.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 11, 2015 at 12:46 PM, Michael Brunner <mibru@gmx.de> wrote: > This patch fixes an inverted return value of the gpio get_direction > function. > > The wrong value causes the direction sysfs entry and GPIO debugfs file > to indicate incorrect GPIO direction settings. In some cases it also > prevents setting GPIO output values. > > The problem is also present in all other stable kernel versions since > linux-3.12. > > Reported-by: Jochen Henneberg <jh@henneberg-systemdesign.com> > Signed-off-by: Michael Brunner <michael.brunner@kontron.com> Patch applied and tagged for stable v3.12+ Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c index 6b8115f..83f281d 100644 --- a/drivers/gpio/gpio-kempld.c +++ b/drivers/gpio/gpio-kempld.c @@ -117,7 +117,7 @@ static int kempld_gpio_get_direction(struct gpio_chip *chip, unsigned offset) = container_of(chip, struct kempld_gpio_data, chip); struct kempld_device_data *pld = gpio->pld; - return kempld_gpio_get_bit(pld, KEMPLD_GPIO_DIR_NUM(offset), offset); + return !kempld_gpio_get_bit(pld, KEMPLD_GPIO_DIR_NUM(offset), offset); } static int kempld_gpio_pincount(struct kempld_device_data *pld)
This patch fixes an inverted return value of the gpio get_direction function. The wrong value causes the direction sysfs entry and GPIO debugfs file to indicate incorrect GPIO direction settings. In some cases it also prevents setting GPIO output values. The problem is also present in all other stable kernel versions since linux-3.12. Reported-by: Jochen Henneberg <jh@henneberg-systemdesign.com> Signed-off-by: Michael Brunner <michael.brunner@kontron.com> --- drivers/gpio/gpio-kempld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)