diff mbox

[1/1] package/e2fsprogs: Show toolchain comment only on mmu archs

Message ID 1428739246-3867-1-git-send-email-bernd.kuhls@t-online.de
State Accepted
Headers show

Commit Message

Bernd Kuhls April 11, 2015, 8 a.m. UTC 
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/e2fsprogs/Config.in |    1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN April 11, 2015, 9:03 a.m. UTC | #1 
Bernd, All,

On 2015-04-11 10:00 +0200, Bernd Kuhls spake thusly:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/e2fsprogs/Config.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
> index f5011d1..12d135b 100644
> --- a/package/e2fsprogs/Config.in
> +++ b/package/e2fsprogs/Config.in
> @@ -100,3 +100,4 @@ endif
>  
>  comment "e2fsprogs needs a toolchain w/ wchar"
>  	depends on !BR2_USE_WCHAR
> +	depends on BR2_USE_MMU

We usually put that dependency first. But that's not too problemtaic,
so:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni April 11, 2015, 1:36 p.m. UTC | #2 
Dear Bernd Kuhls,

On Sat, 11 Apr 2015 10:00:46 +0200, Bernd Kuhls wrote:
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/e2fsprogs/Config.in |    1 +
>  1 file changed, 1 insertion(+)

I've reordered the dependency to put BR2_USE_MMU first as
suggested by Yann, and applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
index f5011d1..12d135b 100644
--- a/package/e2fsprogs/Config.in
+++ b/package/e2fsprogs/Config.in
@@ -100,3 +100,4 @@  endif
 
 comment "e2fsprogs needs a toolchain w/ wchar"
 	depends on !BR2_USE_WCHAR
+	depends on BR2_USE_MMU