Message ID | 1427451870-16466-1-git-send-email-tbsaunde+gcc@tbsaunde.org |
---|---|
State | New |
Headers | show |
[CC ing maintainers] Ping. On 27 March 2015 at 11:24, <tbsaunde+gcc@tbsaunde.org> wrote: > From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org> > > Hi, > > Unfortunately when testing r217869 I didn't realize the modified code in > alpha.c was only used for some alpha targets. So testing alpha-linux wasn't > enough or even really useful :( > > I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is > still broken because the vms targets don't support c++ and don't say it > shouldn't be built in config.gcc. Is this ok? > > Trev > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 37258ad..fac42d6 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,9 @@ > +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org> > + > + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to > + alpha_links **. > + (alpha_write_one_linkage): Correct typo. > + > 2015-03-27 Marek Polacek <polacek@redhat.com> > > PR sanitizer/65583 > diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c > index 554ff09..67c15dc 100644 > --- a/gcc/config/alpha/alpha.c > +++ b/gcc/config/alpha/alpha.c > @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > if (cfun->machine->links) > { > /* Is this name already defined? */ > - alpha_links *slot = cfun->machine->links->get (name); > + alpha_links **slot = cfun->machine->links->get (name); > if (slot) > al = *slot; > } > @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > } > > static int > -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam) > +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream) > { > ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0)); > if (link->rkind == KIND_CODEADDR) > -- > 2.1.4 >
On Wed, Apr 08, 2015 at 03:57:09PM +0200, Bernhard Reutner-Fischer wrote: > [CC ing maintainers] > > Ping. This is ok. > > --- a/gcc/ChangeLog > > +++ b/gcc/ChangeLog > > @@ -1,3 +1,9 @@ > > +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org> > > + > > + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to > > + alpha_links **. > > + (alpha_write_one_linkage): Correct typo. > > + > > 2015-03-27 Marek Polacek <polacek@redhat.com> > > > > PR sanitizer/65583 > > diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c > > index 554ff09..67c15dc 100644 > > --- a/gcc/config/alpha/alpha.c > > +++ b/gcc/config/alpha/alpha.c > > @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > > if (cfun->machine->links) > > { > > /* Is this name already defined? */ > > - alpha_links *slot = cfun->machine->links->get (name); > > + alpha_links **slot = cfun->machine->links->get (name); > > if (slot) > > al = *slot; > > } > > @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > > } > > > > static int > > -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam) > > +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream) > > { > > ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0)); > > if (link->rkind == KIND_CODEADDR) > > -- > > 2.1.4 > > Jakub
On Fri, Mar 27, 2015 at 11:24 AM, <tbsaunde+gcc@tbsaunde.org> wrote: > From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org> > > Hi, > > Unfortunately when testing r217869 I didn't realize the modified code in > alpha.c was only used for some alpha targets. So testing alpha-linux wasn't > enough or even really useful :( > > I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is > still broken because the vms targets don't support c++ and don't say it > shouldn't be built in config.gcc. Is this ok? Ok. Thanks, Richard. > Trev > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 37258ad..fac42d6 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,9 @@ > +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org> > + > + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to > + alpha_links **. > + (alpha_write_one_linkage): Correct typo. > + > 2015-03-27 Marek Polacek <polacek@redhat.com> > > PR sanitizer/65583 > diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c > index 554ff09..67c15dc 100644 > --- a/gcc/config/alpha/alpha.c > +++ b/gcc/config/alpha/alpha.c > @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > if (cfun->machine->links) > { > /* Is this name already defined? */ > - alpha_links *slot = cfun->machine->links->get (name); > + alpha_links **slot = cfun->machine->links->get (name); > if (slot) > al = *slot; > } > @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) > } > > static int > -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam) > +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream) > { > ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0)); > if (link->rkind == KIND_CODEADDR) > -- > 2.1.4 >
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 37258ad..fac42d6 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-03-27 Trevor Saunders <tbsaunde@tbsaunde.org> + + * config/alpha/alpha.c (alpha_use_linkage): Change type of slot to + alpha_links **. + (alpha_write_one_linkage): Correct typo. + 2015-03-27 Marek Polacek <polacek@redhat.com> PR sanitizer/65583 diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c index 554ff09..67c15dc 100644 --- a/gcc/config/alpha/alpha.c +++ b/gcc/config/alpha/alpha.c @@ -9665,7 +9665,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) if (cfun->machine->links) { /* Is this name already defined? */ - alpha_links *slot = cfun->machine->links->get (name); + alpha_links **slot = cfun->machine->links->get (name); if (slot) al = *slot; } @@ -9711,7 +9711,7 @@ alpha_use_linkage (rtx func, bool lflag, bool rflag) } static int -alpha_write_one_linkage (const char *name, alpha_links *link, FILE *steam) +alpha_write_one_linkage (const char *name, alpha_links *link, FILE *stream) { ASM_OUTPUT_INTERNAL_LABEL (stream, XSTR (link->linkage, 0)); if (link->rkind == KIND_CODEADDR)
From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org> Hi, Unfortunately when testing r217869 I didn't realize the modified code in alpha.c was only used for some alpha targets. So testing alpha-linux wasn't enough or even really useful :( I tested cc1 for alpha-dec-vms now builds as discussed before make all-gcc is still broken because the vms targets don't support c++ and don't say it shouldn't be built in config.gcc. Is this ok? Trev