| Message ID | 20150329074920.GA145050@athens |
|---|---|
| State | New |
| Headers | show |
On Sun, Mar 29, 2015 at 03:49:20PM +0800, kbuild test robot wrote: > drivers/pinctrl/pinctrl-max77620.c:472:3-8: No need to set .owner here. The core will do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > CC: Alexandre Courbot <acourbot@nvidia.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > pinctrl-max77620.c | 1 - > 1 file changed, 1 deletion(-) Hi Linus, please ignore this. It's from a staging tree and against a driver that doesn't exist upstream yet. I have for now removed these branches from my github tree completely until we can figure out a way to keep the 0- day builder from generating these patches. Thierry > --- a/drivers/pinctrl/pinctrl-max77620.c > +++ b/drivers/pinctrl/pinctrl-max77620.c > @@ -469,7 +469,6 @@ static int max77620_pinctrl_remove(struc > static struct platform_driver max77620_pinctrl_driver = { > .driver = { > .name = "max77620-pinctrl", > - .owner = THIS_MODULE, > }, > .probe = max77620_pinctrl_probe, > .remove = max77620_pinctrl_remove,
On Mon, Mar 30, 2015 at 3:05 PM, Thierry Reding <treding@nvidia.com> wrote: > On Sun, Mar 29, 2015 at 03:49:20PM +0800, kbuild test robot wrote: >> drivers/pinctrl/pinctrl-max77620.c:472:3-8: No need to set .owner here. The core will do it. >> >> Remove .owner field if calls are used which set it automatically >> >> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci >> >> CC: Alexandre Courbot <acourbot@nvidia.com> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >> --- >> >> pinctrl-max77620.c | 1 - >> 1 file changed, 1 deletion(-) > > Hi Linus, > > please ignore this. It's from a staging tree and against a driver that > doesn't exist upstream yet. I have for now removed these branches from > my github tree completely until we can figure out a way to keep the 0- > day builder from generating these patches. Bah no big deal, I think I managed to fire off a similar thing on a PWM driver down your path :P Fengguang said he'd fixed it though IIRC. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 07, 2015 at 03:09:46PM +0200, Linus Walleij wrote: > On Mon, Mar 30, 2015 at 3:05 PM, Thierry Reding <treding@nvidia.com> wrote: > > On Sun, Mar 29, 2015 at 03:49:20PM +0800, kbuild test robot wrote: > >> drivers/pinctrl/pinctrl-max77620.c:472:3-8: No need to set .owner here. The core will do it. > >> > >> Remove .owner field if calls are used which set it automatically > >> > >> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > >> > >> CC: Alexandre Courbot <acourbot@nvidia.com> > >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > >> --- > >> > >> pinctrl-max77620.c | 1 - > >> 1 file changed, 1 deletion(-) > > > > Hi Linus, > > > > please ignore this. It's from a staging tree and against a driver that > > doesn't exist upstream yet. I have for now removed these branches from > > my github tree completely until we can figure out a way to keep the 0- > > day builder from generating these patches. > > Bah no big deal, I think I managed to fire off a similar thing on > a PWM driver down your path :P > > Fengguang said he'd fixed it though IIRC. Yes sorry for the noise! I've listed Thierry's tree as private report tree (the black list way). Perhaps would be better to make the logic white list based -- then it will be completely noise free. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/pinctrl/pinctrl-max77620.c +++ b/drivers/pinctrl/pinctrl-max77620.c @@ -469,7 +469,6 @@ static int max77620_pinctrl_remove(struc static struct platform_driver max77620_pinctrl_driver = { .driver = { .name = "max77620-pinctrl", - .owner = THIS_MODULE, }, .probe = max77620_pinctrl_probe, .remove = max77620_pinctrl_remove,
drivers/pinctrl/pinctrl-max77620.c:472:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- pinctrl-max77620.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html