[{"id":1976181,"web_url":"http://patchwork.ozlabs.org/comment/1976181/","msgid":"","date":"2018-08-20T08:23:13","subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","submitter":{"id":64267,"url":"http://patchwork.ozlabs.org/api/people/64267/","name":"Rafael J. Wysocki","email":"rafael@kernel.org"},"content":"On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote:\n>\n> The acpi_pci_create_root_bus() can be fully integrated into\n> acpi_pci_root_create(), improving a few things:\n>\n> * We can call pci_scan_root_bus_bridge(), which registers and\n> scans the bridge in one step.\n> * After a failure in pci_register_host_bridge(), we correctly\n> clean up the resources.\n> * The bridge settings (release function, flags, operations etc)\n> can get set up before registering the bridge.\n> * Further cleanup would be possible, removing duplication between\n> pci_host_bridge and some ACPI structures.\n>\n> Signed-off-by: Arnd Bergmann \n> ---\n> drivers/acpi/pci_root.c | 68 +++++++++++++++--------------------------\n> 1 file changed, 24 insertions(+), 44 deletions(-)\n>\n> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c\n> index 85dbcf47015b..5f73de3b67c8 100644\n> --- a/drivers/acpi/pci_root.c\n> +++ b/drivers/acpi/pci_root.c\n> @@ -873,34 +873,6 @@ static void acpi_pci_root_release_info(struct pci_host_bridge *bridge)\n> __acpi_pci_root_release_info(bridge->release_data);\n> }\n>\n> -static struct pci_bus *acpi_pci_create_root_bus(struct device *parent, int bus,\n> - struct pci_ops *ops, void *sysdata, struct list_head *resources)\n> -{\n> - int error;\n> - struct pci_host_bridge *bridge;\n> -\n> - bridge = pci_alloc_host_bridge(0);\n> - if (!bridge)\n> - return NULL;\n> -\n> - bridge->dev.parent = parent;\n> -\n> - list_splice_init(resources, &bridge->windows);\n> - bridge->sysdata = sysdata;\n> - bridge->busnr = bus;\n> - bridge->ops = ops;\n> -\n> - error = pci_register_host_bridge(bridge);\n> - if (error < 0)\n> - goto err_out;\n> -\n> - return bridge->bus;\n> -\n> -err_out:\n> - kfree(bridge);\n> - return NULL;\n> -}\n> -\n> struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n> struct acpi_pci_root_ops *ops,\n> struct acpi_pci_root_info *info,\n> @@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n> int ret, busnum = root->secondary.start;\n> struct acpi_device *device = root->device;\n> int node = acpi_get_node(device->handle);\n> - struct pci_bus *bus;\n> - struct pci_host_bridge *host_bridge;\n> + struct pci_host_bridge *bridge;\n\nWhy \"bridge\" and not \"host\" or even something to stand for \"root complex\"?\n\nOr maybe it can still be \"host_bridge\"?\n\n>\n> info->root = root;\n> info->bridge = device;\n> @@ -930,30 +901,39 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n>\n> pci_acpi_root_add_resources(info);\n> pci_add_resource(&info->resources, &root->secondary);\n> - bus = acpi_pci_create_root_bus(NULL, busnum, ops->pci_ops,\n> - sysdata, &info->resources);\n> - if (!bus)\n> +\n> + bridge = pci_alloc_host_bridge(0);\n> + if (!bridge)\n> goto out_release_info;\n>\n> - host_bridge = to_pci_host_bridge(bus->bridge);\n> + list_splice_init(&info->resources, &bridge->windows);\n> + bridge->sysdata = sysdata;\n> + bridge->busnr = busnum;\n> + bridge->ops = ops->pci_ops;\n> + pci_set_host_bridge_release(bridge, acpi_pci_root_release_info,\n> + info);\n> +\n> if (!(root->osc_control_set & OSC_PCI_EXPRESS_NATIVE_HP_CONTROL))\n> - host_bridge->native_pcie_hotplug = 0;\n> + bridge->native_pcie_hotplug = 0;\n> if (!(root->osc_control_set & OSC_PCI_SHPC_NATIVE_HP_CONTROL))\n> - host_bridge->native_shpc_hotplug = 0;\n> + bridge->native_shpc_hotplug = 0;\n> if (!(root->osc_control_set & OSC_PCI_EXPRESS_AER_CONTROL))\n> - host_bridge->native_aer = 0;\n> + bridge->native_aer = 0;\n> if (!(root->osc_control_set & OSC_PCI_EXPRESS_PME_CONTROL))\n> - host_bridge->native_pme = 0;\n> + bridge->native_pme = 0;\n> if (!(root->osc_control_set & OSC_PCI_EXPRESS_LTR_CONTROL))\n> - host_bridge->native_ltr = 0;\n> + bridge->native_ltr = 0;\n> +\n> + ret = pci_scan_root_bus_bridge(bridge);\n> + if (ret < 0)\n> + goto out_release_bridge;\n>\n> - pci_scan_child_bus(bus);\n> - pci_set_host_bridge_release(host_bridge, acpi_pci_root_release_info,\n> - info);\n> if (node != NUMA_NO_NODE)\n> - dev_printk(KERN_DEBUG, &bus->dev, \"on NUMA node %d\\n\", node);\n> - return bus;\n> + dev_printk(KERN_DEBUG, &bridge->bus->dev, \"on NUMA node %d\\n\", node);\n> + return bridge->bus;\n>\n> +out_release_bridge:\n> + pci_free_host_bridge(bridge);\n> out_release_info:\n> __acpi_pci_root_release_info(info);\n> return NULL;\n> --\n> 2.18.0\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41v6QC5xg6z9s5c\n\tfor ;\n\tMon, 20 Aug 2018 18:28:19 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 41v6QC3fZBzF0pD\n\tfor ;\n\tMon, 20 Aug 2018 18:28:19 +1000 (AEST)","from mail-oi0-f65.google.com (mail-oi0-f65.google.com\n\t[209.85.218.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 41v6Jb1H70zF1Rx\n\tfor ;\n\tMon, 20 Aug 2018 18:23:26 +1000 (AEST)","by mail-oi0-f65.google.com with SMTP id d189-v6so24385489oib.6\n\tfor ;\n\tMon, 20 Aug 2018 01:23:26 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=209.85.218.65; helo=mail-oi0-f65.google.com;\n\tenvelope-from=rjwysocki@gmail.com; receiver=)","lists.ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=bhi+ITlSqzxPQ4GhR8SuWnrUmGxHJHpUdrs2rUW/fXU=;\n\tb=VAoHWbZuperYbKRd1fV0eeVdjDXY4NXMA2YCK4toi35hMV5P1Mhj7foHITSqMqejqy\n\tofWAN08UmA6x5wAxttWNX4YmwvQBbwzucRsmhN7yL8IjOsCA95du7ANAsD1RXGOy49Nk\n\tRgYqvlD6tWBollmP7nkOCkrlI3P5knt8QHFfK4BNY2AYM2ghtgjZrtQG342338zsiimn\n\tSNPEeiRS7sHgw6bTEdRZSb0+rXyJo617eApYFaeewQO56YfUAaQmrQNeqv3hwMQbKCUL\n\t50l2VlB9UKJBC+BjvH5aNGe0LkjTbDxh4Hh4iU6swqLGGb1PckCxO3B/bq+cn1SBEdS0\n\tYyDA==","X-Gm-Message-State":"APzg51CDFUOnLLdr33L2vZk0tNHj9cBX47cRTJaWpgtFqHNjrNRk6fgn\n\tJaar6+o+fgrjavGS8GdpRNytq+uIT/jhB//XMcQ1sg==","X-Google-Smtp-Source":"AA+uWPz6+693Vpz8m+iM+UnhUMBFVWZXjArxzp67xmbsq76hN0IeqD/j1lvPBfWQy1P3LoAARi2KlqQt792uPTa1ACU=","X-Received":"by 2002:aca:dd07:: with SMTP id\n\tu7-v6mr13500885oig.177.1534753404893; \n\tMon, 20 Aug 2018 01:23:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20180817102645.3839621-1-arnd@arndb.de>\n\t<20180817102645.3839621-8-arnd@arndb.de>","In-Reply-To":"<20180817102645.3839621-8-arnd@arndb.de>","From":"\"Rafael J. Wysocki\" ","Date":"Mon, 20 Aug 2018 10:23:13 +0200","Message-ID":"","Subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","To":"Arnd Bergmann ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.27","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lorenzo Pieralisi ,\n\tLinux PCI ,\n\tLinux Kernel Mailing List ,\n\tChristoph Hellwig ,\n\tACPI Devel Maling List ,\n\tBjorn Helgaas ,\n\tlinuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1976326,"web_url":"http://patchwork.ozlabs.org/comment/1976326/","msgid":"","date":"2018-08-20T11:19:48","subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Mon, Aug 20, 2018 at 10:23 AM Rafael J. Wysocki wrote:\n> On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote:\n> > @@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n> > int ret, busnum = root->secondary.start;\n> > struct acpi_device *device = root->device;\n> > int node = acpi_get_node(device->handle);\n> > - struct pci_bus *bus;\n> > - struct pci_host_bridge *host_bridge;\n> > + struct pci_host_bridge *bridge;\n>\n> Why \"bridge\" and not \"host\" or even something to stand for \"root complex\"?\n>\n> Or maybe it can still be \"host_bridge\"?\n\nI did this for consistency with the naming in drivers/pci/probe.c,\nwhich always declares the local variable as 'struct pci_host_bridge *bridge'.\nIt's easy to change here if you feel strongly about it (I don't).\n\n Arnd","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41vBGK1m9Rz9s3Z\n\tfor ;\n\tMon, 20 Aug 2018 21:21:45 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 41vBGK0TbmzF1d7\n\tfor ;\n\tMon, 20 Aug 2018 21:21:45 +1000 (AEST)","from mail-qt0-f196.google.com (mail-qt0-f196.google.com\n\t[209.85.216.196])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 41vBDR4RSLzDqp5\n\tfor ;\n\tMon, 20 Aug 2018 21:20:07 +1000 (AEST)","by mail-qt0-f196.google.com with SMTP id r21-v6so15707050qtm.2\n\tfor ;\n\tMon, 20 Aug 2018 04:20:07 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de","lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de","lists.ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=209.85.216.196; helo=mail-qt0-f196.google.com;\n\tenvelope-from=arndbergmann@gmail.com; receiver=)","lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=v6zsyC2te87uF0RtJ5t0u6eQdifD8RmrlBjRFINr088=;\n\tb=hVSuq9r4klmkZY04+3Z3H3r5VjkG/hs3Q3ncUxBm+YWeXIfLJs293YPukyYxLDvfPr\n\tebc+qg2YtLjunea6FxiXd+0qc7ArVu6eiLwu33Hpft0exJT90weGA5NKhIzmckGUnsKq\n\t3uw6f0pwOzCS4dHg/9JY6nUrkldS85IiB9v5iXr7L/0S4g064C8wjMO874gXnto8zW4f\n\tUyZOJH+myKiKDdARCTSdc07Aa6M1w32EpU5Q9wkYhAl6oKSJCgLLIms0ZnLQ5tv46IpV\n\tPvFxlbxqX76SbipY5a/qidHQeyrly7ZXwMgms+rQZc7OhnGHcG5a4lK0/+CcddMbtcYi\n\tW2lw==","X-Gm-Message-State":"AOUpUlFT3WwDB/9/e3/A2J1ZZaGydz6/ALhXacAVAV0K3jfUUwKS2xmG\n\tfboBQTRN8WCliteXl/Gu4/FnrdfGIxT7EZPCL/s=","X-Google-Smtp-Source":"AA+uWPxFqYu8MTZg5ODa5YYedofk9y3d9xLtfJzqeASyNPw379fivmsODYiv1TmoRFe7zY7drrVxvKsX6lViBRG5mVE=","X-Received":"by 2002:a0c:8b67:: with SMTP id\n\td39-v6mr40563417qvc.180.1534764005043; \n\tMon, 20 Aug 2018 04:20:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20180817102645.3839621-1-arnd@arndb.de>\n\t<20180817102645.3839621-8-arnd@arndb.de>\n\t","In-Reply-To":"","From":"Arnd Bergmann ","Date":"Mon, 20 Aug 2018 13:19:48 +0200","Message-ID":"","Subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","To":"Rafael Wysocki ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.27","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lorenzo Pieralisi ,\n\tlinux-pci ,\n\tLinux Kernel Mailing List ,\n\tChristoph Hellwig ,\n\tACPI Devel Maling List ,\n\tBjorn Helgaas ,\n\tlinuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1976332,"web_url":"http://patchwork.ozlabs.org/comment/1976332/","msgid":"","date":"2018-08-20T11:24:20","subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","submitter":{"id":64267,"url":"http://patchwork.ozlabs.org/api/people/64267/","name":"Rafael J. Wysocki","email":"rafael@kernel.org"},"content":"On Mon, Aug 20, 2018 at 1:20 PM Arnd Bergmann wrote:\n>\n> On Mon, Aug 20, 2018 at 10:23 AM Rafael J. Wysocki wrote:\n> > On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote:\n> > > @@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n> > > int ret, busnum = root->secondary.start;\n> > > struct acpi_device *device = root->device;\n> > > int node = acpi_get_node(device->handle);\n> > > - struct pci_bus *bus;\n> > > - struct pci_host_bridge *host_bridge;\n> > > + struct pci_host_bridge *bridge;\n> >\n> > Why \"bridge\" and not \"host\" or even something to stand for \"root complex\"?\n> >\n> > Or maybe it can still be \"host_bridge\"?\n>\n> I did this for consistency with the naming in drivers/pci/probe.c,\n> which always declares the local variable as 'struct pci_host_bridge *bridge'.\n> It's easy to change here if you feel strongly about it (I don't).\n\nI would leave host_bridge here. It would make the patch smaller too I think.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41vBML3MjFz9s3Z\n\tfor ;\n\tMon, 20 Aug 2018 21:26:06 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 41vBML27bzzF1Rh\n\tfor ;\n\tMon, 20 Aug 2018 21:26:06 +1000 (AEST)","from mail-oi0-f67.google.com (mail-oi0-f67.google.com\n\t[209.85.218.67])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 41vBKZ1RGmzDqp5\n\tfor ;\n\tMon, 20 Aug 2018 21:24:33 +1000 (AEST)","by mail-oi0-f67.google.com with SMTP id b15-v6so25097668oib.10\n\tfor ;\n\tMon, 20 Aug 2018 04:24:33 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=209.85.218.67; helo=mail-oi0-f67.google.com;\n\tenvelope-from=rjwysocki@gmail.com; receiver=)","lists.ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=rs+d9IJsmy+/lM6N8uTP1eL0XxsVtMeuH7FzaQKP2oc=;\n\tb=i+SJy2SI77vIlxj92++einh7w0GOXIYT6fUS+IHZu4XRule/bf+kGUY1SCOQBByPVo\n\tsWoyFMmDmYYCkRofatGx3BKUori+OrSOQjXCOqo3u34q3xim8PVuFA5nNzTkfAVmB676\n\tuFOkw1glpeSvJ8hN4vVai3pRnhPJxzFZfPSf/3+eiJvaa80+lLAFapO2bf6vj3dmSR7f\n\t78k80VNMYiL1OYG0jvzYyrVmmXNpe9pu7gjDzWxqSzjOsbAzQJtRS9LlOHpdTWG05V73\n\t8BaI0fmxKGJMiLcWnzLFFvkZCyRuHhkBNJNJHE0PvaZg260QHJRxCXI7vZLKPxtFVBwH\n\tKVIA==","X-Gm-Message-State":"AOUpUlH/t2ROORU9y18lTBtcIXCPUkIDG0Evq5SuTfEdFi20euE1ihhh\n\tNgBJLZgYAbjiIZmN+fQQgUYAQgnviY7vt1UsZ78=","X-Google-Smtp-Source":"AA+uWPzH3MouF8HwYhWDoigF9pVRXpuMFym1x1Uy75GQd6fHqqigIcJoCZMGa59enccLnAvULmUQ1tFhk8e5o3//glU=","X-Received":"by 2002:aca:b885:: with SMTP id\n\ti127-v6mr13722061oif.180.1534764272015; \n\tMon, 20 Aug 2018 04:24:32 -0700 (PDT)","MIME-Version":"1.0","References":"<20180817102645.3839621-1-arnd@arndb.de>\n\t<20180817102645.3839621-8-arnd@arndb.de>\n\t\n\t","In-Reply-To":"","From":"\"Rafael J. Wysocki\" ","Date":"Mon, 20 Aug 2018 13:24:20 +0200","Message-ID":"","Subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","To":"Arnd Bergmann ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.27","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lorenzo Pieralisi ,\n\t\"Rafael J. Wysocki\" ,\n\tLinux PCI , \n\tLinux Kernel Mailing List ,\n\tChristoph Hellwig ,\n\tACPI Devel Maling List ,\n\tBjorn Helgaas ,\n\tlinuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1976350,"web_url":"http://patchwork.ozlabs.org/comment/1976350/","msgid":"","date":"2018-08-20T11:36:19","subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","submitter":{"id":30,"url":"http://patchwork.ozlabs.org/api/people/30/","name":"Arnd Bergmann","email":"arnd@arndb.de"},"content":"On Mon, Aug 20, 2018 at 1:24 PM Rafael J. Wysocki wrote:\n>\n> On Mon, Aug 20, 2018 at 1:20 PM Arnd Bergmann wrote:\n> >\n> > On Mon, Aug 20, 2018 at 10:23 AM Rafael J. Wysocki wrote:\n> > > On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote:\n> > > > @@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,\n> > > > int ret, busnum = root->secondary.start;\n> > > > struct acpi_device *device = root->device;\n> > > > int node = acpi_get_node(device->handle);\n> > > > - struct pci_bus *bus;\n> > > > - struct pci_host_bridge *host_bridge;\n> > > > + struct pci_host_bridge *bridge;\n> > >\n> > > Why \"bridge\" and not \"host\" or even something to stand for \"root complex\"?\n> > >\n> > > Or maybe it can still be \"host_bridge\"?\n> >\n> > I did this for consistency with the naming in drivers/pci/probe.c,\n> > which always declares the local variable as 'struct pci_host_bridge *bridge'.\n> > It's easy to change here if you feel strongly about it (I don't).\n>\n> I would leave host_bridge here. It would make the patch smaller too I think.\n\nOk, I've changed my local copy as you suggested now.\n\n Arnd","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41vBfD3MD7z9s4v\n\tfor ;\n\tMon, 20 Aug 2018 21:39:00 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 41vBfD289nzF1rc\n\tfor ;\n\tMon, 20 Aug 2018 21:39:00 +1000 (AEST)","from mail-qk0-f195.google.com (mail-qk0-f195.google.com\n\t[209.85.220.195])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 41vBbV585nzF1R0\n\tfor ;\n\tMon, 20 Aug 2018 21:36:38 +1000 (AEST)","by mail-qk0-f195.google.com with SMTP id d131-v6so511389qke.11\n\tfor ;\n\tMon, 20 Aug 2018 04:36:38 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de","lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de","lists.ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=209.85.220.195; helo=mail-qk0-f195.google.com;\n\tenvelope-from=arndbergmann@gmail.com; receiver=)","lists.ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=arndb.de"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=BrnLOn8v69lnFmICjGqysrHynU2MjRjNv20L/2S9p9c=;\n\tb=mLv4o7CW9xp0tfLatvDS0GWr3aUprCMDkfgnVslkIMex2XYAGPryAV/ZGc3yDjJ+j+\n\tq1OfpzIG0fb6vo1Enox4gDVnHfI/m6KljF0X4XoAOu8ckT3ElrgH7qHFhXi14lSrXp1t\n\tl8mWBBZcQZlwlqbQ/eZB31h/383OYKoRAfpgZ/RgYRIBtkgNs8byFv7WbxjFePi5A1Iz\n\tuhh8DG2OjVxemU8a3ihNhlkT6kLMfTUfpoY8J3ks/ln0Iuj6gEZnjRm/xwUxwNbQzE0Q\n\tN/sxQihIn2DovQq7EqKl/+j/HIx7oYEi+WvynI5d1Oqog8r57AhRI+rBghgzu4P0Cqe7\n\tAjew==","X-Gm-Message-State":"AOUpUlGF3JM4Jv9MhZY7Ksov1pspJmWmA3fz/AJHgoRFhqhXfQHxN77S\n\tKmP0G2ymHXu4ISkAWMgK7M5fkb0IaijEi3O+zrg=","X-Google-Smtp-Source":"AA+uWPw7SZ73vZypnfO8k491nuXygZ+N/no3rKENW0UdkGHsrM6+cmlx2fzRmD8Eh0JLvpqP4Z3RzupzoTxGwUMwy2g=","X-Received":"by 2002:a37:7946:: with SMTP id\n\tu67-v6mr39746101qkc.283.1534764996023; \n\tMon, 20 Aug 2018 04:36:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20180817102645.3839621-1-arnd@arndb.de>\n\t<20180817102645.3839621-8-arnd@arndb.de>\n\t\n\t\n\t","In-Reply-To":"","From":"Arnd Bergmann ","Date":"Mon, 20 Aug 2018 13:36:19 +0200","Message-ID":"","Subject":"Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()","To":"Rafael Wysocki ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.27","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lorenzo Pieralisi ,\n\tlinux-pci ,\n\tLinux Kernel Mailing List ,\n\tChristoph Hellwig ,\n\tACPI Devel Maling List ,\n\tBjorn Helgaas ,\n\tlinuxppc-dev ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]