[{"id":1961076,"web_url":"http://patchwork.ozlabs.org/comment/1961076/","msgid":"<20180725174210.3a1c0535@bbrezillon>","list_archive_url":null,"date":"2018-07-25T15:42:10","subject":"Re: [PATCH v5 05/17] mtd: rawnand: atmel: clarify NAND\n\taddition/removal paths","submitter":{"id":73370,"url":"http://patchwork.ozlabs.org/api/people/73370/","name":"Boris Brezillon","email":"boris.brezillon@bootlin.com"},"content":"On Wed, 25 Jul 2018 15:31:40 +0200\nMiquel Raynal wrote:\n\n> No need for an atmel_nand_register() function, let's move the code in\n> it directly where the function was called: in\n> atmel_nand_controller_add_nand(). Also, for more coherence, rename\n> atmel_nand_unregister() as atmel_nand_controller_remove_nand(), as\n> opposed as the previously mentioned function.\n\nHow about replacing the last sentence (which is not clear at all) by:\n\n\"\nTo make things consistent, also rename atmel_nand_unregister() into\natmel_nand_controller_remove_nand().\n\"\n\n> \n> Signed-off-by: Miquel Raynal \n\nReviewed-by: Boris Brezillon \n\n> ---\n> drivers/mtd/nand/raw/atmel/nand-controller.c | 102 ++++++++++++---------------\n> 1 file changed, 45 insertions(+), 57 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c\n> index 4d27401f1299..143d029710f0 100644\n> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c\n> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c\n> @@ -1573,7 +1573,7 @@ static int atmel_nand_detect(struct atmel_nand *nand)\n> \treturn ret;\n> }\n> \n> -static int atmel_nand_unregister(struct atmel_nand *nand)\n> +static int atmel_nand_controller_remove_nand(struct atmel_nand *nand)\n> {\n> \tstruct nand_chip *chip = &nand->base;\n> \tstruct mtd_info *mtd = nand_to_mtd(chip);\n> @@ -1589,60 +1589,6 @@ static int atmel_nand_unregister(struct atmel_nand *nand)\n> \treturn 0;\n> }\n> \n> -static int atmel_nand_register(struct atmel_nand *nand)\n> -{\n> -\tstruct nand_chip *chip = &nand->base;\n> -\tstruct mtd_info *mtd = nand_to_mtd(chip);\n> -\tstruct atmel_nand_controller *nc;\n> -\tint ret;\n> -\n> -\tnc = to_nand_controller(chip->controller);\n> -\n> -\tif (nc->caps->legacy_of_bindings || !nc->dev->of_node) {\n> -\t\t/*\n> -\t\t * We keep the MTD name unchanged to avoid breaking platforms\n> -\t\t * where the MTD cmdline parser is used and the bootloader\n> -\t\t * has not been updated to use the new naming scheme.\n> -\t\t */\n> -\t\tmtd->name = \"atmel_nand\";\n> -\t} else if (!mtd->name) {\n> -\t\t/*\n> -\t\t * If the new bindings are used and the bootloader has not been\n> -\t\t * updated to pass a new mtdparts parameter on the cmdline, you\n> -\t\t * should define the following property in your nand node:\n> -\t\t *\n> -\t\t *\tlabel = \"atmel_nand\";\n> -\t\t *\n> -\t\t * This way, mtd->name will be set by the core when\n> -\t\t * nand_set_flash_node() is called.\n> -\t\t */\n> -\t\tmtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,\n> -\t\t\t\t\t \"%s:nand.%d\", dev_name(nc->dev),\n> -\t\t\t\t\t nand->cs[0].id);\n> -\t\tif (!mtd->name) {\n> -\t\t\tdev_err(nc->dev, \"Failed to allocate mtd->name\\n\");\n> -\t\t\treturn -ENOMEM;\n> -\t\t}\n> -\t}\n> -\n> -\tret = nand_scan_tail(mtd);\n> -\tif (ret) {\n> -\t\tdev_err(nc->dev, \"nand_scan_tail() failed: %d\\n\", ret);\n> -\t\treturn ret;\n> -\t}\n> -\n> -\tret = mtd_device_register(mtd, NULL, 0);\n> -\tif (ret) {\n> -\t\tdev_err(nc->dev, \"Failed to register mtd device: %d\\n\", ret);\n> -\t\tnand_cleanup(chip);\n> -\t\treturn ret;\n> -\t}\n> -\n> -\tlist_add_tail(&nand->node, &nc->chips);\n> -\n> -\treturn 0;\n> -}\n> -\n> static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc,\n> \t\t\t\t\t struct device_node *np,\n> \t\t\t\t\t int reg_cells)\n> @@ -1772,7 +1718,49 @@ atmel_nand_controller_add_nand(struct atmel_nand_controller *nc,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\treturn atmel_nand_register(nand);\n> +\tif (nc->caps->legacy_of_bindings || !nc->dev->of_node) {\n> +\t\t/*\n> +\t\t * We keep the MTD name unchanged to avoid breaking platforms\n> +\t\t * where the MTD cmdline parser is used and the bootloader\n> +\t\t * has not been updated to use the new naming scheme.\n> +\t\t */\n> +\t\tmtd->name = \"atmel_nand\";\n> +\t} else if (!mtd->name) {\n> +\t\t/*\n> +\t\t * If the new bindings are used and the bootloader has not been\n> +\t\t * updated to pass a new mtdparts parameter on the cmdline, you\n> +\t\t * should define the following property in your nand node:\n> +\t\t *\n> +\t\t *\tlabel = \"atmel_nand\";\n> +\t\t *\n> +\t\t * This way, mtd->name will be set by the core when\n> +\t\t * nand_set_flash_node() is called.\n> +\t\t */\n> +\t\tmtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,\n> +\t\t\t\t\t \"%s:nand.%d\", dev_name(nc->dev),\n> +\t\t\t\t\t nand->cs[0].id);\n> +\t\tif (!mtd->name) {\n> +\t\t\tdev_err(nc->dev, \"Failed to allocate mtd->name\\n\");\n> +\t\t\treturn -ENOMEM;\n> +\t\t}\n> +\t}\n> +\n> +\tret = nand_scan_tail(mtd);\n> +\tif (ret) {\n> +\t\tdev_err(nc->dev, \"nand_scan_tail() failed: %d\\n\", ret);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tret = mtd_device_register(mtd, NULL, 0);\n> +\tif (ret) {\n> +\t\tdev_err(nc->dev, \"Failed to register mtd device: %d\\n\", ret);\n> +\t\tnand_cleanup(chip);\n> +\t\treturn ret;\n> +\t}\n> +\n> +\tlist_add_tail(&nand->node, &nc->chips);\n> +\n> +\treturn 0;\n> }\n> \n> static int\n> @@ -1782,7 +1770,7 @@ atmel_nand_controller_remove_nands(struct atmel_nand_controller *nc)\n> \tint ret;\n> \n> \tlist_for_each_entry_safe(nand, tmp, &nc->chips, node) {\n> -\t\tret = atmel_nand_unregister(nand);\n> +\t\tret = atmel_nand_controller_remove_nand(nand);\n> \t\tif (ret)\n> \t\t\treturn ret;\n> \t}","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"H9xDppQq\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bKHx38rxz9s29\n\tfor ;\n\tThu, 26 Jul 2018 01:43:09 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLwK-0005B1-SW; Wed, 25 Jul 2018 15:43:00 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLwH-00059n-G8\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 15:42:59 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid 10615203EC; Wed, 25 Jul 2018 17:42:46 +0200 (CEST)","from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr\n\t[90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id ED291207B3;\n\tWed, 25 Jul 2018 17:42:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=vsxkadgglRcl2nb1ONABOEkHJmkGAHSNqwK0RIulToA=;\n\tb=H9xDppQqrGZhNw\n\t7fDW9erp/TY8GrMH9tZ/E+RdeF0+vIApzebbL4/cJICfEo6Haqtz0greuy19vrEjPhiByjy+ZW70+\n\tN2f3CWf9PImx6hlUEA0TdTj53fPNaHI17n1pRDX7vfRyeYSbRiEx0/Tty6f8cUbopU97xZj7/r9Rt\n\tmUVTA+1cAOqDP5lJe7v1F8hdcRbNRk+IHO+RXEfQNDOSLBwAiPXVyoxdzp/M4VmHn2U0AXnYvGZE3\n\tiJWcrMtD8S7AR3xjChNkhqrgRT8LZoe12bD+O6RbmaTO9+chcPOwXxEtqBR9fXzNKmREeTzfPnxEd\n\tenPE1dc/gKCngGUGTr1Q==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 25 Jul 2018 17:42:10 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5 05/17] mtd: rawnand: atmel: clarify NAND\n\taddition/removal paths","Message-ID":"<20180725174210.3a1c0535@bbrezillon>","In-Reply-To":"<20180725133152.30898-6-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>\n\t<20180725133152.30898-6-miquel.raynal@bootlin.com>","X-Mailer":"Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_084257_810370_324C6AD4 ","X-CRM114-Status":"GOOD ( 26.45 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tRichard Weinberger , Stefan Agner , \n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tJosh Wu ,\n\tBrian Norris , \n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]