[{"id":1961080,"web_url":"http://patchwork.ozlabs.org/comment/1961080/","msgid":"<20180725174451.23a4a783@bbrezillon>","list_archive_url":null,"date":"2018-07-25T15:44:51","subject":"Re: [PATCH v5 07/17] mtd: rawnand: do not execute nand_scan_ident()\n\tif maxchips is zero","submitter":{"id":73370,"url":"http://patchwork.ozlabs.org/api/people/73370/","name":"Boris Brezillon","email":"boris.brezillon@bootlin.com"},"content":"On Wed, 25 Jul 2018 15:31:42 +0200\nMiquel Raynal wrote:\n\n> Some driver (eg. docg4) will need to handle themselves the\n> identification phase. As part of the migration to use nand_scan()\n> everywhere (which will unconditionnaly call nand_scan_ident()), we add\n> a condition at the start of nand_scan_with_ids() to jump over\n> nand_scan_ident() if the maxchips parameters is zero, meaning that the\n> driver does not want the core to handle this phase.\n> \n> Signed-off-by: Miquel Raynal \n\nReviewed-by: Boris Brezillon \n\n> ---\n> drivers/mtd/nand/raw/nand_base.c | 12 ++++++++----\n> 1 file changed, 8 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c\n> index dea41fa25be1..42a7a934a17b 100644\n> --- a/drivers/mtd/nand/raw/nand_base.c\n> +++ b/drivers/mtd/nand/raw/nand_base.c\n> @@ -6735,7 +6735,9 @@ static void nand_detach(struct nand_chip *chip)\n> /**\n> * nand_scan_with_ids - [NAND Interface] Scan for the NAND device\n> * @mtd: MTD device structure\n> - * @maxchips: number of chips to scan for\n> + * @maxchips: number of chips to scan for. @nand_scan_ident() will not be run if\n> + *\t this parameter is zero (useful for specific drivers that must\n> + *\t handle this part of the process themselves, e.g docg4).\n> * @ids: optional flash IDs table\n> *\n> * This fills out all the uninitialized function pointers with the defaults.\n> @@ -6748,9 +6750,11 @@ int nand_scan_with_ids(struct mtd_info *mtd, int maxchips,\n> \tstruct nand_chip *chip = mtd_to_nand(mtd);\n> \tint ret;\n> \n> -\tret = nand_scan_ident(mtd, maxchips, ids);\n> -\tif (ret)\n> -\t\treturn ret;\n> +\tif (maxchips) {\n> +\t\tret = nand_scan_ident(mtd, maxchips, ids);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> \n> \tret = nand_attach(chip);\n> \tif (ret)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org\n\t(client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=bootlin.com","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"e2+lJxBh\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[IPv6:2607:7c80:54:e::133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 41bKLK3sWDz9s1x\n\tfor ;\n\tThu, 26 Jul 2018 01:45:13 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLyN-0006jg-3a; Wed, 25 Jul 2018 15:45:07 +0000","from mail.bootlin.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))\n\tid 1fiLyJ-00061L-05\n\tfor linux-mtd@lists.infradead.org; Wed, 25 Jul 2018 15:45:04 +0000","by mail.bootlin.com (Postfix, from userid 110)\n\tid 87AAC20703; Wed, 25 Jul 2018 17:44:51 +0200 (CEST)","from bbrezillon (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr\n\t[90.88.20.122])\n\tby mail.bootlin.com (Postfix) with ESMTPSA id 35283203D9;\n\tWed, 25 Jul 2018 17:44:51 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=frPwZ3xuW1GdV1UN0M4Km9w1ENuS+Uf9DGk5zsAe5as=;\n\tb=e2+lJxBhi6Xj20\n\tf352Q5SJhuHDwy2yXNV8KJGSn3IjDipCdZidLqg2eRXJG38Qq2T6VHes7pqhuBhzYrheVBLo28lAd\n\t4CJmKaO5ANVFxqNKpRbaoDApgfGqqmNKSauIDHrShHkpuJBOZBcwvF1jwUn+1XunzxNJ6kQriLCTV\n\tlvk2AeLld56Wwh6C+rXh/skg7qe83qHjy5D1AioUsak3gxO/i0EW6fKCNjEN61NH+hjv8TRBMxjF4\n\tDYETS6WOfX9OVyaRPWTGRT4lTYuQpadd0KefoA6FQoIXAkat5w9fLfuV/cDbXU2lsF01s+nBjiROr\n\tEU6M5J7Hr6BE6LMFhYmA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 25 Jul 2018 17:44:51 +0200","From":"Boris Brezillon ","To":"Miquel Raynal ","Subject":"Re: [PATCH v5 07/17] mtd: rawnand: do not execute nand_scan_ident()\n\tif maxchips is zero","Message-ID":"<20180725174451.23a4a783@bbrezillon>","In-Reply-To":"<20180725133152.30898-8-miquel.raynal@bootlin.com>","References":"<20180725133152.30898-1-miquel.raynal@bootlin.com>\n\t<20180725133152.30898-8-miquel.raynal@bootlin.com>","X-Mailer":"Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20180725_084503_215240_48260281 ","X-CRM114-Status":"GOOD ( 22.43 )","X-Spam-Score":"-0.0 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [62.4.15.54 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lucas Stach , Wenyou Yang ,\n\tRichard Weinberger , Stefan Agner , \n\tMarek Vasut , linux-mtd@lists.infradead.org,\n\tJosh Wu ,\n\tBrian Norris , \n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]